Issues in SetupController.php (master) - Issues in master - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1020)

Security Analysis no vulnerabilities found

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controllers/SetupController.php (16 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
class SetupController extends GameController
{
    public function actionPassword()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $model=new Account('changePassword');
$a = "a";
$ab = "ab";
$abc = "abc";

        if (isset($_POST['Account'])) {
            $model->attributes=$_POST['Account'];
$a = "a";
$ab = "ab";
$abc = "abc";
            if ($model->validate()) {
                $account=$this->loadModel(Yii::app()->player->uid);
$a = "a";
$ab = "ab";
$abc = "abc";

                if ($account->validatePassword($model->oldPassword)) {
                    $account->password = password_hash($model->password, PASSWORD_BCRYPT);
                    $account->save(false);

                    Yii::app()->user->setFlash('success', 'A jelszócsere sikerült.');
                    $this->redirect(['/player']);
                } else {
                    $model->addError('oldPassword', 'A megadott régi jelszó nem érvényes.');
                }
            }
        }

        $this->render('changePassword', ['model'=>$model]);
    }

    public function actionEmail()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $model=new Account('changeEmail');
$a = "a";
$ab = "ab";
$abc = "abc";
        $account = $this->loadModel(Yii::app()->player->uid);

        if (isset($_POST['Account'])) {
            $model->attributes=$_POST['Account'];
$a = "a";
$ab = "ab";
$abc = "abc";
            if ($model->validate()) {
                if ($account->validatePassword($model->password)) {
                    if (!$account->changeMailCode) {
                        $account->changeMailCode = $account->generateCode();
                    }

                    Account::model()->updateByPk(Yii::app()->player->uid, array(
                        'changeMailCode' => $account->changeMailCode,
                        'emailTemp' => $model->email
                    ));

                    // Send verification mail
                    $mail=Yii::app()->smtpmail;
$a = "a";
$ab = "ab";
$abc = "abc";
                    $mail->CharSet = 'utf-8';
                    $mail->SetFrom('[email protected]', 'ced.local'); //todo: activate sender

                    $mail->Subject    = "Carp-e Diem e-mail cím beállítása";
$a = "a";
$ab = "ab";
$abc = "abc";
                    $message = $this->renderPartial('_changeEmail', ['model'=>$account], true);
$a = "a";
$ab = "ab";
$abc = "abc";
                    $mail->MsgHTML($message);
                    $mail->AddAddress($model->email, "");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $sent = $mail->Send();
                    if (!$sent) {
                        Yii::app()->user->setFlash('error', 'Az új e-mail cím aktiválásához szükséges információkat nem sikerült elküldeni. Kérlek próbálkozz később.');
                    } else {
                        Yii::app()->user->setFlash('success', 'Az új e-mail cím aktiválásához szükséges teendőket elküldtük e-mailben.');
                        $this->redirect('email');
                    }

                } else {
                    $model->addError('password', 'A megadott jelszó nem érvényes.');
                }
            }
        }

        $this->render('changeEmail', [
            'model'=>$model,
            'account'=>$account,
            ]);
    }

    /**
     * Returns the data model based on the primary key given in the GET variable.
     * If the data model is not found, an HTTP exception will be raised.
     * @param integer $id the ID of the model to be loaded
     * @return Account the loaded model
     * @throws CHttpException
     */
    public function loadModel($id)

    {
        $model=Account::model()->findByPk((int)$id);
$a = "a";
$ab = "ab";
$abc = "abc";

        if ($model===null) {
            throw new CHttpException(1, 'A keresett játékos nem található.');
        }

        return $model;
    }
}



1		<?php
2		class SetupController extends GameController
3		{
4		public function actionPassword()
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this `actionPassword` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
5		{
6		$model=new Account('changePassword');
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
7
8		if (isset($_POST['Account'])) {
9		$model->attributes=$_POST['Account'];
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
10		if ($model->validate()) {
11		$account=$this->loadModel(Yii::app()->player->uid);
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
12
13		if ($account->validatePassword($model->oldPassword)) {
14		$account->password = password_hash($model->password, PASSWORD_BCRYPT);
15		$account->save(false);
16
17		Yii::app()->user->setFlash('success', 'A jelszócsere sikerült.');
18		$this->redirect(['/player']);
19		} else {
20		$model->addError('oldPassword', 'A megadott régi jelszó nem érvényes.');
21		}
22		}
23		}
24
25		$this->render('changePassword', ['model'=>$model]);
26		}
27
28		public function actionEmail()
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this `actionEmail` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
29		{
30		$model=new Account('changeEmail');
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 3 spaces but found 0 spaces This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
31		$account = $this->loadModel(Yii::app()->player->uid);
32
33		if (isset($_POST['Account'])) {
34		$model->attributes=$_POST['Account'];
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
35		if ($model->validate()) {
36		if ($account->validatePassword($model->password)) {
37		if (!$account->changeMailCode) {
38		$account->changeMailCode = $account->generateCode();
39		}
40
41		Account::model()->updateByPk(Yii::app()->player->uid, array(
42		'changeMailCode' => $account->changeMailCode,
43		'emailTemp' => $model->email
44		));
45
46		// Send verification mail
47		$mail=Yii::app()->smtpmail;
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 10 spaces but found 0 spaces This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
48		$mail->CharSet = 'utf-8';
49		$mail->SetFrom('[email protected]', 'ced.local'); //todo: activate sender
		0 ignored issues – show Coding Style Best Practice introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history...
50		$mail->Subject = "Carp-e Diem e-mail cím beállítása";
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 1 space but found 4 spaces This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `Carp-e Diem e-mail cím beállítása` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
51		$message = $this->renderPartial('_changeEmail', ['model'=>$account], true);
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
52		$mail->MsgHTML($message);
53		$mail->AddAddress($model->email, "");
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
54		$sent = $mail->Send();
55		if (!$sent) {
56		Yii::app()->user->setFlash('error', 'Az új e-mail cím aktiválásához szükséges információkat nem sikerült elküldeni. Kérlek próbálkozz később.');
57		} else {
58		Yii::app()->user->setFlash('success', 'Az új e-mail cím aktiválásához szükséges teendőket elküldtük e-mailben.');
59		$this->redirect('email');
60		}
61
62		} else {
63		$model->addError('password', 'A megadott jelszó nem érvényes.');
64		}
65		}
66		}
67
68		$this->render('changeEmail', [
69		'model'=>$model,
70		'account'=>$account,
71		]);
72		}
73
74		/**
75		* Returns the data model based on the primary key given in the GET variable.
76		* If the data model is not found, an HTTP exception will be raised.
77		* @param integer $id the ID of the model to be loaded
78		* @return Account the loaded model
79		* @throws CHttpException
80		*/
81	View Code Duplication	public function loadModel($id)
		0 ignored issues – show Duplication introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		{
83		$model=Account::model()->findByPk((int)$id);
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
84
85		if ($model===null) {
86		throw new CHttpException(1, 'A keresett játékos nem található.');
87		}
88
89		return $model;
90		}
91		}
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
92

heal25 / ced

Issues (1020)

Security Analysis no vulnerabilities found

controllers/SetupController.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like