Issues in MissionsController.php (master) - Issues in master - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1020)

Security Analysis no vulnerabilities found

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controllers/MissionsController.php (23 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
class MissionsController extends GameController
{
    public function actionIndex()
    {
        $this->redirect(['missions/list', 'id'=>Yii::app()->player->model->last_location]);
    }

    public function actionList($id = 1)
    {
        $location = new Location();
        $location->setId($id);
        if (!$location->isVisited()) {
            Yii::app()->player->model->rewriteAttributes(['last_location'=>1]);
            $this->render('not_visited');
            return false;
        }

        $location->setActive();

        //list missions
        $location->fetchRoutine();
        $location->fetchMissions();

        //complete selected mission
        $mission_id = Yii::app()->request->getPost('mission_id', 0);
$a = "a";
$ab = "ab";
$abc = "abc";
        $completedId = 0;
        $error = '';
$a = "a";
$ab = "ab";
$abc = "abc";
        if ($mission_id) {
            $error = '';
            try {
                $locAction = new LocationAction();
$a = "a";
$ab = "ab";
$abc = "abc";
                $locAction->location = $location;

                $locAction->completeMission($mission_id);
                $completedId = $locAction->completedId;

            } catch (CFlashException $e) {
                $error = $e->getMessage();
            }
        }

        //name of location
        $name = [
            'location' => $location->getName(),
                'county' => $location->getCounty(),
                ];

        //navigation from current location
        $nav = $location->getNavigationLinks();

        //tutorial
        $tutorialToShow = 0;
        if ($id==1) {
            //only in first location
            $tutorial = new Tutorial;
$a = "a";
$ab = "ab";
$abc = "abc";
            $tutorial->state = Yii::app()->player->model->tutorial_mission;
$a = "a";
$ab = "ab";
$abc = "abc";
            $tutorial->location = $location;

            $tutorialToShow = $tutorial->descriptionToShow;
$a = "a";
$ab = "ab";
$abc = "abc";
        }
        $this->render('index', [
            'location' => $location,
            'name' => $name,
            'missions'=>$location->missions,

            'missionTypeList'=>$location->missionTypes,

            'nav' => $nav,
            'mission_id'=>$mission_id,
            'completedId'=>$completedId,
            'routine'=>$location->routineStars,
            'tutorialToShow'=>$tutorialToShow,
            'error'=>$error,
            ]);

    }

    public function actionMap()
    {
        $this->layout = 'fullscreen';

        $location = new Location();
        $visited = $location->listVisited();
$a = "a";
$ab = "ab";
$abc = "abc";

        $center = Yii::app()->params['mapCenterCoords']; //id 1
$a = "a";
$ab = "ab";
$abc = "abc";
        $last = [];
$a = "a";
$ab = "ab";
$abc = "abc";
        $locations = [];
        foreach ($visited as $v) {
            $id = (int)$v['id'];
$a = "a";
$ab = "ab";
$abc = "abc";
            $txtRoutine = '';
            if ($v['routine']) {
                $routine = $location->getRoutineStars($v['routine']);
$a = "a";
$ab = "ab";
$abc = "abc";
                $txtRoutine = 'Helyszínen megszerzett rutinod: <br/>';
$a = "a";
$ab = "ab";
$abc = "abc";
                $txtRoutine .= $location->getRoutineImages($routine);
            } else {
                $last[] = $id;
            }

            $locations[] = "[{$v['position']}, '{$v['title']}', {$id}, '{$txtRoutine}']";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            if (isset($v['last'])) {
                $center = $v['position'];
            }
        }

        $this->render('map', [
            'visited'=>$visited,
            'locations'=>implode(",\n", $locations),
            'center'=>$center,
            'last'=>implode(', ', $last)
            ]);
    }
}



1			<?php
2			class MissionsController extends GameController
3			{
4			public function actionIndex()
5			{
6			$this->redirect(['missions/list', 'id'=>Yii::app()->player->model->last_location]);
7			}
8
9			public function actionList($id = 1)
10			{
11			$location = new Location();
12			$location->setId($id);
13			if (!$location->isVisited()) {
14			Yii::app()->player->model->rewriteAttributes(['last_location'=>1]);
15			$this->render('not_visited');
16			return false;
17			}
18
19			$location->setActive();
20
21			//list missions
22			$location->fetchRoutine();
23			$location->fetchMissions();
24
25			//complete selected mission
26			$mission_id = Yii::app()->request->getPost('mission_id', 0);
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
27			$completedId = 0;
28			$error = '';
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
29			if ($mission_id) {
30			$error = '';
31			try {
32			$locAction = new LocationAction();
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
33			$locAction->location = $location;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `location` cannot be accessed from this context as it is declared `private` in class `LocationAction`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
34			$locAction->completeMission($mission_id);
35			$completedId = $locAction->completedId;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `completedId` cannot be accessed from this context as it is declared `private` in class `LocationAction`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
36			} catch (CFlashException $e) {
37			$error = $e->getMessage();
38			}
39			}
40
41			//name of location
42			$name = [
43			'location' => $location->getName(),
44			'county' => $location->getCounty(),
45			];
46
47			//navigation from current location
48			$nav = $location->getNavigationLinks();
49
50			//tutorial
51			$tutorialToShow = 0;
52			if ($id==1) {
53			//only in first location
54			$tutorial = new Tutorial;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
55			$tutorial->state = Yii::app()->player->model->tutorial_mission;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `state` cannot be accessed from this context as it is declared `private` in class `Tutorial`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
56			$tutorial->location = $location;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `location` cannot be accessed from this context as it is declared `private` in class `Tutorial`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
57			$tutorialToShow = $tutorial->descriptionToShow;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `descriptionToShow` cannot be accessed from this context as it is declared `private` in class `Tutorial`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
58			}
59			$this->render('index', [
60			'location' => $location,
61			'name' => $name,
62			'missions'=>$location->missions,
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `missions` cannot be accessed from this context as it is declared `private` in class `Location`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
63			'missionTypeList'=>$location->missionTypes,
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `missionTypes` cannot be accessed from this context as it is declared `private` in class `Location`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
64			'nav' => $nav,
65			'mission_id'=>$mission_id,
66			'completedId'=>$completedId,
67			'routine'=>$location->routineStars,
68			'tutorialToShow'=>$tutorialToShow,
69			'error'=>$error,
70			]);
71
72			}
73
74			public function actionMap()
75			{
76			$this->layout = 'fullscreen';
77
78			$location = new Location();
79			$visited = $location->listVisited();
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
80
81			$center = Yii::app()->params['mapCenterCoords']; //id 1
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
82			$last = [];
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
83			$locations = [];
84			foreach ($visited as $v) {
85			$id = (int)$v['id'];
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
86			$txtRoutine = '';
87			if ($v['routine']) {
88			$routine = $location->getRoutineStars($v['routine']);
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
89			$txtRoutine = 'Helyszínen megszerzett rutinod: <br/>';
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
90			$txtRoutine .= $location->getRoutineImages($routine);
91			} else {
92			$last[] = $id;
93			}
94
95			$locations[] = "[{$v['position']}, '{$v['title']}', {$id}, '{$txtRoutine}']";
			0 ignored issues – show Coding Style Best Practice introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, please use concatenation or `sprintf` for the variable `$v` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history... Coding Style Best Practice introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, please use concatenation or `sprintf` for the variable `$id` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history... Coding Style Best Practice introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, please use concatenation or `sprintf` for the variable `$txtRoutine` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
96			if (isset($v['last'])) {
97			$center = $v['position'];
98			}
99			}
100
101			$this->render('map', [
102			'visited'=>$visited,
103			'locations'=>implode(",\n", $locations),
104			'center'=>$center,
105			'last'=>implode(', ', $last)
106			]);
107			}
108			}
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
109

heal25 / ced

Issues (1020)

Security Analysis no vulnerabilities found

controllers/MissionsController.php (23 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like