Issues in ClubController.php (master) - Issues in master - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1020)

Security Analysis no vulnerabilities found

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controllers/ClubController.php (68 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
class ClubController extends GameController
{
    private $moderation = [
        'fired'=>0,
        'approved'=>0,
        'deleted'=>0
        ];

    public function actionIndex()
    {
        $controller = Yii::app()->player->model->in_club ? 'own' : 'list';
        $this->redirect('/club/' . $controller);
    }

    public function actionList($page = 0)
    {
        $this->renderList($page, false);
    }

    public function actionListCompete($page = 0)
    {
        $this->renderList($page, true);
    }

    /**
     * @param integer $page
     * @param boolean $compete
     */
    protected function renderList($page, $compete)
    {
        $model=new Club;
$a = "a";
$ab = "ab";
$abc = "abc";

        $model->page = $page;

        $model->fetchItems($compete);

        $template = $compete ? 'listcompete' : 'list';
        $this->render($template, [
            'list'=>$model->items,

            'pagination' => $model->pagination,

            'count' => $model->count,

            'page_size' => Yii::app()->params['listPerPage'],
            'page'=>$page,
            ]);
    }

    public function actionCreate()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $model=new ClubAR;
$a = "a";
$ab = "ab";
$abc = "abc";

        if (isset($_POST['ClubAR'])) {
            $model->attributes=$_POST['ClubAR'];
$a = "a";
$ab = "ab";
$abc = "abc";
            if ($model->validate()) {
                if ($model->save()) {
                    $this->redirect(['/club/own']);
                }
            }
        }

        $this->render('create', [
            'model'=>$model,
            ]);
    }

    public function actionDetails($id)
    {
        $player = Yii::app()->player->model;

        $clubID = (int)$id;
$a = "a";
$ab = "ab";
$abc = "abc";
        $in_club = (int)Yii::app()->player->model->in_club;
        if ($in_club == $id) {
            $this->redirect('/club/own');
        }
        //members
        $club = new Club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $club->id = $clubID;

        $club->fetch();

        if (!$club->id) {

            throw new CHttpException(404, 'A keresett klub nem található.');
        }
        $club->fetchMembers();

        $r = Yii::app()->request;
$a = "a";
$ab = "ab";
$abc = "abc";
        $join = $r->getParam('join', 0);
        if ($join) {
            try {
                $club->joinRequest($club->id);

                Yii::app()->user->setFlash('success', 'A csatlakozási kérelmet elküldted. Amint elfogadja valamelyik klubtag, értesítünk.');
            } catch (CFlashException $e) {
                Yii::app()->user->setFlash('error', $e->getMessage());
            }
        }
        $delete = $r->getParam('deleteJoin', 0);
        if ($delete) {
            $club->deleteOwnJoinRequest($club->id);

            Yii::app()->user->setFlash('success', 'A csatlakozási kérelmet visszavontad.');
        }

        $forum = new Forum;

        //challenge
        $ch = new Challenge;
$a = "a";
$ab = "ab";
$abc = "abc";
        $ch->caller = $in_club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $ch->opponent = $clubID;

        $ch->fetchActiveChallenge();

        $call = $r->getParam('call', 0);
        if ($call) {
            try {
                $ch->caller = $in_club;
$a = "a";
$ab = "ab";
$abc = "abc";
                $ch->opponent = $clubID;


                $ch->callToChallenge($club);
                Yii::app()->user->setFlash('success', 'Versenyre hívtad a klubot!');

                $forum->id = $clubID;

                $message = $player->user . ' a saját klubja nevében versenyre hívta a klubot.';
$a = "a";
$ab = "ab";
$abc = "abc";
                $forum->save($message, true);

                $forum->id = $player->in_club;

                $message = $player->user . ' versenyre hívta a következő klubot: ' . $club->name;
$a = "a";
$ab = "ab";
$abc = "abc";
                $forum->save($message, true);
            } catch (CFlashException $e) {
                Yii::app()->user->setFlash('error', $e->getMessage());
            }
        }


        $forum->id = $clubID;

        $forum->fetchItems();

        $this->render('details', [
            'clubID'=>$clubID,
            'club'=>$club,
            'challenge'=>$ch,
            'list'=>$forum->items,

            'pagination' => $forum->pagination,

            'count' => $forum->count,

            'page_size' => Yii::app()->params['listPerPage'],
            'page'=>0,
            'moderation'=>$this->moderation,
            ]);
    }
    public function actionOwn($page = 0)
    {
        $player = Yii::app()->player->model;
        if (!$player->in_club) {
            $this->redirect(['/club/list']);
        }

        //forum
        $forum = new Forum;
$a = "a";
$ab = "ab";
$abc = "abc";
        $forum->id = $player->in_club;

        $forum->fetchItems();

        //members
        $club = new Club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $club->id = $player->in_club;

        $club->fetch();
        $club->fetchMembers();

        //challenge
        $ch = new Challenge;
$a = "a";
$ab = "ab";
$abc = "abc";
        $ch->opponent = $club->id;

        $ch->fetchActiveChallenge();

        try {
            $this->fireMember($club, $ch, $forum);
            $this->acceptApproval($club, $forum);
            $this->deleteApproval($club, $forum);
            $this->switchCompete($club, $ch);

        } catch (CFlashException $e) {
            Yii::app()->user->setFlash('error', $e->getMessage());
        }

        $this->render('own', [
            'clubID'=>$player->in_club,
            'club'=>$club,
            'challenge'=>$ch,
            'list'=>$forum->items,

            'pagination' => $forum->pagination,

            'count' => $forum->count,

            'page_size' => Yii::app()->params['listPerPage'],
            'page'=>$page,
            'moderation'=>$this->moderation,
            ]);
    }

    /**
     * @param Club $club
     * @param Challenge $challenge
     * @param Forum $forum
     */
    private function fireMember($club, $challenge, $forum)
    {
        $player = Yii::app()->player->model;

        $fire = (int)Yii::app()->request->getParam('fire', false);
        if ($fire) {
            if ($challenge->active) {

                throw new CFlashException('Verseny közben nem lehet tagot kidobni.');
            }

            $fireUser = isset($club->members[$fire]['user']) ? $club->members[$fire]['user'] : '???';

            if ($club->fireMember($fire)) {
                $this->moderation['fired'] = $fire;
                //forum notice
                $message = $fire==$player->uid ? $player->user . ' kilépett a klubból.' : $player->user . ' visszavonta ' . $fireUser . ' tagságát.';
                $forum->save($message, true);
                //wall notice
                $this->wallNotice($club, Wall::TYPE_CLUB_FIRE, $fire);
            }
        }
    }

    /**
     * @param Club $club
     * @param Forum $forum
     */
    private function acceptApproval($club, $forum)
    {
        $player = Yii::app()->player->model;

        $approve = (int)Yii::app()->request->getParam('approve', false);
        if ($approve) {
            if ($club->approveMember($approve)) {
                $this->moderation['approved'] = $approve;
                //forum notice
                $message = $player->user . ' elfogadta ' . $club->members[$approve]['user'] . ' felvételi kérelmét.';

                $forum->save($message, true);
                //wall notice
                $this->wallNotice($club, Wall::TYPE_CLUB_APPROVE, $club->members[$approve]['uid']);

            }
        }
    }

    /**
     * @param Club $club
     * @param Forum $forum
     */
    private function deleteApproval($club, $forum)
    {
        $player = Yii::app()->player->model;

        $delete = (int)Yii::app()->request->getParam('delete', false);
        if ($delete) {
            $deleteUser = isset($club->entrants[$delete]['user']) ? $club->entrants[$delete]['user'] : '???';

            if ($club->deleteJoinRequest($delete)) {
                $this->moderation['deleted'] = $delete;
                //forum notice
                $message = $player->user . ' elutasította ' . $deleteUser . ' felvételi kérelmét.';
                $forum->save($message, true);
                //wall notice
                $this->wallNotice($club, Wall::TYPE_CLUB_DELETE, $delete);
            }
        }
    }

    /**
     * @param Club $club
     * @param Challenge $challenge
     */
    private function switchCompete($club, $challenge)
    {
        $switch = Yii::app()->request->getParam('switch', '');
        if ($switch == 'compete') {
            if ($club->would_compete & $challenge->underLastCallTimeLimit($club->id)) {

                throw new CFlashException('A \'versenyezne\' beállítást csak akkor kapcsolhatod ki, ha legalább '. Challenge::TIME_LIMIT_LASTCALL_HOURS .' óra eltelt azóta, hogy a klubod valakit versenyre hívott.');
            }

            $club->switchCompete();
        }
    }

    /**
     * @param Club $club
     */
    private function wallNotice($club, $type, $uid)
    {
        $player = Yii::app()->player->model;

        //wall notice
        $wall = new Wall;
$a = "a";
$ab = "ab";
$abc = "abc";
        $wall->content_type = $type;

        $wall->uid = $uid;
$a = "a";
$ab = "ab";
$abc = "abc";
        $wall->add([
            'clubID'=>$player->in_club,
            'clubName'=>$club->name,

            'moderatorUid'=>$player->uid,
            'moderator'=>$player->user,
            ]);
    }

    public function actionForum($id, $page = 0)
    {
        $clubID = (int)$id;

        $forum = new Forum;
$a = "a";
$ab = "ab";
$abc = "abc";
        $forum->id = $clubID;


        $r = Yii::app()->request;
$a = "a";
$ab = "ab";
$abc = "abc";
        $post = $r->getPost('post', false);
        if ($post) {
            $forum->private = $r->getPost('private', false);

            $forum->save($post);
        }
        $delete = $r->getParam('delete', 0);
        if ($delete) {
            $forum->delete($delete);
        }

        $forum->page = $page;

        $forum->fetchItems();

        $this->render('forum', [
            'clubID'=>$clubID,
            'list'=>$forum->items,

            'pagination' => $forum->pagination,

            'count' => $forum->count,

            'page_size' => Yii::app()->params['listPerPage'],
            'page'=>$page,
            ]);
    }

    public function actionHistory($id = 0)
    {
        if (!$id) {
            $this->redirect(['/club/list']);
        }

        $club = new Club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $club->id = (int)$id;

        $club->fetch();
        $club->fetchChallenges();

        $this->render('history', [
            'club'=>$club,
            ]);
    }

    public function actionClose()
    {
        $player = Yii::app()->player->model;
        if (!$player->in_club) {
            $this->redirect(['/club/list']);
        }

        //members
        $club = new Club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $club->id = $player->in_club;

        $club->fetch();
        $club->fetchMembers();

        $pass = Yii::app()->request->getPost('pass', '');
        if ($pass) {
            try {
                if ($club->close($pass)) {
                    foreach ($club->members as $member) {

                        $this->wallNotice($club, Wall::TYPE_CLUB_CLOSE, $member['uid']);
                    }
                    Yii::app()->user->setFlash('success', "A klubot megszüntetted.");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $this->redirect(['/club/list']);
                }
            } catch (CFlashException $e) {
                Yii::app()->user->setFlash('error', $e->getMessage());
            }
        }

        $this->render('close', [
            'club'=>$club,
            ]);
    }
}



1			<?php
2			class ClubController extends GameController
3			{
4			private $moderation = [
5			'fired'=>0,
6			'approved'=>0,
7			'deleted'=>0
8			];
9
10			public function actionIndex()
11			{
12			$controller = Yii::app()->player->model->in_club ? 'own' : 'list';
13			$this->redirect('/club/' . $controller);
14			}
15
16			public function actionList($page = 0)
17			{
18			$this->renderList($page, false);
19			}
20
21			public function actionListCompete($page = 0)
22			{
23			$this->renderList($page, true);
24			}
25
26			/**
27			* @param integer $page
28			* @param boolean $compete
29			*/
30			protected function renderList($page, $compete)
31			{
32			$model=new Club;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
33
34			$model->page = $page;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `page` cannot be accessed from this context as it is declared `private` in class `Club`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
35			$model->fetchItems($compete);
36
37			$template = $compete ? 'listcompete' : 'list';
38			$this->render($template, [

heal25 / ced

Issues (1020)

Security Analysis no vulnerabilities found

controllers/ClubController.php (68 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like