ClubAR

Complexity

Total Complexity

14

Size/Duplication

Total Lines	124
Duplicated Lines	2.42 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	5
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	model()	0	4	1
A	tableName()	0	4	1
A	rules()	0	14	1
A	clean()	0	6	1
A	hasOtherClub()	0	6	2
A	nameIsFree()	0	11	2
A	levelRequirement()	3	6	2
A	attributeLabels()	0	9	1
A	search()	0	16	1
A	beforeSave()	0	5	1
A	afterSave()	0	12	1

<?php

/**
 * This is the model class for table "club".
 *
 * The followings are the available columns in table 'club':
 * @property string $id
 * @property integer $owner
 * @property string $name
 * @property string $created
 */
class ClubAR extends CActiveRecord
{
    /**
     * Returns the static model of the specified AR class.
     * @param string $className active record class name.
     * @return Club the static model class
     */
    public static function model($className = __CLASS__)
    {
        return parent::model($className);
    }

    /**
     * @return string the associated database table name
     */
    public function tableName()
    {
        return 'club';
    }

    /**
     * @return array validation rules for model attributes.
     */
    public function rules()
    {
        // NOTE: you should only define rules for those attributes that
        // will receive user inputs.
        return array(
            ['name', 'clean'],
            ['name', 'required'],
            ['name', 'length', 'min'=>6, 'max'=>14],
            ['name', 'levelRequirement'],
            ['name', 'hasOtherClub'],
            ['name', 'nameIsFree'],
            ['id, owner', 'safe', 'on'=>'search'],
        );
    }

    public function clean($attribute)
    {
        $this->$attribute = trim($this->$attribute);
        $this->$attribute = strip_tags($this->$attribute);
        $this->$attribute = htmlspecialchars($this->$attribute);
    }

    public function levelRequirement($attribute, $params)
    {
        if (Yii::app()->player->model->level < Yii::app()->params['clubCreateLevelRequirement']) {

This code seems to be duplicated across your project.

            $this->addError($attribute, 'Saját klub indításához minimum ' . Yii::app()->params['clubCreateLevelRequirement'] . '. szintre kell fejlődnöd.');
        }
    }

    public function hasOtherClub($attribute, $params)
    {
        if (Yii::app()->player->model->in_club) {
            $this->addError($attribute, 'Egy másik klub tagja vagy. Először lépj ki abból.');
        }
    }

    public function nameIsFree($attribute, $params)
    {
        $clubWithSameName = Yii::app()->db->createCommand()
            ->select('id')
            ->from('club')
            ->where('name=:name', [':name'=>$this->$attribute])
            ->queryScalar();
        if ($clubWithSameName) {
            $this->addError($attribute, 'Ez a név már foglalt.');
        }
    }

    /**
     * @return array customized attribute labels (name=>label)
     */
    public function attributeLabels()
    {
        return array(
            'id' => 'ID',
            'owner' => 'Tulajdonos',
            'name' => 'Klub neve',
            'created' => 'Létrehozva',
        );
    }

    /**
     * Retrieves a list of models based on the current search/filter conditions.
     * @return CActiveDataProvider the data provider that can return the models based on the search/filter conditions.
     */
    public function search()
    {
        // Warning: Please modify the following code to remove attributes that
        // should not be searched.

        $criteria=new CDbCriteria;

Equals sign not aligned correctly; expected 1 space but found 0 spaces

        $criteria->compare('id', $this->id, true);
        $criteria->compare('owner', $this->owner);
        $criteria->compare('name', $this->name, true);
        $criteria->compare('created', $this->created, true);

        return new CActiveDataProvider($this, array(
            'criteria'=>$criteria,
        ));
    }

    protected function beforeSave()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $this->owner = Yii::app()->player->uid;
        return parent::beforeSave();
    }

    protected function afterSave()
    {
        $forum = new Forum;

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

        $forum->id = $this->id;

The property id cannot be accessed from this context as it is declared private in class Forum.

        $forum->save(Yii::app()->player->model->user . ' megalapította a klubot.', true);

        Yii::app()->badge->model->triggerSimple('club_create');

        //delete inactive join request
        Yii::app()->db->createCommand()->delete('club_members', 'uid=:uid AND approved=0', [':uid'=>Yii::app()->player->model->uid]);
        parent::afterSave();
    }
}

As per coding style, files should not end with a newline character.