PublicController - Code Metrics - Inspection of "rename AFSZ to AFF" - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (503b21)

by Robert

created 2016-09-06 08:32 UTC

PublicController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	16.33 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	10
Bugs	0	Features	3

Metric	Value
wmc	9
c	10
b	0
f	3
lcom	1
cbo	3
dl	8
loc	49
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
B	actionIndex()	0	25	5
A	actionTerms()	0	4	1
A	actionPrivacy()	0	4	1
A	beforeAction()	8	8	2

How to fix Duplicated Code

<?php
class PublicController extends LoginController
{
    public $layout='//layouts/columnGuest';
$a = "a";
$ab = "ab";
$abc = "abc";

    public function actionIndex()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        Yii::app()->session->open();
        if (isset(Yii::app()->session['uid'])) {
            $this->redirect(['/site']);
        }
        $model=new Account('login');
$a = "a";
$ab = "ab";
$abc = "abc";

        // collect user input data
        if (isset($_POST['Account'])) {
            $model->attributes=$_POST['Account'];
$a = "a";
$ab = "ab";
$abc = "abc";
            // validate user input and redirect to the previous page if valid
            if ($model->validate() && $model->login()) {
                $this->incrementLoginDays(Yii::app()->session['uid']);

                $b = new CommonBadgeActivator;
$a = "a";
$ab = "ab";
$abc = "abc";
                $b->uid = Yii::app()->session['uid'];
                $b->triggerLoginDays();

                $this->redirect('/site');
            }
        }
        // display the login form
        $this->render('/account/login', ['model'=>$model]);
    }

    public function actionTerms()
    {
        $this->render('terms');
    }

    public function actionPrivacy()
    {
        $this->render('privacy');
    }

    protected function beforeAction($action)

    {
        if (Yii::app()->params['isPartOfWline']) {
            throw new CHttpException(1, 'Ez az aloldal nem használható. ' . CHtml::link('főoldal', ['/site'])); //own nick
        }

        return true;
    }
}



1		<?php
2		class PublicController extends LoginController
3		{
4		public $layout='//layouts/columnGuest';
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
5
6		public function actionIndex()
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report `actionIndex` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
7		{
8		Yii::app()->session->open();
9		if (isset(Yii::app()->session['uid'])) {
10		$this->redirect(['/site']);
11		}
12		$model=new Account('login');
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
13
14		// collect user input data
15		if (isset($_POST['Account'])) {
16		$model->attributes=$_POST['Account'];
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
17		// validate user input and redirect to the previous page if valid
18		if ($model->validate() && $model->login()) {
19		$this->incrementLoginDays(Yii::app()->session['uid']);
20
21		$b = new CommonBadgeActivator;
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22		$b->uid = Yii::app()->session['uid'];
23		$b->triggerLoginDays();
24
25		$this->redirect('/site');
26		}
27		}
28		// display the login form
29		$this->render('/account/login', ['model'=>$model]);
30		}
31
32		public function actionTerms()
33		{
34		$this->render('terms');
35		}
36
37		public function actionPrivacy()
38		{
39		$this->render('privacy');
40		}
41
42	View Code Duplication	protected function beforeAction($action)
		0 ignored issues – show Duplication introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		if (Yii::app()->params['isPartOfWline']) {
45		throw new CHttpException(1, 'Ez az aloldal nem használható. ' . CHtml::link('főoldal', ['/site'])); //own nick
46		}
47
48		return true;
49		}
50		}
		0 ignored issues – show Coding Style introduced 2016-08-27 20:56 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
51

heal25 / ced

Branch — master (503b21)

PublicController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like