Challenge - Code Metrics - Inspection of "unused code fix" - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (1ce54d)

by Robert

created 2016-08-27 21:44 UTC

Challenge B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	315
Duplicated Lines	17.78 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	8
Bugs	2	Features	0

Metric	Value
wmc	45
c	8
b	2
f	0
lcom	1
cbo	3
dl	56
loc	315
rs	8.3673

31 Methods

Rating	Name	Duplication	Size	Complexity
A	attributeNames()	0	4	1
A	getId()	0	4	1
A	getActive()	0	4	1
A	getOpponentLink()	0	7	3
A	getCaller()	0	4	1
A	getOpponent()	0	4	1
A	getName_caller()	0	4	1
A	getName_opponent()	0	4	1
A	getCnt_won_caller()	0	4	1
A	getCnt_won_opponent()	0	4	1
A	getPoint_caller()	0	4	1
A	getPoint_opponent()	0	4	1
A	getLoot_caller()	0	4	1
A	getLoot_opponent()	0	4	1
A	getStartTime()	0	4	1
A	getEndTime()	0	4	1
A	getListDuels()	0	4	1
A	getWinner()	0	4	1
A	setId()	0	4	1
A	setCaller()	0	4	1
A	setOpponent()	0	4	1
A	fetch()	16	16	3
A	fetchActiveChallenge()	18	18	3
A	hasActiveChallenge()	0	11	2
A	underCallTimeLimit()	11	11	1
A	underLastCallTimeLimit()	11	11	1
B	callToChallenge()	0	54	7
A	fetchListDuels()	0	21	2
A	getAwards()	0	9	1
A	addCommandToStack()	0	9	1
A	addReminder()	0	7	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Challenge often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Challenge, and based on these observations, apply Extract Interface, too.

<?php
/**
 * @property int $id
 * @property boolean $active
 * @property string $opponentLink
 * @property integer $caller
 * @property integer $opponent
 * @property string $name_caller
 * @property string $name_opponent
 * @property integer $cnt_won_caller
 * @property integer $cnt_won_opponent
 * @property integer $point_caller
 * @property integer $point_opponent
 * @property integer $loot_caller
 * @property integer $loot_opponent
 * @property integer $startTime
 * @property integer $endTime
 * @property array $listDuels
 * @property string $winner
 */
class Challenge extends CModel
{
    const TIME_LIMIT_HOURS = 8;
$a = "a";
$ab = "ab";
$abc = "abc";
    const TIME_LIMIT_LASTCALL_HOURS = 4;

    private $id;
    private $active = false;
    private $caller;
    private $opponent;
    private $loot_caller;
    private $loot_opponent;
    private $cnt_won_caller;
    private $cnt_won_opponent;
    private $point_caller;
    private $point_opponent;
    private $name_caller;
    private $name_opponent;
    private $winner;
    private $created;
    private $listDuels = [];

    public function attributeNames()
    {
        return [];
    }

    public function getId()
    {
        return $this->id;
    }

    public function getActive()
    {
        return $this->active;
    }

    public function getOpponentLink($clubID)

    {
        $oppID = $clubID == $this->caller ? $this->opponent : $this->caller;
$a = "a";
$ab = "ab";
$abc = "abc";
        $oppName = $clubID == $this->caller ? $this->name_opponent : $this->name_caller;

        return CHtml::link($oppName, ['club/details', 'id'=>$oppID], ['data-ajax'=>'false']);
    }

    public function getCaller()
    {
        return $this->caller;
    }

    public function getOpponent()
    {
        return $this->opponent;
    }

    public function getName_caller()

    {
        return $this->name_caller;
    }

    public function getName_opponent()

    {
        return $this->name_opponent;
    }

    public function getCnt_won_caller()

    {
        return $this->cnt_won_caller;
    }

    public function getCnt_won_opponent()

    {
        return $this->cnt_won_opponent;
    }

    public function getPoint_caller()

    {
        return $this->point_caller;
    }

    public function getPoint_opponent()

    {
        return $this->point_opponent;
    }

    public function getLoot_caller()

    {
        return $this->loot_caller;
    }

    public function getLoot_opponent()

    {
        return $this->loot_opponent;
    }

    public function getStartTime()
    {
        return strtotime($this->created) + 1800;
    }

    public function getEndTime()
    {
        return $this->startTime + 1800;
    }

    public function getListDuels()
    {
        return $this->listDuels;
    }

    public function getWinner()

    {
        return $this->winner;
    }

    public function setId($id)
    {
        $this->id = (int)$id;
    }

    public function setCaller($clubID)
    {
        $this->caller = (int)$clubID;
    }

    public function setOpponent($clubID)
    {
        $this->opponent = (int)$clubID;
    }

    public function fetch()

    {
        $res = Yii::app()->db->createCommand()
            ->select('*')
            ->from('challenge')
            ->where('id=:id', [':id'=>$this->id])
            ->queryRow();
        if (!$res) {
            throw new CHttpException(404, 'A lekért verseny nem található.');
        }

        foreach ($res as $k => $v) {
            $this->$k = $v;
        }
        $this->active = !$this->winner;
    }

    public function fetchActiveChallenge()

    {
        $res = Yii::app()->db->createCommand()
            ->select('*')
            ->from('challenge')
            ->where('caller=:id OR opponent=:id', [':id'=>$this->opponent])
            ->order('created DESC')
            ->limit(1)
            ->queryRow();
        if (!$res) {
            return false;
        }

        foreach ($res as $k => $v) {
            $this->$k = $v;
        }
        $this->active = !$this->winner;
    }

    public function hasActiveChallenge($clubID)
    {
        $res = Yii::app()->db->createCommand()
            ->select('id, winner')
            ->from('challenge')
            ->where('caller=:id OR opponent=:id', [':id'=>(int)$clubID])
            ->order('created DESC')
            ->limit(1)
            ->queryRow();
        return $res['id'] && !$res['winner'];
    }

    /**
     * @param integer $opponentID
     */
    public function underCallTimeLimit($clubID, $opponentID)

    {
        $res = Yii::app()->db->createCommand()
            ->select('id, created')
            ->from('challenge')
            ->where('caller=:cid AND opponent=:oid', [':cid'=>(int)$clubID, ':oid'=>$opponentID])
            ->order('created DESC')
            ->limit(1)
            ->queryRow();
        return time() - strtotime($res['created']) <= self::TIME_LIMIT_HOURS * 3600;
    }

    /**
     * @param integer $clubID
     */
    public function underLastCallTimeLimit($clubID)

    {
        $res = Yii::app()->db->createCommand()
            ->select('id, created')
            ->from('challenge')
            ->where('caller=:cid', [':cid'=>(int)$clubID])
            ->order('created DESC')
            ->limit(1)
            ->queryRow();
        return time() - strtotime($res['created']) <= self::TIME_LIMIT_LASTCALL_HOURS * 3600;
    }

    /**
     * @param Club $opponent
     */
    public function callToChallenge($opponent)
    {
        $player = Yii::app()->player->model;

        //requirements
        if (!$player->in_club) {
            throw new CFlashException('Csak egy klub tagjaként vagy alapítójaként hívhatsz ki versenyre másik klubot.');
        }

        if ($this->active) {
            throw new CFlashException('Ez a klub már részt vesz egy másik versenyben.');
        }

        if (!$opponent->would_compete) {

            throw new CFlashException('Ez a klub nem szeretne versenyezni.');
        }

        if ($this->hasActiveChallenge($player->in_club)) {
            throw new CFlashException('A klubod már részt vesz egy versenyben.');
        }

        if ($this->underCallTimeLimit($player->in_club, $this->opponent)) {
            throw new CFlashException('Az elmúlt '. self::TIME_LIMIT_HOURS .' órában már kihívtátok ezt a klubot. Unalmas volna ilyen gyakran játszani ellenük. :)');
        }

        //caller club
        $callerClub = Yii::app()->db->createCommand()
            ->select('name, would_compete')
            ->from('club')
            ->where('id=:clubID', [':clubID'=>$player->in_club])
            ->queryRow();
        if (!$callerClub['would_compete']) {
            throw new CFlashException('Mielőtt versenyre hívsz egy klubot, kapcsold be a saját klubodban a \'versenyezne\' beállítást.');
        }

        Yii::app()->db->createCommand()
            ->insert('challenge', [
            'caller'=>$this->caller,
            'opponent'=>$this->opponent,
            'name_caller'=>$callerClub['name'],
            'name_opponent'=>$opponent->name,

            ]);
        //set properties
        $this->fetchActiveChallenge();

        $this->addCommandToStack([
            'id'=>$this->id,
            ]);

        //add reminder
        $this->addReminder();

        return true;
    }

    public function fetchListDuels()
    {
        $res = Yii::app()->db->createCommand()
$a = "a";
$ab = "ab";
$abc = "abc";
            ->select('*')
            ->from('duel')
            ->where('challenge_id=:id', [':id'=>$this->id])
            ->order('id DESC')
            ->queryAll();
        $player = new Player;
        foreach ($res as $d) {
            $player->subjectId = $d['caller'];
            $d['name_caller'] = $player->getSubjectName();
$a = "a";
$ab = "ab";
$abc = "abc";

            $player->subjectId = $d['opponent'];
$a = "a";
$ab = "ab";
$abc = "abc";
            $d['name_opponent'] = $player->getSubjectName();

            $d['awards'] = $this->getAwards($d['id'], $d['winner']);

            $this->listDuels[] = $d;
        }
    }

    private function getAwards($id, $role)

    {
        $res = Yii::app()->db->createCommand()
            ->select('award_dollar, duel_points, club')
            ->from('duel_player')
            ->where('duel_id=:id AND role=:role', [':id'=>(int)$id, ':role'=>$role])
            ->queryRow();
        return $res;
    }

    private function addCommandToStack($params)
    {
        Yii::app()->db->createCommand()
            ->insert('command_stack', [
            'command'=>'endChallenge',
            'process_time'=>date('Y-m-d H:i:s', time()+3600), //1800+1800
            'params'=>CJSON::encode($params)
            ]);
    }

    private function addReminder()
    {
        $redis = Yii::app()->redis->getClient();

        $redis->set('reminder:challenge:'.$this->caller, time()+3600);
        $redis->set('reminder:challenge:'.$this->opponent, time()+3600);
    }
}



1		<?php
2		/**
3		* @property int $id
4		* @property boolean $active
5		* @property string $opponentLink
6		* @property integer $caller
7		* @property integer $opponent
8		* @property string $name_caller
9		* @property string $name_opponent
10		* @property integer $cnt_won_caller
11		* @property integer $cnt_won_opponent
12		* @property integer $point_caller
13		* @property integer $point_opponent
14		* @property integer $loot_caller
15		* @property integer $loot_opponent
16		* @property integer $startTime
17		* @property integer $endTime
18		* @property array $listDuels
19		* @property string $winner
20		*/
21		class Challenge extends CModel
22		{
23		const TIME_LIMIT_HOURS = 8;
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
24		const TIME_LIMIT_LASTCALL_HOURS = 4;
25
26		private $id;
27		private $active = false;
28		private $caller;
29		private $opponent;
30		private $loot_caller;
31		private $loot_opponent;
32		private $cnt_won_caller;
33		private $cnt_won_opponent;
34		private $point_caller;
35		private $point_opponent;
36		private $name_caller;
37		private $name_opponent;
38		private $winner;
39		private $created;
40		private $listDuels = [];
41
42		public function attributeNames()
43		{
44		return [];
45		}
46
47		public function getId()
48		{
49		return $this->id;
50		}
51
52		public function getActive()
53		{
54		return $this->active;
55		}
56
57		public function getOpponentLink($clubID)
		0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
58		{
59		$oppID = $clubID == $this->caller ? $this->opponent : $this->caller;
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
60		$oppName = $clubID == $this->caller ? $this->name_opponent : $this->name_caller;
61
62		return CHtml::link($oppName, ['club/details', 'id'=>$oppID], ['data-ajax'=>'false']);
63		}
64
65		public function getCaller()
66		{
67		return $this->caller;
68		}
69
70		public function getOpponent()
71		{
72		return $this->opponent;
73		}
74
75		public function getName_caller()
		0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
76		{
77		return $this->name_caller;
78		}
79
80		public function getName_opponent()
		0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
81		{
82		return $this->name_opponent;
83		}
84
85		public function getCnt_won_caller()
		0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
86		{
87		return $this->cnt_won_caller;
88		}
89
90		public function getCnt_won_opponent()
		0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
91		{
92		return $this->cnt_won_opponent;
93		}
94
95		public function getPoint_caller()
		0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
96		{
97		return $this->point_caller;
98		}
99
100		public function getPoint_opponent()
		0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
101		{
102		return $this->point_opponent;
103		}
104
105		public function getLoot_caller()
		0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
106		{
107		return $this->loot_caller;
108		}
109
110		public function getLoot_opponent()
		0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
111		{
112		return $this->loot_opponent;
113		}
114
115		public function getStartTime()
116		{
117		return strtotime($this->created) + 1800;
118		}
119
120		public function getEndTime()
121		{
122		return $this->startTime + 1800;
123		}
124
125		public function getListDuels()
126		{
127		return $this->listDuels;
128		}
129
130		public function getWinner()
		0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
131		{
132		return $this->winner;
133		}
134
135		public function setId($id)
136		{
137		$this->id = (int)$id;
138		}
139
140		public function setCaller($clubID)
141		{
142		$this->caller = (int)$clubID;
143		}
144
145		public function setOpponent($clubID)
146		{
147		$this->opponent = (int)$clubID;
148		}
149
150	View Code Duplication	public function fetch()
		0 ignored issues – show Duplication introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151		{
152		$res = Yii::app()->db->createCommand()
153		->select('*')
154		->from('challenge')
155		->where('id=:id', [':id'=>$this->id])
156		->queryRow();
157		if (!$res) {
158		throw new CHttpException(404, 'A lekért verseny nem található.');
159		}
160
161		foreach ($res as $k => $v) {
162		$this->$k = $v;
163		}
164		$this->active = !$this->winner;
165		}
166
167	View Code Duplication	public function fetchActiveChallenge()
		0 ignored issues – show Duplication introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
168		{
169		$res = Yii::app()->db->createCommand()
170		->select('*')
171		->from('challenge')
172		->where('caller=:id OR opponent=:id', [':id'=>$this->opponent])
173		->order('created DESC')
174		->limit(1)
175		->queryRow();
176		if (!$res) {
177		return false;
178		}
179
180		foreach ($res as $k => $v) {
181		$this->$k = $v;
182		}
183		$this->active = !$this->winner;
184		}
185
186		public function hasActiveChallenge($clubID)
187		{
188		$res = Yii::app()->db->createCommand()
189		->select('id, winner')
190		->from('challenge')
191		->where('caller=:id OR opponent=:id', [':id'=>(int)$clubID])
192		->order('created DESC')
193		->limit(1)
194		->queryRow();
195		return $res['id'] && !$res['winner'];
196		}
197
198		/**
199		* @param integer $opponentID
200		*/
201	View Code Duplication	public function underCallTimeLimit($clubID, $opponentID)
		0 ignored issues – show Duplication introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
202		{
203		$res = Yii::app()->db->createCommand()
204		->select('id, created')
205		->from('challenge')
206		->where('caller=:cid AND opponent=:oid', [':cid'=>(int)$clubID, ':oid'=>$opponentID])
207		->order('created DESC')
208		->limit(1)
209		->queryRow();
210		return time() - strtotime($res['created']) <= self::TIME_LIMIT_HOURS * 3600;
211		}
212
213		/**
214		* @param integer $clubID
215		*/
216	View Code Duplication	public function underLastCallTimeLimit($clubID)
		0 ignored issues – show Duplication introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
217		{
218		$res = Yii::app()->db->createCommand()
219		->select('id, created')
220		->from('challenge')
221		->where('caller=:cid', [':cid'=>(int)$clubID])
222		->order('created DESC')
223		->limit(1)
224		->queryRow();
225		return time() - strtotime($res['created']) <= self::TIME_LIMIT_LASTCALL_HOURS * 3600;
226		}
227
228		/**
229		* @param Club $opponent
230		*/
231		public function callToChallenge($opponent)
232		{
233		$player = Yii::app()->player->model;
234
235		//requirements
236		if (!$player->in_club) {
237		throw new CFlashException('Csak egy klub tagjaként vagy alapítójaként hívhatsz ki versenyre másik klubot.');
238		}
239
240		if ($this->active) {
241		throw new CFlashException('Ez a klub már részt vesz egy másik versenyben.');
242		}
243
244		if (!$opponent->would_compete) {
		0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `would_compete` cannot be accessed from this context as it is declared `private` in class `Club`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
245		throw new CFlashException('Ez a klub nem szeretne versenyezni.');
246		}
247
248		if ($this->hasActiveChallenge($player->in_club)) {
249		throw new CFlashException('A klubod már részt vesz egy versenyben.');
250		}
251
252		if ($this->underCallTimeLimit($player->in_club, $this->opponent)) {
253		throw new CFlashException('Az elmúlt '. self::TIME_LIMIT_HOURS .' órában már kihívtátok ezt a klubot. Unalmas volna ilyen gyakran játszani ellenük. :)');
254		}
255
256		//caller club
257		$callerClub = Yii::app()->db->createCommand()
258		->select('name, would_compete')
259		->from('club')
260		->where('id=:clubID', [':clubID'=>$player->in_club])
261		->queryRow();
262		if (!$callerClub['would_compete']) {
263		throw new CFlashException('Mielőtt versenyre hívsz egy klubot, kapcsold be a saját klubodban a \'versenyezne\' beállítást.');
264		}
265
266		Yii::app()->db->createCommand()
267		->insert('challenge', [
268		'caller'=>$this->caller,
269		'opponent'=>$this->opponent,
270		'name_caller'=>$callerClub['name'],
271		'name_opponent'=>$opponent->name,
		0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `name` cannot be accessed from this context as it is declared `private` in class `Club`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
272		]);
273		//set properties
274		$this->fetchActiveChallenge();
275
276		$this->addCommandToStack([
277		'id'=>$this->id,
278		]);
279
280		//add reminder
281		$this->addReminder();
282
283		return true;
284		}
285
286		public function fetchListDuels()
287		{
288		$res = Yii::app()->db->createCommand()
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
289		->select('*')
290		->from('duel')
291		->where('challenge_id=:id', [':id'=>$this->id])
292		->order('id DESC')
293		->queryAll();
294		$player = new Player;
295		foreach ($res as $d) {
296		$player->subjectId = $d['caller'];
297		$d['name_caller'] = $player->getSubjectName();
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
298
299		$player->subjectId = $d['opponent'];
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
300		$d['name_opponent'] = $player->getSubjectName();
301
302		$d['awards'] = $this->getAwards($d['id'], $d['winner']);
303
304		$this->listDuels[] = $d;
305		}
306		}
307
308		private function getAwards($id, $role)
		0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
309		{
310		$res = Yii::app()->db->createCommand()
311		->select('award_dollar, duel_points, club')
312		->from('duel_player')
313		->where('duel_id=:id AND role=:role', [':id'=>(int)$id, ':role'=>$role])
314		->queryRow();
315		return $res;
316		}
317
318		private function addCommandToStack($params)
319		{
320		Yii::app()->db->createCommand()
321		->insert('command_stack', [
322		'command'=>'endChallenge',
323		'process_time'=>date('Y-m-d H:i:s', time()+3600), //1800+1800
324		'params'=>CJSON::encode($params)
325		]);
326		}
327
328		private function addReminder()
329		{
330		$redis = Yii::app()->redis->getClient();
331
332		$redis->set('reminder:challenge:'.$this->caller, time()+3600);
333		$redis->set('reminder:challenge:'.$this->opponent, time()+3600);
334		}
335		}
		0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
336

heal25 / ced