SiteController::actionStore() - Code Metrics - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

SiteController::actionStore() C
last analyzed 2016-09-14 21:49 UTC

↳ Parent: SiteController

Complexity

Conditions	11
Paths	216

Size

Total Lines	56
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	56
rs	5.7051
c	0
b	0
f	0
cc	11
eloc	35
nc	216
nop	0

How to fix Long Method Complexity

<?php
class SiteController extends GameController
{
    public function actionIndex()
    {
        $wall = new Wall;
$a = "a";
$ab = "ab";
$abc = "abc";
        $wall->uid = Yii::app()->player->uid;

        $wall->fetchPosts();

        if (Yii::app()->player->model->level < 2) {
            Yii::app()->user->setFlash('info', 'Kezdetnek teljesíts pár megbízást. :) A megbízásokat a '. CHtml::link('Navigáció', ['#left-panel'], ['data-role'=>'button', 'data-inline'=>'true', 'id'=>'nav', 'data-icon'=>'bars', 'data-iconpos'=>'notext']) . ' ikon lenyomásával érheted el.');
        }

        $this->render('index', [
            'posts'=>$wall->posts,

            'banner'=>(date("nd") == Yii::app()->params['smsDate']) ? Yii::app()->params['smsText'] : '',
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            ]);
    }

    public function actionCredits()
    {
        $this->render('credits');
    }

    public function actionStory()
    {
        $this->render('story');
    }

    public function actionHelp()
    {
        $help = new Help;
        $news = [];
        foreach ($help->topics as $topic => $name) {

            $help->topic = (string)$topic;

            $help->fetchItems(1);
            $items = $help->items;


            $news[$topic] = [
                'title'=>$name,
                'body'=>array_shift($items)
                ];
        }

        $this->render('help', [
            'news'=>$news,
            ]);
    }

    public function actionHelpTopic($t = '')
    {
        $help = new Help;
$a = "a";
$ab = "ab";
$abc = "abc";
        $topics = $help->topics;

        if (!array_key_exists($t, $topics)) {
            Yii::app()->user->setFlash('error', 'A választott súgótémakör nem létezik.');
            $this->redirect(['site/help']);
        }

        $help->topic = $t;

        $help->fetchItems();

        $this->render('helptopic', [
            'title'=>$topics[$t],
            'items'=>$help->items,

            ]);
    }

    public function actionSms($id = 1)
    {
        $store = new Store;
$a = "a";
$ab = "ab";
$abc = "abc";
        $store->uid = Yii::app()->player->model->uid;

        if (!array_key_exists($id, $store->packagesSms)) {
            $id = 1;
        }

        $this->render('sms', [
            'package'=>$store->packagesSms[$id],
            ]);
    }

    public function actionStore()
    {
        $store = new Store;
$a = "a";
$ab = "ab";
$abc = "abc";
        $store->uid = Yii::app()->player->model->uid;


        $r = Yii::app()->request;

        $duelShield = new DuelShield();
$a = "a";
$ab = "ab";
$abc = "abc";
        $duelShield->uid = $store->uid;


        //duelShield
        $shield = (int)$r->getPost('shield', 0);
        try {
            if ($shield) {
                if ($duelShield->activate($shield)) {
                    Yii::app()->user->setFlash('success', "Bekapcsoltad a párbaj-pajzsot.");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $this->redirect(['']);
                }
            }
        } catch (CFlashException $e) {
            Yii::app()->user->setFlash('error', $e->getMessage());
        }

        //energy drink
        $energy = (int)$r->getPost('energy', 0);
        try {
            if ($energy) {
                if ($store->refillEnergy()) {
                    Yii::app()->user->setFlash('success', "Megittál egy energiaitalt, ezáltal teljesen feltöltődtél. Remélem ízlett.");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $this->redirect(['']);
                }
            }
        } catch (CFlashException $e) {
            Yii::app()->user->setFlash('error', $e->getMessage());
        }

        //missing set items
        $setItem = (int)$r->getPost('setItem', 0);
        try {
            if ($setItem) {
                if ($store->buySetItem($setItem)) {
                    Yii::app()->user->setFlash('success', "Megvetted a kiválasztott szett elemet. Ilyen típusút jövő héten vásárolhatsz legközelebb.");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $this->redirect(['']);
                }
            }
        } catch (CFlashException $e) {
            Yii::app()->user->setFlash('error', $e->getMessage());
        }

        $this->render('store', [
            'store'=>$store,
            'duelShield' => $duelShield,
            'shieldPrices' => $duelShield->getPrices(),
            'banner'=>(date("nd") == Yii::app()->params['smsDate']) ? Yii::app()->params['smsText'] : '',
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            ]);
    }

    public function actionLogout()
    {
        Yii::app()->user->logout();
        $this->redirect(Yii::app()->homeUrl);
    }
}



1			<?php
2			class SiteController extends GameController
3			{
4			public function actionIndex()
5			{
6			$wall = new Wall;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
7			$wall->uid = Yii::app()->player->uid;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `uid` cannot be accessed from this context as it is declared `private` in class `Wall`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
8			$wall->fetchPosts();
9
10			if (Yii::app()->player->model->level < 2) {
11			Yii::app()->user->setFlash('info', 'Kezdetnek teljesíts pár megbízást. :) A megbízásokat a '. CHtml::link('Navigáció', ['#left-panel'], ['data-role'=>'button', 'data-inline'=>'true', 'id'=>'nav', 'data-icon'=>'bars', 'data-iconpos'=>'notext']) . ' ikon lenyomásával érheted el.');
12			}
13
14			$this->render('index', [
15			'posts'=>$wall->posts,
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `posts` cannot be accessed from this context as it is declared `private` in class `Wall`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
16			'banner'=>(date("nd") == Yii::app()->params['smsDate']) ? Yii::app()->params['smsText'] : '',
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The string literal `nd` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
17			]);
18			}
19
20			public function actionCredits()
21			{
22			$this->render('credits');
23			}
24
25			public function actionStory()
26			{
27			$this->render('story');
28			}
29
30			public function actionHelp()
31			{
32			$help = new Help;
33			$news = [];
34			foreach ($help->topics as $topic => $name) {
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `topics` cannot be accessed from this context as it is declared `private` in class `Help`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
35			$help->topic = (string)$topic;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `topic` cannot be accessed from this context as it is declared `private` in class `Help`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
36			$help->fetchItems(1);
37			$items = $help->items;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `items` cannot be accessed from this context as it is declared `private` in class `Help`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
38
39			$news[$topic] = [
40			'title'=>$name,
41			'body'=>array_shift($items)
42			];
43			}
44
45			$this->render('help', [
46			'news'=>$news,
47			]);
48			}
49
50			public function actionHelpTopic($t = '')
51			{
52			$help = new Help;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
53			$topics = $help->topics;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `topics` cannot be accessed from this context as it is declared `private` in class `Help`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
54			if (!array_key_exists($t, $topics)) {
55			Yii::app()->user->setFlash('error', 'A választott súgótémakör nem létezik.');
56			$this->redirect(['site/help']);
57			}
58
59			$help->topic = $t;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `topic` cannot be accessed from this context as it is declared `private` in class `Help`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
60			$help->fetchItems();
61
62			$this->render('helptopic', [
63			'title'=>$topics[$t],
64			'items'=>$help->items,
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `items` cannot be accessed from this context as it is declared `private` in class `Help`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
65			]);
66			}
67
68			public function actionSms($id = 1)
69			{
70			$store = new Store;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
71			$store->uid = Yii::app()->player->model->uid;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `uid` cannot be accessed from this context as it is declared `private` in class `Store`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
72			if (!array_key_exists($id, $store->packagesSms)) {
73			$id = 1;
74			}
75
76			$this->render('sms', [
77			'package'=>$store->packagesSms[$id],
78			]);
79			}
80
81			public function actionStore()
82			{
83			$store = new Store;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
84			$store->uid = Yii::app()->player->model->uid;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `uid` cannot be accessed from this context as it is declared `private` in class `Store`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
85
86			$r = Yii::app()->request;
87
88			$duelShield = new DuelShield();
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
89			$duelShield->uid = $store->uid;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `uid` cannot be accessed from this context as it is declared `private` in class `DuelShield`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `uid` cannot be accessed from this context as it is declared `private` in class `Store`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
90
91			//duelShield
92			$shield = (int)$r->getPost('shield', 0);
93			try {
94			if ($shield) {
95			if ($duelShield->activate($shield)) {
96			Yii::app()->user->setFlash('success', "Bekapcsoltad a párbaj-pajzsot.");
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The string literal `Bekapcsoltad a párbaj-pajzsot.` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
97			$this->redirect(['']);
98			}
99			}
100			} catch (CFlashException $e) {
101			Yii::app()->user->setFlash('error', $e->getMessage());
102			}
103
104			//energy drink
105			$energy = (int)$r->getPost('energy', 0);
106			try {
107			if ($energy) {
108			if ($store->refillEnergy()) {
109			Yii::app()->user->setFlash('success', "Megittál egy energiaitalt, ezáltal teljesen feltöltődtél. Remélem ízlett.");
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The string literal `Megittál egy energiaita...tél. Remélem ízlett.` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
110			$this->redirect(['']);
111			}
112			}
113			} catch (CFlashException $e) {
114			Yii::app()->user->setFlash('error', $e->getMessage());
115			}
116
117			//missing set items
118			$setItem = (int)$r->getPost('setItem', 0);
119			try {
120			if ($setItem) {
121			if ($store->buySetItem($setItem)) {
122			Yii::app()->user->setFlash('success', "Megvetted a kiválasztott szett elemet. Ilyen típusút jövő héten vásárolhatsz legközelebb.");
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The string literal `Megvetted a kiválasztot...` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
123			$this->redirect(['']);
124			}
125			}
126			} catch (CFlashException $e) {
127			Yii::app()->user->setFlash('error', $e->getMessage());
128			}
129
130			$this->render('store', [
131			'store'=>$store,
132			'duelShield' => $duelShield,
133			'shieldPrices' => $duelShield->getPrices(),
134			'banner'=>(date("nd") == Yii::app()->params['smsDate']) ? Yii::app()->params['smsText'] : '',
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The string literal `nd` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
135			]);
136			}
137
138			public function actionLogout()
139			{
140			Yii::app()->user->logout();
141			$this->redirect(Yii::app()->homeUrl);
142			}
143			}
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
144

heal25 / ced

SiteController::actionStore() C last analyzed 2016-09-14 21:49 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

SiteController::actionStore() C
last analyzed 2016-09-14 21:49 UTC