Shop::constructItem() - Code Metrics - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

Shop::constructItem() B
last analyzed 2016-09-14 21:49 UTC

↳ Parent: Shop

Complexity

Conditions	7
Paths	8

Size

Total Lines	67
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	67
rs	7.0237
c	0
b	0
f	0
cc	7
eloc	43
nc	8
nop	1

How to fix Long Method

<?php
/**
 * @property integer $id
 * @property array $items
 * @property string $item_type
 * @property integer $page
 * @property integer $owned_baits
 * @property integer $owned_items
 * @property array $success
 * @property CPagination $pagination
 * @property integer $count
 * @property integer $transactionId
 * @property integer $levelLimit
 * @property integer $nextItemsLevel
 */
class Shop extends CModel
{
    const TYPE_BAIT = 'bait';
    const TYPE_ITEM = 'item';
    const TYPE_PART = 'part';
    
    private $id;
    private $items = [];
    private $item_type;
    private $page = 0;
    private $pagination;
    private $count;
    private $transactionId;
    private $success = ['setSold'=>false];
    
    public function attributeNames()
    {
        return [];
    }
    
    public function getId()
    {
        return $this->id;
    }

    public function getItems()
    {
        return $this->items;
    }

    public function getOwned_baits()

    {
        return Yii::app()->player->model->owned_baits;
    }

    public function getOwned_items()

    {
        return Yii::app()->player->model->owned_items;
    }

    public function getSuccess()
    {
        return $this->success;
    }

    public function getPagination()
    {
        return $this->pagination;
    }

    public function getCount()

    {
        return $this->count;
    }

    public function getTransactionId()

    {
        return $this->transactionId;
    }

    public function getLevelLimit()
    {
        $player = Yii::app()->player->model;
$a = "a";
$ab = "ab";
$abc = "abc";
        $levelLimit = $player->level;
        if ($player->black_market) {
            $levelLimit += 2;
        }
        return (int)$levelLimit;
    }
    
    public function getNextItemsLevel()

    {
        $nextLevel = Yii::app()->db->createCommand()
            ->select('level')
            ->from($this->item_type.'s')
            ->where('level > :level', [':level'=>Yii::app()->player->model->level])
            ->order('level ASC')
            ->limit(1)
            ->queryScalar();
        return (int)$nextLevel;
    }

    public function setItem_type($type)
    {
        $this->item_type = $type;
    }

    public function setPage($page)
    {
        $this->page = $page;
    }

    public function setId($id)
    {
        $this->id = (int)$id;
    }
    
    public function fetchSets()
    {
        $res = Yii::app()->db->createCommand()
            ->select('id, parts, title')
            ->from('itemsets')
            ->order('id DESC')
            ->queryAll();
         
        foreach ($res as $item) {
            $parts = explode(',', $item['parts']);

            $ownedOne = false;
$a = "a";
$ab = "ab";
$abc = "abc";
            $skill = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
            $constructable = true;
            foreach ($parts as $part) {
                $i = new Item();
$a = "a";
$ab = "ab";
$abc = "abc";
                $i->id = $part;
$a = "a";
$ab = "ab";
$abc = "abc";
                $i->item_type = $this->item_type;

                $i->fetch();
                $skill += $i->skill;
$a = "a";
$ab = "ab";
$abc = "abc";
                $item['items'][$part] = $i;

                if ($i->owned) {

                    $ownedOne = true;
                } else {
                    $constructable = false;
                }

            }
            $item['skill_multiplicator'] = $skill;
            $item['constructable'] = $constructable;
$a = "a";
$ab = "ab";
$abc = "abc";
            $item['sold'] = false;
$a = "a";
$ab = "ab";
$abc = "abc";
            if ($ownedOne) {
                $this->items[$item['id']] = $item;
            }
        }
    }
    
    public function fetchItems()
    {
        $limit = Yii::app()->params['shopItemsPerPage'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $levelLimit = $this->levelLimit;

        $this->count = Yii::app()->db->createCommand()
            ->select('COUNT(*) AS count')
            ->from($this->item_type.'s')
            ->where('level <= :level', [':level'=>$levelLimit])
            ->queryScalar();

        $res = Yii::app()->db->createCommand()
            ->select('id')
            ->from($this->item_type.'s')
            ->where('level <= :level', [':level'=>$levelLimit])
            ->order('skill DESC, level DESC')
            ->limit($limit, ($this->page * $limit) - $limit) // the trick is here!
            ->queryAll();
         
        $this->pagination = new CPagination($this->count);
        $this->pagination->setPageSize(Yii::app()->params['shopItemsPerPage']);
                
        foreach ($res as $item) {
            $i = new Item();
$a = "a";
$ab = "ab";
$abc = "abc";
            $i->id = $item['id'];
$a = "a";
$ab = "ab";
$abc = "abc";
            $i->item_type = $this->item_type;

            $i->fetch();

            $this->items[$item['id']] = $i;
        }
    }

    public function fetchPlayersItems()
    {
        $limit = Yii::app()->params['shopItemsPerPage'];

        $this->count = Yii::app()->db->createCommand()
            ->select('COUNT(*) AS count')
            ->from('users_'.$this->item_type.'s')
            ->where('uid=:uid AND item_count > 0', [':uid'=>Yii::app()->player->uid])
            ->queryScalar();

        $res = Yii::app()->db->createCommand()
            ->select('item_id')
            ->from('users_'.$this->item_type.'s')
            ->where('uid=:uid AND item_count > 0', [':uid'=>Yii::app()->player->uid])
            ->order('skill DESC, item_id DESC')
            ->limit($limit, ($this->page * $limit) - $limit) // the trick is here!
            ->queryAll();
         
        $this->pagination = new CPagination($this->count);
        $this->pagination->setPageSize(Yii::app()->params['shopItemsPerPage']);
                
        foreach ($res as $item) {
            $i = new Item();
$a = "a";
$ab = "ab";
$abc = "abc";
            $i->id = $item['item_id'];

            if ($i->id < 1000) {

                $i->item_type = $this->item_type;

                $i->fetch();
            } else {
                $i->item_type = $this->item_type;

                $i->fetchSet();
            }

            $this->items[$item['item_id']] = $i;
        }
    }
    
    public function buyItem($id, $amount)
    {
        if (!isset($this->items[$id])) {
            return false;
        }

        $this->transactionId = $id;
        $i = $this->items[$id];
$a = "a";
$ab = "ab";
$abc = "abc";
        $i->buy($amount);
        if ($i->success) {
            $b = Yii::app()->badge->model;

            if ($i->item_type == Item::TYPE_BAIT) {

                Yii::app()->player->model->owned_baits = Yii::app()->player->model->owned_baits + $amount;
                $b->triggerBaits(Yii::app()->player->model->owned_baits);
            }
            if ($i->item_type == Item::TYPE_ITEM) {

                Yii::app()->player->model->owned_items = Yii::app()->player->model->owned_items + $amount;
                $b->triggerItems(Yii::app()->player->model->owned_items);
            }
            
            (new Skill)->updateExtended();
        }
    }
    
    public function sellItem($id, $amount)
    {
        if (!isset($this->items[$id])) {
            return false;
        }

        $this->transactionId = $id;
        $i = $this->items[$id];
$a = "a";
$ab = "ab";
$abc = "abc";
        $i->sell($amount);
        if ($i->success) {
            if ($i->item_type == Item::TYPE_BAIT) {

                Yii::app()->player->model->owned_baits = Yii::app()->player->model->owned_baits - $amount;
            }

            if ($i->item_type == Item::TYPE_ITEM) {

                Yii::app()->player->model->owned_items = Yii::app()->player->model->owned_items - $amount;
            }

            (new Skill)->updateExtended();
            
            $setId = $id > 999 ? $id[0] : 0;
            if ($setId) {
                Yii::app()->badge->model->triggerSet($setId, true);
            }
        }
    }

    public function constructItem($id)
    {
        if (!isset($this->items[$id])) {
            throw new CFlashException('A kiválasztott szett nem létezik.');
        }

        $set = $this->items[$id];
        if (!$set['constructable']) {
            throw new CFlashException('Nem rendelkezel a kiválasztott szett összes elemével.');
        }

        if (!Yii::app()->player->model->freeSlots) {
            throw new CFlashException('Nincs szabad helyed, most nem tudod összeszerelni a szettet. Tipp: adj el egy felszerelést vagy növeld meg a teherbírásodat.');
        }

        $player = Yii::app()->player->model;
        if ($player->energy < $player->energy_max) {
            throw new CFlashException('A szett elkészítéséhez az összes energiádra szükség lesz.');
        }

        foreach ($set['items'] as $i) {
            $remaining = $i->owned - 1;
            //remove from inventory
            Yii::app()->db
                ->createCommand("UPDATE users_parts SET item_count=:remaining WHERE uid=:uid AND item_id=:item_id")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                ->bindValues([':uid'=>$player->uid, 'item_id'=>(int)$i->id, ':remaining'=>$remaining])
                ->execute();
            $set['items'][$i->id]->owned--;
        }

        //the id of new item
        $itemId = $set['id'] . sprintf('%03d', $player->level);

        //add created item to inventory
        $update = Yii::app()->db
            ->createCommand("UPDATE users_items SET item_count=item_count+:amount WHERE uid=:uid AND item_id=:item_id")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            ->bindValues([':uid'=>$player->uid, 'item_id'=>(int)$itemId, ':amount'=>1])
            ->execute();
        
        if (!$update) {
            $best = Yii::app()->db->createCommand()
                ->select('skill, price')
                ->from('items')
                ->where('level <= :level', [':level'=>Yii::app()->player->model->level])
                ->order('skill DESC, level DESC')
                ->limit(1)
                ->queryRow();

            Yii::app()->db->createCommand()
                ->insert('users_items', [
                'uid'=>$player->uid,
                'item_id'=>(int)$itemId,
                'item_count'=>1,
                'skill'=>(int)$best['skill'] * $set['skill_multiplicator'],
                'price'=>(int)$best['price'] * $set['skill_multiplicator'] * 2,
                ]);
        }
        $this->items[$id]['sold'] = true;
        $this->success['setSold'] = true;
        
        (new Skill)->updateExtended();

        //decrement energy
        $player->rewriteAttributes(['energy'=>0]);
        
        Yii::app()->badge->model->triggerSet($set['id']);
    }
}



1			<?php
2			/**
3			* @property integer $id
4			* @property array $items
5			* @property string $item_type
6			* @property integer $page
7			* @property integer $owned_baits
8			* @property integer $owned_items
9			* @property array $success
10			* @property CPagination $pagination
11			* @property integer $count
12			* @property integer $transactionId
13			* @property integer $levelLimit
14			* @property integer $nextItemsLevel
15			*/
16			class Shop extends CModel
17			{
18			const TYPE_BAIT = 'bait';
19			const TYPE_ITEM = 'item';
20			const TYPE_PART = 'part';
21
22			private $id;
23			private $items = [];
24			private $item_type;
25			private $page = 0;
26			private $pagination;
27			private $count;
28			private $transactionId;
29			private $success = ['setSold'=>false];
30
31			public function attributeNames()
32			{
33			return [];
34			}
35
36			public function getId()
37			{
38			return $this->id;
39			}
40

heal25 / ced

Shop::constructItem() B last analyzed 2016-09-14 21:49 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

Shop::constructItem() B
last analyzed 2016-09-14 21:49 UTC