LeaderboardController::makeBoard() - Code Metrics - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

LeaderboardController::makeBoard() B
last analyzed 2016-09-14 21:49 UTC

↳ Parent: LeaderboardController

Complexity

Conditions	3
Paths	3

Size

Total Lines	24
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	24
rs	8.9713
c	0
b	0
f	0
cc	3
eloc	18
nc	3
nop	2

<?php
class LeaderboardController extends GameController
{
    public function actionIndex($range = '')
    {
        $this->makeBoard(Leaderboard::TYPE_PLAYER, $range);
    }

    public function actionClub($range = '')
    {
        $this->makeBoard(Leaderboard::TYPE_CLUB, $range);
    }

    /**
     * @param string $range
     */
    private function makeBoard($type, $range)
    {
        $board = new Leaderboard;
$a = "a";
$ab = "ab";
$abc = "abc";
        $board->uid = Yii::app()->player->model->uid;
$a = "a";
$ab = "ab";
$abc = "abc";
        $board->inClub = Yii::app()->player->model->in_club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $board->boardType = $type;


        switch ($range) {
            case 'prev':
                $board->setRange(Leaderboard::RANGE_PREVIOUS);
                break;
            case 'last':
                $board->setRange(Leaderboard::RANGE_LAST_SIX);
                break;
            default:
                $board->setRange(Leaderboard::RANGE_ACTUAL);
                break;
        }
        $board->fetchList();

        $this->render('index', [
            'board'=>$board,
            ]);
    }
}



1			<?php
2			class LeaderboardController extends GameController
3			{
4			public function actionIndex($range = '')
5			{
6			$this->makeBoard(Leaderboard::TYPE_PLAYER, $range);
7			}
8
9			public function actionClub($range = '')
10			{
11			$this->makeBoard(Leaderboard::TYPE_CLUB, $range);
12			}
13
14			/**
15			* @param string $range
16			*/
17			private function makeBoard($type, $range)
18			{
19			$board = new Leaderboard;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 12 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
20			$board->uid = Yii::app()->player->model->uid;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `uid` cannot be accessed from this context as it is declared `private` in class `Leaderboard`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
21			$board->inClub = Yii::app()->player->model->in_club;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `inClub` cannot be accessed from this context as it is declared `private` in class `Leaderboard`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22			$board->boardType = $type;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `boardType` cannot be accessed from this context as it is declared `private` in class `Leaderboard`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
23
24			switch ($range) {
25			case 'prev':
26			$board->setRange(Leaderboard::RANGE_PREVIOUS);
27			break;
28			case 'last':
29			$board->setRange(Leaderboard::RANGE_LAST_SIX);
30			break;
31			default:
32			$board->setRange(Leaderboard::RANGE_ACTUAL);
33			break;
34			}
35			$board->fetchList();
36
37			$this->render('index', [
38			'board'=>$board,
39			]);
40			}
41			}
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
42

heal25 / ced

LeaderboardController::makeBoard() B last analyzed 2016-09-14 21:49 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

LeaderboardController::makeBoard() B
last analyzed 2016-09-14 21:49 UTC