Duel::validateDuel() - Code Metrics - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

Duel::validateDuel() B
last analyzed 2016-09-14 21:49 UTC

↳ Parent: Duel

Complexity

Conditions	6
Paths	6

Size

Total Lines	27
Code Lines	14

Duplication

Lines	3
Ratio	11.11 %

Importance

Changes

Metric	Value
dl	3
loc	27
rs	8.439
c	0
b	0
f	0
cc	6
eloc	14
nc	6
nop	0

<?php
/**
 * @property integer $caller
 * @property integer $opponent
 * @property boolean $isChallenge
 * @property boolean $played
 * @property array $competitors
 */
class Duel extends CModel
{
    private $caller;
    private $opponent;
    private $competitors = [];
$a = "a";
$ab = "ab";
$abc = "abc";
    private $callerDuelShieldLifeTime = false;

    private $challengeID = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
    private $callersClub = '';
$a = "a";
$ab = "ab";
$abc = "abc";
    private $callersClubRole = '';
$a = "a";
$ab = "ab";
$abc = "abc";
    private $opponentsClub = '';
$a = "a";
$ab = "ab";
$abc = "abc";
    private $opponentsClubRole = '';

    public function attributeNames()
    {
        return [];
    }

    public function getOpponent()
    {
        return $this->opponent;
    }

    public function getCaller()

    {
        return $this->caller;
    }

    public function getIsChallenge()
    {
        return $this->challengeID > 0;
    }

    public function getPlayed()

    {
        if (!isset($this->competitors[1])) {
            return false;
        }

        return ($this->competitors[0]->winner | $this->competitors[1]->winner);
    }

    public function getCompetitors()
    {
        return $this->competitors;
    }

    public function setCaller($id)
    {
        $this->caller = $this->getPlayerModel($id);
$a = "a";
$ab = "ab";
$abc = "abc";
        $duelShiel = new DuelShield();
$a = "a";
$ab = "ab";
$abc = "abc";
        $duelShiel->uid = $id;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->callerDuelShieldLifeTime = $duelShiel->lifeTime;
    }

    public function setOpponent($id)
    {
        $this->opponent = $this->getPlayerModel($id);
        $duelShiel = new DuelShield();
$a = "a";
$ab = "ab";
$abc = "abc";
        $duelShiel->uid = $id;

        if ($duelShiel->lifeTime > 0) {
            $this->opponent->activateDuelShield();
        }
    }

    private function getPlayerModel($id)

    {
        if ($id == Yii::app()->player->uid) {
            return Yii::app()->player->model;
        }

        $player = new Player();
        if ($id) {
            $player->setAllAttributes($id);
        }

        return $player;
    }

    public function fetchClubChallengeState()
    {
        $c = $this->caller->in_club;
        $o = $this->opponent->in_club;

        if (!$c || !$o) {
            return false;
        }

        $last = Yii::app()->db->createCommand()
            ->select('*')
            ->from('challenge')
            ->where('(caller=:caller OR caller=:opponent) AND winner=0', [':caller'=>$c, ':opponent'=>$o])
            ->limit(1)
            ->queryRow();

        if ($last['caller']==$c && $last['opponent']==$o || $last['caller']==$o && $last['opponent']==$c) {
            $this->setClubAttributes($last);
        }
    }

    private function setClubAttributes($challenge)
    {
        $created = strtotime($challenge['created']);

        if ($this->isBetweenDates($created + 1800, $created + 3600)) {
            $this->challengeID = (int)$challenge['id'];

            $this->callersClubRole = $challenge['caller'] == $this->caller->in_club ? 'caller' : 'opponent';
            $this->callersClub = $challenge['caller'] == $this->caller->in_club ? $challenge['name_caller'] : $challenge['name_opponent'];
$a = "a";
$ab = "ab";
$abc = "abc";

            $this->opponentsClubRole = $challenge['opponent'] == $this->opponent->in_club ? 'opponent' : 'caller';
            $this->opponentsClub = $challenge['opponent'] == $this->opponent->in_club ? $challenge['name_opponent'] : $challenge['name_caller'];
$a = "a";
$ab = "ab";
$abc = "abc";
        }
    }

    /**
     * @param integer $start
     * @param integer $end
     */
    private function isBetweenDates($start, $end)
    {
        $now = time();
        return ($now >= $start && $now <= $end);
    }

    public function validateDuel()
    {
        if (!$this->opponent->uid) {
            throw new CFlashException('Az ellenfél nem létezik.');
        }

        if ($this->opponent->uid == $this->caller->uid) {
            throw new CFlashException('Magad ellen nem párbajozhatsz.');
        }

        if ($this->callerDuelShieldLifeTime > 0) {
            throw new CFlashException('Be van kapcsolva a párbaj-pajzsod, így nem hívhatsz párbajra másokat.');
        }

        Yii::trace('check: caller - energyRequiredForDuel');
        if ($this->caller->energy < $this->caller->energyRequiredForDuel) {
            throw new CFlashException('Ahhoz, hogy párbajozhass, legalább ' . $this->caller->energyRequiredForDuel . ' energiára van szükséged.');
        }

        if ($this->opponent->level < Yii::app()->params['duelLevelRequirement']) {

            throw new CFlashException('Az ellenfél még nem párbajozhat, mivel nem érte el a szükséges ' . Yii::app()->params['duelLevelRequirement'] . '. szintet.');
        }

        $this->validateNonChallengeGame();

        return true;
    }

    private function validateNonChallengeGame()
    {
        if ($this->isChallenge) {
            return true;
        }

        if ($this->opponent->level < Yii::app()->player->model->level - Yii::app()->params['duelWeakerOpponentLevelDiff']) {
            if (!$this->isRevenge()) {
                throw new CFlashException('Az ellenfél gyengébb nálad a megengedettnél (' . Yii::app()->params['duelWeakerOpponentLevelDiff'] . ' szint).');
            }
        }

        Yii::trace('check: opponent - energyRequiredForDuel');
        if ($this->opponent->energy < $this->opponent->energyRequiredForDuel) {
            throw new CFlashException('Az ellenfélnek nincs elég energiája a párbajhoz.');
        }

        if ($this->duelsInLastHour() >= Yii::app()->params['duelMaxCallPerHour']) {
            throw new CFlashException('Ugyanazt a játékost max. ' . Yii::app()->params['duelMaxCallPerHour'] . 'x hívhatod párbajra egy órán keresztül. Kérlek válassz másik ellenfelet.');
        }

        return true;
    }

    private function createCompetitors()
    {
        if ($this->isChallenge) {

            $c = new ClubCompetitor();
            $o = new ClubCompetitor();
        } else {
            $c = new Competitor();
            $o = new Competitor();
        }

        $c->uid = $this->caller->uid;
        $o->uid = $this->opponent->uid;

        $c->skill = $this->caller->skill_extended;
        $o->skill = $this->opponent->skill_extended;

        $sumSkill = $c->skill + $o->skill;
$a = "a";
$ab = "ab";
$abc = "abc";
        $c->chance = round($c->skill / ($sumSkill / 100));
        $c->chance = min($c->chance, 99); //max 99
        $o->chance = 100 - $c->chance;

        $c->energy = $this->caller->energyRequiredForDuel;
        $o->energy = min($this->opponent->energyRequiredForDuel, $this->opponent->energy);

        $avgEnergy = round(($c->energy + $o->energy) / 2);
$a = "a";
$ab = "ab";
$abc = "abc";
        $c->avgEnergy = $avgEnergy;
        $o->avgEnergy = $avgEnergy;

        $c->dollar = round($this->caller->dollar / 10);
        $o->dollar = round($this->opponent->dollar / 10);

        $c->club = $this->callersClub;
        $o->club = $this->opponentsClub;

        $c->opponent = [
            'chance'=>$o->chance,
            'dollar'=>$o->dollar,
            'energy'=>$o->energy,
            ];
        $o->opponent = [
            'chance'=>$c->chance,
            'dollar'=>$c->dollar,
            'energy'=>$c->energy,
            'uid'=>$c->uid, //only for wall messages
            'user'=>$this->caller->user //only for wall messages
            ];

        $c->isCaller = true;

        $this->competitors[] = $c;
        $this->competitors[] = $o;
    }

    public function play()
    {
        $this->createCompetitors();

        //play
        $rnd = rand(1, 100);
$a = "a";
$ab = "ab";
$abc = "abc";
        $winnersId = 1; //opponent
        if ($rnd <= $this->competitors[0]->chance) {
            $winnersId = 0; //caller
        }

        $this->competitors[0]->play(0==$winnersId);
        $this->competitors[1]->play(1==$winnersId);

        $this->log();
        $this->competitors[0]->finish($this->caller);
        $this->competitors[1]->finish($this->opponent);

        if ($this->isChallenge) {
            $this->updateWinnerClub();
        }
    }

    /**
     * @param integer $duelId
     */
    public function replay($duelId)
    {
        //fetch duel data
        $duel = Yii::app()->db->createCommand()
            ->select('*')
            ->from('duel')
            ->where('id = :id', [':id'=>$duelId])
            ->queryRow();
        if (!$duel['id']) {
            throw new CFlashException('A lekért párbaj nem található.');
        }

        if (Yii::app()->player->uid != $duel['caller'] && Yii::app()->player->uid != $duel['opponent']) {
            throw new CFlashException('A lekért párbajt mások játszották.');
        }

        $this->challengeID = (int)$duel['challenge_id'];

        $this->setCaller($duel['caller']);
        $this->setOpponent($duel['opponent']);

        if ($this->isChallenge) {

            $c = new ClubCompetitor();
            $o = new ClubCompetitor();
        } else {
            $c = new Competitor();
            $o = new Competitor();
        }

        $c->uid = $duel['caller'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $c->isCaller = true;
        $c->fetchFromLog($duelId);
        $this->competitors[] = $c;

        $o->uid = $duel['opponent'];
        $o->fetchFromLog($duelId);
        $this->competitors[] = $o;
    }

    private function log()
    {
        //insert the duel data
        Yii::app()->db->createCommand()
            ->insert(
                'duel',
                [
                'winner'=>$this->competitors[0]->winner ? 'caller' : 'opponent',
                'caller'=>$this->caller->uid,
                'opponent'=>$this->opponent->uid,
                'challenge_id'=>$this->challengeID
                ]
            );

        $duelId = Yii::app()->db->getLastInsertID();
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->competitors[0]->duelId = $duelId;
        $this->competitors[1]->duelId = $duelId;
    }

    private function updateWinnerClub()
    {
        $tag = $this->callersClubRole;
$a = "a";
$ab = "ab";
$abc = "abc";
        $winner = $this->competitors[0];
        if ($this->competitors[1]->winner) {
            $tag = $this->opponentsClubRole;
$a = "a";
$ab = "ab";
$abc = "abc";
            $winner = $this->competitors[1];
        }

        Yii::app()->db->createCommand("UPDATE challenge SET cnt_won_{$tag}=cnt_won_{$tag}+1, loot_{$tag}=loot_{$tag}+{$winner->lootDollar}, point_{$tag}=point_{$tag}+{$winner->awardPoints} WHERE id={$this->challengeID}")->execute();
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

    }

    private function isRevenge()
    {
        //todo: query last duel, check it's time with php

        $res = Yii::app()->db->createCommand()
            ->select('COUNT(*)')
            ->from('duel')
            ->where(
                'caller=:caller AND opponent=:opponent AND created > DATE_SUB(NOW(), INTERVAL :h hour)',
                [':caller'=>$this->opponent->uid, ':opponent'=>$this->caller->uid, ':h' => Yii::app()->params['duelRevengeTimeLimitHours']]
            )
            ->queryScalar();
        return (boolean)($res > 0);
    }

    private function duelsInLastHour()
    {
        $res = Yii::app()->db->createCommand()
            ->select('COUNT(*)')
            ->from('duel')
            ->where(
                'caller=:caller AND opponent=:opponent AND created > DATE_SUB(NOW(), INTERVAL 1 hour)',
                [':caller'=>$this->caller->uid, ':opponent'=>$this->opponent->uid]
            )
            ->queryScalar();
        return (int)$res;
    }
}



1			<?php
2			/**
3			* @property integer $caller
4			* @property integer $opponent
5			* @property boolean $isChallenge
6			* @property boolean $played
7			* @property array $competitors
8			*/
9			class Duel extends CModel
10			{
11			private $caller;
12			private $opponent;
13			private $competitors = [];
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
14			private $callerDuelShieldLifeTime = false;
15
16			private $challengeID = 0;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
17			private $callersClub = '';
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
18			private $callersClubRole = '';
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
19			private $opponentsClub = '';
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
20			private $opponentsClubRole = '';
21
22			public function attributeNames()
23			{
24			return [];
25			}
26
27			public function getOpponent()
28			{
29			return $this->opponent;
30			}
31
32			public function getCaller()
			0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
33			{
34			return $this->caller;

heal25 / ced

Duel::validateDuel() B last analyzed 2016-09-14 21:49 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Duel::validateDuel() B
last analyzed 2016-09-14 21:49 UTC