ClubController::actionDetails() - Code Metrics - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

ClubController::actionDetails() C
last analyzed 2016-09-14 21:49 UTC

↳ Parent: ClubController

Complexity

Conditions	8
Paths	98

Size

Total Lines	80
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	80
rs	6.0132
c	0
b	0
f	0
cc	8
eloc	56
nc	98
nop	1

How to fix Long Method

<?php
class ClubController extends GameController
{
    private $moderation = [
        'fired'=>0,
        'approved'=>0,
        'deleted'=>0
        ];

    public function actionIndex()
    {
        $controller = Yii::app()->player->model->in_club ? 'own' : 'list';
        $this->redirect('/club/' . $controller);
    }

    public function actionList($page = 0)
    {
        $this->renderList($page, false);
    }

    public function actionListCompete($page = 0)
    {
        $this->renderList($page, true);
    }

    /**
     * @param integer $page
     * @param boolean $compete
     */
    protected function renderList($page, $compete)
    {
        $model=new Club;
$a = "a";
$ab = "ab";
$abc = "abc";

        $model->page = $page;

        $model->fetchItems($compete);

        $template = $compete ? 'listcompete' : 'list';
        $this->render($template, [
            'list'=>$model->items,

            'pagination' => $model->pagination,

            'count' => $model->count,

            'page_size' => Yii::app()->params['listPerPage'],
            'page'=>$page,
            ]);
    }

    public function actionCreate()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $model=new ClubAR;
$a = "a";
$ab = "ab";
$abc = "abc";

        if (isset($_POST['ClubAR'])) {
            $model->attributes=$_POST['ClubAR'];
$a = "a";
$ab = "ab";
$abc = "abc";
            if ($model->validate()) {
                if ($model->save()) {
                    $this->redirect(['/club/own']);
                }
            }
        }

        $this->render('create', [
            'model'=>$model,
            ]);
    }

    public function actionDetails($id)
    {
        $player = Yii::app()->player->model;

        $clubID = (int)$id;
$a = "a";
$ab = "ab";
$abc = "abc";
        $in_club = (int)Yii::app()->player->model->in_club;
        if ($in_club == $id) {
            $this->redirect('/club/own');
        }
        //members
        $club = new Club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $club->id = $clubID;

        $club->fetch();

        if (!$club->id) {

            throw new CHttpException(404, 'A keresett klub nem található.');
        }
        $club->fetchMembers();

        $r = Yii::app()->request;
$a = "a";
$ab = "ab";
$abc = "abc";
        $join = $r->getParam('join', 0);
        if ($join) {
            try {
                $club->joinRequest($club->id);

                Yii::app()->user->setFlash('success', 'A csatlakozási kérelmet elküldted. Amint elfogadja valamelyik klubtag, értesítünk.');
            } catch (CFlashException $e) {
                Yii::app()->user->setFlash('error', $e->getMessage());
            }
        }
        $delete = $r->getParam('deleteJoin', 0);
        if ($delete) {
            $club->deleteOwnJoinRequest($club->id);

            Yii::app()->user->setFlash('success', 'A csatlakozási kérelmet visszavontad.');
        }

        $forum = new Forum;

        //challenge
        $ch = new Challenge;
$a = "a";
$ab = "ab";
$abc = "abc";
        $ch->caller = $in_club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $ch->opponent = $clubID;

        $ch->fetchActiveChallenge();

        $call = $r->getParam('call', 0);
        if ($call) {
            try {
                $ch->caller = $in_club;
$a = "a";
$ab = "ab";
$abc = "abc";
                $ch->opponent = $clubID;


                $ch->callToChallenge($club);
                Yii::app()->user->setFlash('success', 'Versenyre hívtad a klubot!');

                $forum->id = $clubID;

                $message = $player->user . ' a saját klubja nevében versenyre hívta a klubot.';
$a = "a";
$ab = "ab";
$abc = "abc";
                $forum->save($message, true);

                $forum->id = $player->in_club;

                $message = $player->user . ' versenyre hívta a következő klubot: ' . $club->name;
$a = "a";
$ab = "ab";
$abc = "abc";
                $forum->save($message, true);
            } catch (CFlashException $e) {
                Yii::app()->user->setFlash('error', $e->getMessage());
            }
        }


        $forum->id = $clubID;

        $forum->fetchItems();

        $this->render('details', [
            'clubID'=>$clubID,
            'club'=>$club,
            'challenge'=>$ch,
            'list'=>$forum->items,

            'pagination' => $forum->pagination,

            'count' => $forum->count,

            'page_size' => Yii::app()->params['listPerPage'],
            'page'=>0,
            'moderation'=>$this->moderation,
            ]);
    }
    public function actionOwn($page = 0)
    {
        $player = Yii::app()->player->model;
        if (!$player->in_club) {
            $this->redirect(['/club/list']);
        }

        //forum
        $forum = new Forum;
$a = "a";
$ab = "ab";
$abc = "abc";
        $forum->id = $player->in_club;

        $forum->fetchItems();

        //members
        $club = new Club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $club->id = $player->in_club;

        $club->fetch();
        $club->fetchMembers();

        //challenge
        $ch = new Challenge;
$a = "a";
$ab = "ab";
$abc = "abc";
        $ch->opponent = $club->id;

        $ch->fetchActiveChallenge();

        try {
            $this->fireMember($club, $ch, $forum);
            $this->acceptApproval($club, $forum);
            $this->deleteApproval($club, $forum);
            $this->switchCompete($club, $ch);

        } catch (CFlashException $e) {
            Yii::app()->user->setFlash('error', $e->getMessage());
        }

        $this->render('own', [
            'clubID'=>$player->in_club,
            'club'=>$club,
            'challenge'=>$ch,
            'list'=>$forum->items,

            'pagination' => $forum->pagination,

            'count' => $forum->count,

            'page_size' => Yii::app()->params['listPerPage'],
            'page'=>$page,
            'moderation'=>$this->moderation,
            ]);
    }

    /**
     * @param Club $club
     * @param Challenge $challenge
     * @param Forum $forum
     */
    private function fireMember($club, $challenge, $forum)
    {
        $player = Yii::app()->player->model;

        $fire = (int)Yii::app()->request->getParam('fire', false);
        if ($fire) {
            if ($challenge->active) {

                throw new CFlashException('Verseny közben nem lehet tagot kidobni.');
            }

            $fireUser = isset($club->members[$fire]['user']) ? $club->members[$fire]['user'] : '???';

            if ($club->fireMember($fire)) {
                $this->moderation['fired'] = $fire;
                //forum notice
                $message = $fire==$player->uid ? $player->user . ' kilépett a klubból.' : $player->user . ' visszavonta ' . $fireUser . ' tagságát.';
                $forum->save($message, true);
                //wall notice
                $this->wallNotice($club, Wall::TYPE_CLUB_FIRE, $fire);
            }
        }
    }

    /**
     * @param Club $club
     * @param Forum $forum
     */
    private function acceptApproval($club, $forum)
    {
        $player = Yii::app()->player->model;

        $approve = (int)Yii::app()->request->getParam('approve', false);
        if ($approve) {
            if ($club->approveMember($approve)) {
                $this->moderation['approved'] = $approve;
                //forum notice
                $message = $player->user . ' elfogadta ' . $club->members[$approve]['user'] . ' felvételi kérelmét.';

                $forum->save($message, true);
                //wall notice
                $this->wallNotice($club, Wall::TYPE_CLUB_APPROVE, $club->members[$approve]['uid']);

            }
        }
    }

    /**
     * @param Club $club
     * @param Forum $forum
     */
    private function deleteApproval($club, $forum)
    {
        $player = Yii::app()->player->model;

        $delete = (int)Yii::app()->request->getParam('delete', false);
        if ($delete) {
            $deleteUser = isset($club->entrants[$delete]['user']) ? $club->entrants[$delete]['user'] : '???';

            if ($club->deleteJoinRequest($delete)) {
                $this->moderation['deleted'] = $delete;
                //forum notice
                $message = $player->user . ' elutasította ' . $deleteUser . ' felvételi kérelmét.';
                $forum->save($message, true);
                //wall notice
                $this->wallNotice($club, Wall::TYPE_CLUB_DELETE, $delete);
            }
        }
    }

    /**
     * @param Club $club
     * @param Challenge $challenge
     */
    private function switchCompete($club, $challenge)
    {
        $switch = Yii::app()->request->getParam('switch', '');
        if ($switch == 'compete') {
            if ($club->would_compete & $challenge->underLastCallTimeLimit($club->id)) {

                throw new CFlashException('A \'versenyezne\' beállítást csak akkor kapcsolhatod ki, ha legalább '. Challenge::TIME_LIMIT_LASTCALL_HOURS .' óra eltelt azóta, hogy a klubod valakit versenyre hívott.');
            }

            $club->switchCompete();
        }
    }

    /**
     * @param Club $club
     */
    private function wallNotice($club, $type, $uid)
    {
        $player = Yii::app()->player->model;

        //wall notice
        $wall = new Wall;
$a = "a";
$ab = "ab";
$abc = "abc";
        $wall->content_type = $type;

        $wall->uid = $uid;
$a = "a";
$ab = "ab";
$abc = "abc";
        $wall->add([
            'clubID'=>$player->in_club,
            'clubName'=>$club->name,

            'moderatorUid'=>$player->uid,
            'moderator'=>$player->user,
            ]);
    }

    public function actionForum($id, $page = 0)
    {
        $clubID = (int)$id;

        $forum = new Forum;
$a = "a";
$ab = "ab";
$abc = "abc";
        $forum->id = $clubID;


        $r = Yii::app()->request;
$a = "a";
$ab = "ab";
$abc = "abc";
        $post = $r->getPost('post', false);
        if ($post) {
            $forum->private = $r->getPost('private', false);

            $forum->save($post);
        }
        $delete = $r->getParam('delete', 0);
        if ($delete) {
            $forum->delete($delete);
        }

        $forum->page = $page;

        $forum->fetchItems();

        $this->render('forum', [
            'clubID'=>$clubID,
            'list'=>$forum->items,

            'pagination' => $forum->pagination,

            'count' => $forum->count,

            'page_size' => Yii::app()->params['listPerPage'],
            'page'=>$page,
            ]);
    }

    public function actionHistory($id = 0)
    {
        if (!$id) {
            $this->redirect(['/club/list']);
        }

        $club = new Club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $club->id = (int)$id;

        $club->fetch();
        $club->fetchChallenges();

        $this->render('history', [
            'club'=>$club,
            ]);
    }

    public function actionClose()
    {
        $player = Yii::app()->player->model;
        if (!$player->in_club) {
            $this->redirect(['/club/list']);
        }

        //members
        $club = new Club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $club->id = $player->in_club;

        $club->fetch();
        $club->fetchMembers();

        $pass = Yii::app()->request->getPost('pass', '');
        if ($pass) {
            try {
                if ($club->close($pass)) {
                    foreach ($club->members as $member) {

                        $this->wallNotice($club, Wall::TYPE_CLUB_CLOSE, $member['uid']);
                    }
                    Yii::app()->user->setFlash('success', "A klubot megszüntetted.");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $this->redirect(['/club/list']);
                }
            } catch (CFlashException $e) {
                Yii::app()->user->setFlash('error', $e->getMessage());
            }
        }

        $this->render('close', [
            'club'=>$club,
            ]);
    }
}



1			<?php
2			class ClubController extends GameController
3			{
4			private $moderation = [
5			'fired'=>0,
6			'approved'=>0,
7			'deleted'=>0
8			];
9
10			public function actionIndex()
11			{
12			$controller = Yii::app()->player->model->in_club ? 'own' : 'list';
13			$this->redirect('/club/' . $controller);
14			}
15
16			public function actionList($page = 0)
17			{
18			$this->renderList($page, false);
19			}
20
21			public function actionListCompete($page = 0)
22			{
23			$this->renderList($page, true);
24			}
25
26			/**
27			* @param integer $page
28			* @param boolean $compete
29			*/
30			protected function renderList($page, $compete)
31			{
32			$model=new Club;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
33
34			$model->page = $page;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `page` cannot be accessed from this context as it is declared `private` in class `Club`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
35			$model->fetchItems($compete);
36
37			$template = $compete ? 'listcompete' : 'list';
38			$this->render($template, [

heal25 / ced

ClubController::actionDetails() C last analyzed 2016-09-14 21:49 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

ClubController::actionDetails() C
last analyzed 2016-09-14 21:49 UTC