BadgeList::getPercentOwned() - Code Metrics - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

BadgeList::getPercentOwned() A
last analyzed 2016-09-14 21:49 UTC

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php
/**
 * @property array $ownedKeys
 * @property array $owned
 * @property array $all
 * @property integer $percentOwned
 */
class BadgeList extends Badge
{
    private $ownedKeys = [];
$a = "a";
$ab = "ab";
$abc = "abc";
    private $owned = [];
$a = "a";
$ab = "ab";
$abc = "abc";
    private $all = [];
$a = "a";
$ab = "ab";
$abc = "abc";
    private $categoryFirst = [
        'max_nrg_100'=>'s',
        'setpart_30'=>'g'
        ];

    public function getOwnedKeys()
    {
        return $this->ownedKeys;
    }

    public function getOwned()
    {
        return $this->owned;
    }

    public function getAll()
    {
        return $this->all;
    }

    public function getPercentOwned()
    {
        $redis = Yii::app()->redis->getClient();
$a = "a";
$ab = "ab";
$abc = "abc";
        $cntOwned = $redis->sCard("badges:owned:{$this->uid}");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        $cntAll = $redis->zCard("badges:all");
$a = "a";
$ab = "ab";
$abc = "abc";
        return round(($cntOwned / $cntAll) * 100);
    }

    public function fetchOwned()
    {
        if (!$this->uid) {
            $this->setUid(Yii::app()->player->model->uid); //set default uid
        }

        $redis = Yii::app()->redis->getClient();
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->ownedKeys = $redis->zRevRange("badges:added:{$this->uid}", 0, -1);
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        foreach ($this->ownedKeys as $item) {
            $b = $this->getBadge($item);
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->owned[$item] = $b;
        }
    }
    
    public function fetchAll()
    {
        if (!$this->uid) {
            $this->setUid(Yii::app()->player->model->uid); //set default uid
        }

        $redis = Yii::app()->redis->getClient();
        $all = $redis->zRange('badges:all', 0, -1);
$a = "a";
$ab = "ab";
$abc = "abc";

        $categ = 'b';
        foreach ($all as $item) {
            if (array_key_exists($item, $this->categoryFirst)) {
                $categ = $this->categoryFirst[$item];
            }

            if (array_key_exists($item, $this->owned)) {
                $b = $this->owned[$item];
$a = "a";
$ab = "ab";
$abc = "abc";
                $b['owned'] = 1;
            } else {
                $b = $this->getBadge($item);
$a = "a";
$ab = "ab";
$abc = "abc";
                $b['owned'] = 0;
            }
            $this->all[$categ][$item] = $b;
        }
    }
}



1			<?php
2			/**
3			* @property array $ownedKeys
4			* @property array $owned
5			* @property array $all
6			* @property integer $percentOwned
7			*/
8			class BadgeList extends Badge
9			{
10			private $ownedKeys = [];
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
11			private $owned = [];
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
12			private $all = [];
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
13			private $categoryFirst = [
14			'max_nrg_100'=>'s',
15			'setpart_30'=>'g'
16			];
17
18			public function getOwnedKeys()
19			{
20			return $this->ownedKeys;
21			}
22
23			public function getOwned()
24			{
25			return $this->owned;
26			}
27
28			public function getAll()
29			{
30			return $this->all;
31			}
32
33			public function getPercentOwned()
34			{
35			$redis = Yii::app()->redis->getClient();
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
36			$cntOwned = $redis->sCard("badges:owned:{$this->uid}");
			0 ignored issues – show Coding Style Best Practice introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$this` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
37			$cntAll = $redis->zCard("badges:all");
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The string literal `badges:all` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
38			return round(($cntOwned / $cntAll) * 100);
39			}
40
41			public function fetchOwned()
42			{
43			if (!$this->uid) {
44			$this->setUid(Yii::app()->player->model->uid); //set default uid
45			}
46
47			$redis = Yii::app()->redis->getClient();
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
48			$this->ownedKeys = $redis->zRevRange("badges:added:{$this->uid}", 0, -1);
			0 ignored issues – show Coding Style Best Practice introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$this` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
49
50			foreach ($this->ownedKeys as $item) {
51			$b = $this->getBadge($item);
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 18 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
52			$this->owned[$item] = $b;
53			}
54			}
55
56			public function fetchAll()
57			{
58			if (!$this->uid) {
59			$this->setUid(Yii::app()->player->model->uid); //set default uid
60			}
61
62			$redis = Yii::app()->redis->getClient();
63			$all = $redis->zRange('badges:all', 0, -1);
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
64
65			$categ = 'b';
66			foreach ($all as $item) {
67			if (array_key_exists($item, $this->categoryFirst)) {
68			$categ = $this->categoryFirst[$item];
69			}
70
71			if (array_key_exists($item, $this->owned)) {
72			$b = $this->owned[$item];
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
73			$b['owned'] = 1;
74			} else {
75			$b = $this->getBadge($item);
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
76			$b['owned'] = 0;
77			}
78			$this->all[$categ][$item] = $b;
79			}
80			}
81			}
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
82

heal25 / ced

BadgeList::getPercentOwned() A last analyzed 2016-09-14 21:49 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

BadgeList::getPercentOwned() A
last analyzed 2016-09-14 21:49 UTC