BadgeActivator::activate() - Code Metrics - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

BadgeActivator::activate() B
last analyzed 2016-09-14 21:49 UTC

↳ Parent: BadgeActivator

Complexity

Conditions	4
Paths	5

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	26
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	14
nc	5
nop	1

<?php
class BadgeActivator extends Badge
{
    protected function activate($id)

    {
        $redis = Yii::app()->redis->getClient();
        $saved = $redis->sadd('badges:owned:'.$this->uid, $id);
        if ($saved) {
            //save the actual timestamp
            $redis->zadd('badges:added:'.$this->uid, time(), $id);

            $badge = $this->getBadge($id);

            $score = 1;

            if ($badge['level'] == self::LEVEL_SILVER) {
                $score = 3;
            }

            if ($badge['level'] == self::LEVEL_GOLD) {
                $score = 9;
            }

            $redis->zIncrBy("badges:leaderboard", $score, $this->uid);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

            $this->postToWall($badge);
        }
        return $saved;
    }

    private function postToWall($badge)
    {
        $wall = new Wall;
$a = "a";
$ab = "ab";
$abc = "abc";
        $wall->content_type = Wall::TYPE_BADGE;

        $wall->uid = $this->uid;
$a = "a";
$ab = "ab";
$abc = "abc";
        $wall->add($badge);
    }
}



1			<?php
2			class BadgeActivator extends Badge
3			{
4			protected function activate($id)
			0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
5			{
6			$redis = Yii::app()->redis->getClient();
7			$saved = $redis->sadd('badges:owned:'.$this->uid, $id);
8			if ($saved) {
9			//save the actual timestamp
10			$redis->zadd('badges:added:'.$this->uid, time(), $id);
11
12			$badge = $this->getBadge($id);
13
14			$score = 1;
15
16			if ($badge['level'] == self::LEVEL_SILVER) {
17			$score = 3;
18			}
19
20			if ($badge['level'] == self::LEVEL_GOLD) {
21			$score = 9;
22			}
23
24			$redis->zIncrBy("badges:leaderboard", $score, $this->uid);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The string literal `badges:leaderboard` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
25
26			$this->postToWall($badge);
27			}
28			return $saved;
29			}
30
31			private function postToWall($badge)
32			{
33			$wall = new Wall;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
34			$wall->content_type = Wall::TYPE_BADGE;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `content_type` cannot be accessed from this context as it is declared `private` in class `Wall`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
35			$wall->uid = $this->uid;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `uid` cannot be accessed from this context as it is declared `private` in class `Wall`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
36			$wall->add($badge);
37			}
38			}
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
39

heal25 / ced

BadgeActivator::activate() B last analyzed 2016-09-14 21:49 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

BadgeActivator::activate() B
last analyzed 2016-09-14 21:49 UTC