AjaxController::actionTest() - Code Metrics - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

AjaxController::actionTest() A
last analyzed 2016-09-14 21:49 UTC

↳ Parent: AjaxController

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	1

<?php
class AjaxController extends Controller
{
    public function actionTest($id = 0)
    {
        $ch = new Challenge;
$a = "a";
$ab = "ab";
$abc = "abc";
        $ch->id = $id;

        $ch->fetch();

        $res = "<p class='ui-li-desc'>{$ch->point_caller} pont</p><p class='ui-li-desc'>{$ch->cnt_won_caller}x győzött</p><p class='ui-li-desc'>{$ch->loot_caller}$ zsákmány</p>";
$a = "a";
$ab = "ab";
$abc = "abc";
        $res .= "|";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $res .= "<p class='ui-li-desc'>{$ch->point_opponent} pont</p><p class='ui-li-desc'>{$ch->cnt_won_opponent}x győzött</p><p class='ui-li-desc'>{$ch->loot_opponent}$ zsákmány</p>";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        echo $res;
    }
}



1			<?php
2			class AjaxController extends Controller
3			{
4			public function actionTest($id = 0)
5			{
6			$ch = new Challenge;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
7			$ch->id = $id;
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `id` cannot be accessed from this context as it is declared `private` in class `Challenge`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
8			$ch->fetch();
9
10			$res = "<p class='ui-li-desc'>{$ch->point_caller} pont</p><p class='ui-li-desc'>{$ch->cnt_won_caller}x győzött</p><p class='ui-li-desc'>{$ch->loot_caller}$ zsákmány</p>";
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `point_caller` cannot be accessed from this context as it is declared `private` in class `Challenge`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `cnt_won_caller` cannot be accessed from this context as it is declared `private` in class `Challenge`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `loot_caller` cannot be accessed from this context as it is declared `private` in class `Challenge`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Best Practice introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$ch` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
11			$res .= "\|";
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The string literal `\|` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
12			$res .= "<p class='ui-li-desc'>{$ch->point_opponent} pont</p><p class='ui-li-desc'>{$ch->cnt_won_opponent}x győzött</p><p class='ui-li-desc'>{$ch->loot_opponent}$ zsákmány</p>";
			0 ignored issues – show Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `point_opponent` cannot be accessed from this context as it is declared `private` in class `Challenge`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `cnt_won_opponent` cannot be accessed from this context as it is declared `private` in class `Challenge`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Bug introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report The property `loot_opponent` cannot be accessed from this context as it is declared `private` in class `Challenge`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Coding Style Best Practice introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$ch` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
13
14			echo $res;
15			}
16			}
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
17

heal25 / ced

AjaxController::actionTest() A last analyzed 2016-09-14 21:49 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

AjaxController::actionTest() A
last analyzed 2016-09-14 21:49 UTC