Leaderboard

Complexity

Total Complexity

26

Size/Duplication

Total Lines	190
Duplicated Lines	27.89 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	attributeNames()	0	4	1
A	getUid()	0	4	1
A	getInClub()	0	4	1
A	getItems()	0	4	1
A	getBoardType()	0	4	1
A	getRange()	0	4	1
A	getTitle()	0	16	1
A	getPlayerRankDescription()	18	18	3
A	getClubRankDescription()	18	18	3
A	setBoardType()	0	4	1
B	setRange()	7	32	4
A	setUid()	0	4	1
A	setInClub()	0	4	1
B	fetchList()	10	29	4
A	getRankDescription()	0	9	2

<?php
/**
 * @property integer $uid
 * @property integer $inClub
 * @property array $items
 * @property string $boardType
 * @property string $range
 * @property string $title
 * @property string $playerRankDescription
 * @property string $clubRankDescription
 */
class Leaderboard extends CModel
{
    const BOARD_RANGE = 5;
    const TYPE_PLAYER = 'board_p';
    const TYPE_CLUB = 'board_c';

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

    const RANGE_ACTUAL = 'actual';

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

    const RANGE_PREVIOUS = 'prev';
    const RANGE_LAST_SIX = 'last';

    private $uid;
    private $inClub;
    private $items = [];
    private $key = '';

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

    private $boardType;
    private $range;

    public function attributeNames()
    {
        return [];
    }

    public function getUid()
    {
        return $this->uid;
    }

    public function getInClub()
    {
        return $this->inClub;
    }

    public function getItems()
    {
        return $this->items;
    }

    public function getBoardType()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->boardType;
    }

    public function getRange()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->range;
    }

    public function getTitle()
    {
        $titles = [
            self::TYPE_PLAYER => [
            self::RANGE_ACTUAL => 'Aktuális hónap legjobb játékosai',
            self::RANGE_PREVIOUS => 'Előző hónap legjobb játékosai',
            self::RANGE_LAST_SIX => 'Utolsó 6 hónap legjobb játékosai',
            ],
            self::TYPE_CLUB => [
            self::RANGE_ACTUAL => 'Aktuális hónap legjobb klubjai',
            self::RANGE_PREVIOUS => 'Előző hónap legjobb klubjai',
            self::RANGE_LAST_SIX => 'Utolsó 6 hónap legjobb klubjai',
            ]
            ];
        return $titles[$this->boardType][$this->range];
    }

    public function getPlayerRankDescription()

This method seems to be duplicated in your project.

    {
        $redis = Yii::app()->redis->getClient();

        $total = $redis->zCard($this->key);
        $rank  = $redis->zRevRank($this->key, $this->uid) + 1;

        if ($rank == 1) {
            return 'Te vagy a király!';
        } else {
            $percent = round((1 - ($rank / $total)) * 100, 1);
            if (!$percent) {
                return 'Több párbajgyőzelemre van szükséged.';
            }

            return 'Jobb vagy, mint a játékosok ' . $percent . '%-a!';
        }
    }

    public function getClubRankDescription()

This method seems to be duplicated in your project.

    {
        $redis = Yii::app()->redis->getClient();

        $total = $redis->zCard($this->key);
        $rank  = $redis->zRevRank($this->key, $this->inClub) + 1;

        if ($rank == 1) {
            return 'A te klubod a király!';
        } else {
            $percent = round((1 - ($rank / $total)) * 100, 1);
            if (!$percent) {
                return 'Több versenygyőzelemre van szükségetek.';
            }

            return 'Jobb a klubod, mint a többi klub ' . $percent . '%-a!';
        }
    }

    public function setBoardType ($type)
    {
        $this->boardType = $type;
    }

    public function setRange ($range)
    {
        $d = new DateTime();

        //create key from date/intersect
        switch ($range) {
            case self::RANGE_LAST_SIX:
                $this->key = $this->boardType . ':6month';
                //create intersect

                $history = [];

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

                $history[] = $this->boardType . ':' . $d->format('Ym');

                for ($i=0; $i<6; $i++) {
                    $d->modify('first day of previous month');
                    $history[] = $this->boardType . ':' . $d->format('Ym');
                }

                $redis = Yii::app()->redis->getClient();
                $redis->zUnionStore($this->key, $history);

                break;
            case self::RANGE_PREVIOUS:

This code seems to be duplicated across your project.

                $d->modify('first day of previous month');
                $this->key = $this->boardType . ':' . $d->format('Ym');
                break;
            default:

This code seems to be duplicated across your project.

                $range = self::RANGE_ACTUAL;

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

                $this->key = $this->boardType . ':' . $d->format('Ym');
        }
        $this->range = $range;
    }

    public function setUid($uid)
    {
        $this->uid = (int)$uid;
    }

    public function setInClub($id)
    {
        $this->inClub = (int)$id;
    }

    public function fetchList()
    {
        if ($this->boardType == self::TYPE_PLAYER) {
            $class = 'Player';
        } else {
            $class = 'Club';
        }

        $redis = Yii::app()->redis->getClient();

        $myRank = $redis->zRevRank($this->key, $this->inClub);

        $range = self::BOARD_RANGE;
        $min = $myRank - $range > 0 ? $myRank - $range : 0;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $max = $myRank + $range + ($range-$myRank+$min);

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $item = new $class;
        $i = $min+1;

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        foreach ($redis->zRevRange($this->key, $min, $max, true) as $id => $score) {

This code seems to be duplicated across your project.

            $item->subjectId = $id;

            $this->items[$i] = [
                'id'=>$id,
                'name'=>$item->getSubjectName(),
                'score'=>$score,
                ];
            $i++;
        }
    }

    public function getRankDescription()
    {
        if ($this->boardType == self::TYPE_CLUB) {
            $ret = $this->getClubRankDescription();
        } else {
            $ret = $this->getPlayerRankDescription();
        }
        return $ret;
    }
}

As per coding style, files should not end with a newline character.