DuelController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	beforeAction()	0	12	2
A	actionIndex()	0	14	1
A	actionCommon()	0	9	1
A	actionHistory()	0	9	1
A	actionGo()	0	19	3
A	actionReplay()	0	14	2

<?php
class DuelController extends GameController
{
    protected function beforeAction($action)
    {
        parent::beforeAction($action);

        if (Yii::app()->player->model->level < Yii::app()->params['duelLevelRequirement']) {
            $this->render('lowlevel', [
                'levelRequirement' => Yii::app()->params['duelLevelRequirement']
            ]);
            return false;
        }
        return true;
    }


    public function actionIndex($page = 0)
    {
        $duelList = new DuelList();

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

        $duelList->page = $page;

The property page cannot be accessed from this context as it is declared private in class DuelList.

        $duelList->fetchOpponents();

        $this->render('index', [
            'list'=>$duelList->opponents,

The property opponents cannot be accessed from this context as it is declared private in class DuelList.

            'pagination' => $duelList->pagination,

The property pagination cannot be accessed from this context as it is declared private in class DuelList.

            'count' => $duelList->count,

The property count cannot be accessed from this context as it is declared private in class DuelList.

            'page_size' => Yii::app()->params['listPerPage'],
            'page'=>$page,
            ]);
    }

    public function actionCommon()
    {
        $duelList = new DuelList();
        $duelList->fetchCommonRivals();

        $this->render('commonrivals', [
            'list'=>$duelList->opponents,

The property opponents cannot be accessed from this context as it is declared private in class DuelList.

            ]);
    }

    public function actionHistory()
    {
        $duelList = new DuelList();
        $duelList->fetchLastRivals();

        $this->render('history', [
            'list'=>$duelList->opponents,

The property opponents cannot be accessed from this context as it is declared private in class DuelList.

            ]);
    }

    public function actionGo($opponentId = 0)
    {
        $duel = new Duel();

Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space

        $duel->caller = Yii::app()->player->uid;

The property caller cannot be accessed from this context as it is declared private in class Duel.

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $duel->opponent = $opponentId;

The property opponent cannot be accessed from this context as it is declared private in class Duel.

        $duel->fetchClubChallengeState();

        try {
            if ($duel->validateDuel()) {
                $duel->play();
            }
        } catch (CFlashException $e) {
            Yii::app()->user->setFlash('error', $e->getMessage());
        }

        $this->render('go', [
            'duel'=>$duel,
            ]);
    }

    public function actionReplay($id)
    {
        $duel = new Duel;
        try {
            $duel->replay((int)$id);
        } catch (CFlashException $e) {
            Yii::app()->user->setFlash('error', $e->getMessage());
            $this->redirect('/duel');
        }

        $this->render('replay', [
            'duel'=>$duel,
            ]);
    }
}

As per coding style, files should not end with a newline character.