Badge

Complexity

Total Complexity

6

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	attributeNames()	0	4	1
A	getUid()	0	4	1
A	setUid()	0	4	1
A	fetchBadges()	0	9	2
A	getBadge()	0	5	1

<?php
/**
 * @property integer $uid
 * @property array $badges
 */
class Badge extends CModel
{
    const LEVEL_BRONZE = 1;
    const LEVEL_SILVER = 2;
    const LEVEL_GOLD = 3;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

    protected $uid;
    protected $badges;

    public function attributeNames()
    {
        return [];
    }

    public function getUid()
    {
        return $this->uid;
    }

    public function setUid($uid)
    {
        $this->uid = (int)$uid;
    }

    public function fetchBadges()
    {
        $redis = Yii::app()->redis->getClient();
        if ($this->badges) {
            return false;
        }

        $this->badges = $redis->sMembers('badges:all');
    }

    protected function getBadge($id)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $redis = Yii::app()->redis->getClient();
        return $redis->hGetAll("badges:d:$id");

As per coding-style, please use concatenation or sprintf for the variable $id instead of interpolation.

    }
}

As per coding style, files should not end with a newline character.