Advancement

Complexity

Total Complexity

13

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	attributeNames()	0	4	1
A	getUid()	0	4	1
A	getDollarImprovement()	0	4	1
A	getSkillImprovement()	0	15	1
A	setUid()	0	4	1
C	incrementForStatuspoint()	0	38	8

<?php
/**
 * @property integer $uid
 * @property integer $dollarImprovement
 * @property integer $skillImprovement
 */
class Advancement extends CModel
{
    private $uid;
    
    public function attributeNames()
    {
        return [];
    }

    // getters
    public function getUid()
    {
        return (int)$this->uid;
    }
    
    public function getDollarImprovement()
    {
        return 30 + (5 * Yii::app()->player->model->level);
    }

    public function getSkillImprovement()
    {
        $di = $this->getDollarImprovement();

        //strongest bait
        $bait = Yii::app()->db->createCommand()

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

            ->select('id, skill, price')
            ->from('baits')
            ->where('level<=:level', [':level'=>(int)Yii::app()->player->model->level])
            ->order('level DESC')
            ->limit(1)
            ->queryRow();
        $skill = round($di / $bait['price'] * $bait['skill'] / 2 * 0.8);
        return (int)$skill;
    }

    public function setUid($uid)
    {
        $this->uid = (int)$uid;
    }
        
    public function incrementForStatuspoint($id)
    {
        $player = Yii::app()->player->model;
        if (!$player->itsMe()) {
            return false;
        }
        if ($player->status_points < 1) {
            return false;
        }

        $mapIdAttribute = [

Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space

            1=>['energy_max'=>1, 'energy'=>1],
            ['skill'=>2, 'skill_extended'=>2],
            ['strength'=>2],
            ['dollar'=>$this->getDollarImprovement()]
            ];
        $mapIdAttribute[2]['skill'] = $mapIdAttribute[2]['skill_extended'] = $this->getSkillImprovement();

        $increment = isset($mapIdAttribute[$id]) ? $mapIdAttribute[$id] : false;

        if ($increment) {
            $player->updateAttributes($increment, ['status_points'=>1]);
            //badge
            $b = new ProfileBadgeActivator();

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

            $b->uid = $this->uid;

            if ($id==1) {
                $b->triggerMaxNrg($player->energy_max);
            }
            if ($id==2) {
                $b->triggerSkill($player->skill);
            }
            if ($id==3) {
                $b->triggerStrength($player->strength);
            }
        }
        return true;
    }
}

As per coding style, files should not end with a newline character.