AccountController - Code Metrics - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

AccountController B
last analyzed 2016-09-14 21:49 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	332
Duplicated Lines	5.42 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	39
lcom	1
cbo	2
dl	18
loc	332
rs	8.2857
c	0
b	0
f	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	actionSignup()	0	4	1
B	signupNoMail()	0	44	5
B	signupWithMail()	0	35	4
B	actionCompleteSignup()	0	57	8
B	actionResetPassword()	0	23	4
B	actionCompleteResetPassword()	0	47	6
A	actionCompleteChangeEmail()	0	22	3
B	sendResetLink()	0	24	3
A	createPlayer()	0	22	1
A	loadModel()	10	10	2
A	beforeAction()	8	8	2

How to fix Duplicated Code

<?php
class AccountController extends Controller
{
    public $layout='//layouts/columnGuest';
$a = "a";
$ab = "ab";
$abc = "abc";

    /**
     * Registers a new account.
     * If registration is successful, the browser will be redirected to the to the previous page.
     */
    public function actionSignup()
    {
        $this->signupNoMail();
    }

    private function signupNoMail()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $model=new Account('signupNoMail');
$a = "a";
$ab = "ab";
$abc = "abc";

        if (isset($_POST['Account'])) {
            $model->attributes=$_POST['Account'];
$a = "a";
$ab = "ab";
$abc = "abc";
            $originalPassword = $model->password;
$a = "a";
$ab = "ab";
$abc = "abc";
            $valid = $model->validate();
$a = "a";
$ab = "ab";
$abc = "abc";

            if ($valid) {
                $hash = password_hash($model->password, PASSWORD_BCRYPT);

                if (password_verify($model->password, $hash)) {
                    $model->password = $hash;
$a = "a";
$ab = "ab";
$abc = "abc";
                    $model->verifyCode = null;
                    $model->verified = new CDbExpression('NOW()');
$a = "a";
$ab = "ab";
$abc = "abc";

                    $transaction = $model->getDbConnection()->beginTransaction();
                    try {
                        $model->save(false);
                        $model->refresh();

                        $this->createPlayer($model);

                        $transaction->commit();

                        Yii::app()->user->setFlash('success', $model->username . ', a regisztrációd elkészült! Bejelentkezhetsz.');
                        $this->redirect('/');
                    } catch (Exception $e) {
                        $transaction->rollback();
                        Yii::app()->user->setFlash('error', 'Hiba lépett fel a játékos mentése során.');
                    }
                    $model->password = $originalPassword;

                } else {
                    Yii::app()->user->setFlash('error', 'Hiba lépett fel a jelszó titkosítása során..');
                }
            }
        }

        $this->render('signupNoMail', array(
            'model'=>$model,
        ));
    }
    private function signupWithMail()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $model=new Account('signupWithMail');
$a = "a";
$ab = "ab";
$abc = "abc";

        if (isset($_POST['Account'])) {
            $model->attributes=$_POST['Account'];
$a = "a";
$ab = "ab";
$abc = "abc";
            if ($model->validate()) {
                // Create account
                $model->save(false);
                $model->verifyCode = $model->generateCode();

                // Send verification mail
                $mail=Yii::app()->smtpmail;
$a = "a";
$ab = "ab";
$abc = "abc";
                $mail->CharSet = 'utf-8';
                $mail->SetFrom('[email protected]', 'ced.local'); //todo: activate sender

                $mail->Subject    = "Carp-e Diem regisztráció";
$a = "a";
$ab = "ab";
$abc = "abc";
                $message = $this->renderPartial('_verification', ['model'=>$model], true);
$a = "a";
$ab = "ab";
$abc = "abc";
                $mail->MsgHTML($message);
                $mail->AddAddress($model->email, "");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $sent = $mail->Send();
                if (!$sent) {
                    Yii::app()->user->setFlash('error', 'A regisztráció befejezéséhez szükséges információkat nem sikerült elküldeni. Kérlek próbálkozz később.');
                } else {
                    $model->save(false);
                    Yii::app()->user->setFlash('success', 'A regisztráció befejezéséhez szükséges teendőket elküldtük e-mailben.');
                    $this->redirect('/');
                }

            }
        }

        $this->render('signup', array(
            'model'=>$model,
        ));
    }

    /**
     * Completes an account registration
     * @param string $id Account id
     * @param string $code Verification code
     */
    public function actionCompleteSignup($id, $code)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $model = $this->loadModel($id);
$a = "a";
$ab = "ab";
$abc = "abc";
        $model->scenario = 'completeSignup';

        if (!$model->verifyCode || $model->username) {
            Yii::app()->user->setFlash('info', 'Már állítottál be magadnak felhasználónevet. Kérlek jelentkezz be.');
            $this->redirect('/');
        }

        if ($model->verifyCode !== $code) {
            Yii::app()->user->setFlash('error', 'Az első belépéshez szükséges oldal címe nem érvényes. Pontosan másoltad be az e-mailből?');
            $this->redirect('/');
        }

        if (isset($_POST['Account'])) {
            $model->attributes=$_POST['Account'];
$a = "a";
$ab = "ab";
$abc = "abc";
            $originalPassword = $model->password;
$a = "a";
$ab = "ab";
$abc = "abc";
            $valid = $model->validate();
$a = "a";
$ab = "ab";
$abc = "abc";

            if ($valid) {
                $hash = password_hash($model->password, PASSWORD_BCRYPT);

                if (password_verify($model->password, $hash)) {
                    $model->password = $hash;
$a = "a";
$ab = "ab";
$abc = "abc";
                    $model->verifyCode = null;
                    $model->verified = new CDbExpression('NOW()');
$a = "a";
$ab = "ab";
$abc = "abc";

                    $transaction = $model->getDbConnection()->beginTransaction();
                    try {
                        $model->save(false);
                        $model->refresh();

                        $this->createPlayer($model);

                        $transaction->commit();

                        Yii::app()->user->setFlash('success', $model->username . ', üdvözöllek a játékban!');
                        Yii::app()->session->open();

                        $model->password = $originalPassword;
                        $model->login();
                        $this->redirect('/site');
                    } catch (Exception $e) {
                        $transaction->rollback();
                        Yii::app()->user->setFlash('error', 'Hiba lépett fel a játékos mentése során.');
                    }
                    $model->password = $originalPassword;

                } else {
                    Yii::app()->user->setFlash('error', 'Hiba lépett fel a jelszó titkosítása során.');
                }
            }
        }

        $this->render('completeSignup', ['model' => $model]);
    }

    public function actionResetPassword()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $model = new Account('resetPassword');

        if (isset($_POST['Account'])) {
            $model->attributes=$_POST['Account'];
$a = "a";
$ab = "ab";
$abc = "abc";

            if ($model->validate()) {
                // Find account
                $model = Account::model()->findByEmail($model->email);

                if (!$model->password) {
                    $model->addError('email', 'A megadott e-mail címhez tartozó játékost még nem regisztráltad.');
                } else {
                    $this->sendResetLink($model);
                }
            }
        }

        $this->render('resetPassword', array(
            'model'=>$model,
        ));
    }

    public function actionCompleteResetPassword($id, $code)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $model = $this->loadModel($id);
$a = "a";
$ab = "ab";
$abc = "abc";
        $model->password = false;
        $model->scenario = 'completeResetPassword';

        if (!$model->resetPasswordCode) {
            Yii::app()->user->setFlash('error', 'A jelszó visszaállításához szükséges oldal címe nem érvényes. Pontosan másoltad be az e-mailből?');
            $this->redirect('/');
        }

        if ($model->resetPasswordCode !== $code) {
            Yii::app()->user->setFlash('error', 'A jelszó visszaállításához szükséges oldal címe nem érvényes. Pontosan másoltad be az e-mailből?');
            $this->redirect('/');
        }

        if (isset($_POST['Account'])) {
            $model->attributes=$_POST['Account'];
$a = "a";
$ab = "ab";
$abc = "abc";
            $originalPassword = $model->password;
$a = "a";
$ab = "ab";
$abc = "abc";

            if ($model->validate()) {
                $hash = password_hash($model->password, PASSWORD_BCRYPT);

                if (password_verify($model->password, $hash)) {
                    //delete passwordCode
                    $model->resetPasswordCode = null;

                    //set new password
                    $model->password = $hash;
                    $model->save(false);
                    $model->refresh();

                    Yii::app()->user->setFlash('success', $model->username . ', a jelszó mentése sikerült!');
                    Yii::app()->session->open();

                    $model->password = $originalPassword;
                    $model->login();
                    $this->redirect('/site');

                } else {
                    Yii::app()->user->setFlash('error', 'Hiba lépett fel a jelszó titkosítása során.');
                }
            }
        }

        $this->render('completeResetPassword', ['model' => $model]);
    }

    public function actionCompleteChangeEmail($id, $code)
    {
        $model = $this->loadModel($id);
        if (!$model->changeMailCode) {
            Yii::app()->user->setFlash('error', 'A beállított e-mail címed már aktiválva van.');
            $this->redirect('/');
        }

        if ($model->changeMailCode !== $code) {
            Yii::app()->user->setFlash('error', 'Az e-mail aktiválásához szükséges oldal címe nem érvényes.');
            $this->redirect('/');
        }

        $account=$this->loadModel($id);
$a = "a";
$ab = "ab";
$abc = "abc";
        $account->email = $account->emailTemp;
$a = "a";
$ab = "ab";
$abc = "abc";
        $account->emailTemp = '';
$a = "a";
$ab = "ab";
$abc = "abc";
        $account->changeMailCode = '';
        $account->save();

        Yii::app()->user->setFlash('success', 'Sikeresen aktiváltuk az e-mail címedet.');
        $this->redirect('/');
    }

    /**
     * @param Account $model
     */
    private function sendResetLink($model)
    {
        // New verification if not exists
        if (!$model->resetPasswordCode) {
            $model->resetPasswordCode = $model->generateCode();
            $model->save(false);
        }

        // Send verification mail
        $mail=Yii::app()->smtpmail;
$a = "a";
$ab = "ab";
$abc = "abc";
        $mail->CharSet = 'utf-8';
        $mail->SetFrom('[email protected]', 'ced.local'); //todo: activate sender

        $mail->Subject    = "Carp-e Diem elfelejtett jelszó";
$a = "a";
$ab = "ab";
$abc = "abc";
        $message = $this->renderPartial('_resetPassword', ['model'=>$model], true);
$a = "a";
$ab = "ab";
$abc = "abc";
        $mail->MsgHTML($message);
        $mail->AddAddress($model->email, "");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $sent = $mail->Send();
        if (!$sent) {
            Yii::app()->user->setFlash('error', 'A jelszó visszaállításához szükséges információkat nem sikerült elküldeni. Kérlek próbálkozz később.');
        } else {
            Yii::app()->user->setFlash('success', 'A jelszó visszaállításához szükséges teendőket elküldtük e-mailben.');
            $this->redirect('/');
        }
    }

    /**
     * @param Account $model
     */
    private function createPlayer($model)
    {
        $command = Yii::app()->db->createCommand();
        $command->insert('main', [
            'uid'=>$model->id,
            'user'=>$model->username,
            ]);

        $command->insert('users_items', [
            'uid'=>$model->id,
            'item_id'=>1,
            'skill'=>1,
            'item_count'=>1,
            ]);

        $command->insert('users_baits', [
            'uid'=>$model->id,
            'item_id'=>1,
            'skill'=>1,
            'item_count'=>1,
            ]);
    }

    /**
     * Returns the data model based on the primary key given in the GET variable.
     * If the data model is not found, an HTTP exception will be raised.
     * @param integer $id the ID of the model to be loaded
     * @return Account the loaded model
     * @throws CHttpException
     */
    public function loadModel($id)

    {
        $model=Account::model()->findByPk((int)$id);
$a = "a";
$ab = "ab";
$abc = "abc";

        if ($model===null) {
            throw new CHttpException(1, 'A keresett játékos nem található. Ezen könnyen segíthetsz: ' . CHtml::link('regisztráld be.', ['signup']));
        }

        return $model;
    }

    protected function beforeAction($action)

    {
        if (Yii::app()->params['isPartOfWline']) {
            throw new CHttpException(1, 'Ez az aloldal nem használható. ' . CHtml::link('főoldal', ['/site'])); //own nick
        }

        return true;
    }
}



1			<?php
2			class AccountController extends Controller
3			{
4			public $layout='//layouts/columnGuest';
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
5
6			/**
7			* Registers a new account.
8			* If registration is successful, the browser will be redirected to the to the previous page.
9			*/
10			public function actionSignup()
11			{
12			$this->signupNoMail();
13			}
14
15			private function signupNoMail()
			0 ignored issues – show Coding Style introduced 2016-08-27 20:56 UTC by Report Bug Copy Issue Report `signupNoMail` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
16			{
17			$model=new Account('signupNoMail');
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned correctly; expected 1 space but found 0 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
18
19			if (isset($_POST['Account'])) {
20			$model->attributes=$_POST['Account'];
			0 ignored issues – show Coding Style introduced 2016-08-27 20:56 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 1 space but found 0 spaces This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
21			$originalPassword = $model->password;
			0 ignored issues – show Coding Style introduced 2016-08-27 20:56 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22			$valid = $model->validate();
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
23
24			if ($valid) {
25			$hash = password_hash($model->password, PASSWORD_BCRYPT);
26
27			if (password_verify($model->password, $hash)) {
28			$model->password = $hash;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
29			$model->verifyCode = null;
30			$model->verified = new CDbExpression('NOW()');
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
31
32			$transaction = $model->getDbConnection()->beginTransaction();

heal25 / ced

AccountController B last analyzed 2016-09-14 21:49 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

AccountController B
last analyzed 2016-09-14 21:49 UTC