Hborras\TwitterAdsSDK\TwitterAds\Batch

Complexity

Total Complexity

11

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getId()	0	5	1
A	getAccount()	0	4	1
A	toParams()	0	10	2
A	getBatch()	0	4	1
A	add()	0	6	1
A	assureBatchSize()	0	11	4

<?php

namespace Hborras\TwitterAdsSDK\TwitterAds;

use Hborras\TwitterAdsSDK\TwitterAds\Resource;
use Hborras\TwitterAdsSDK\TwitterAds\Account;
use Hborras\TwitterAdsSDK\Arrayable;
use Hborras\TwitterAdsSDK\TwitterAds\Errors\BatchLimitExceeded;

abstract class Batch extends Resource
{
    private $batch = [];
    private $batchSize;
    private $account;

Consider using a different property name as you override a private property of the parent class.

    public function __construct(Account $account=null, $batchSize=10,  $batch=[])
    {
        parent::__construct($account);
        $this->account = $account;
        $this->batchSize = $batchSize;
        $this->batch = $this->assureBatchSize($batch);
    }

    /**
     * {@inheritdoc}
     */
    public function getId()
    {
        //Always use POST request by setting the ID to null
        return null;
    }

    public function getAccount()
    {
        return $this->account;
    }

    /**
     * {@inheritdoc}
     */
    public function toParams()
    {
        $data = [];

        foreach ($this->batch as $member) {
            $data[] = $member->toArray();
        }

        return $data;
    }
    
    public function getBatch()
    {
        return $this->batch;
    }

    public function add(Arrayable $data)
    {
        $this->assureBatchSize();

        $this->batch[] = $data;
    }

    /**
     * Assures the batch is not over the batch size limit.
     *
     * @param $batch|null
     *
     * @throws BatchLimitExceeded when the batch is full
     * @return $batch|$this->batch

The doc-type $batch|$this->batch could not be parsed: Unknown type name "$batch" at position 0. (view supported doc-types)

     */
    public function assureBatchSize($batch=null)
    {
        if (count($batch ?: $this->batch) < $this->batchSize) {
            return $batch ?: $this->batch;
        }

        throw new BatchLimitExceeded(sprintf(
            'Cannot add data to batch. Max size is %s',
            $this->batchSize
        ));
    }
}