AbstractLoader - Code Metrics - Inspection of "Deprecate doctrine loaders" - hautelook/AliceBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 1.x (#264)

by Théo

created 2016-10-22 21:02 UTC

AbstractLoader A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	3
c	2
b	0
f	0
lcom	0
cbo	0
dl	0
loc	37
ccs	5
cts	5
cp	1
rs	10

3 Methods

Rating	Name	Size	Complexity
A	__construct()	7	1
A	setContainer()	4	1
A	load()	3	1

<?php

/*
 * This file is part of the Hautelook\AliceBundle package.
 *
 * (c) Baldur Rensch <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Hautelook\AliceBundle\Doctrine\DataFixtures;

use Doctrine\Common\Persistence\ObjectManager;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
 * Helper for declaring doctrine data loaders.
 *
 * @author Baldur Rensch <[email protected]>
 * @author Théo FIDRY <[email protected]>
 * @author Sullivan Senechal <[email protected]>
 */
abstract class AbstractLoader implements ContainerAwareInterface, LoaderInterface
{
    /**
     * @var ContainerInterface
     */
    protected $container;

    public function __construct()
    {
        @trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            'Doctrine loaders support is deprecated since 1.4.0 and will be removed in 2.0.',
            E_USER_DEPRECATED
        );
    }


    /**
     * {@inheritdoc}
     *
     * Use Symfony\Component\DependencyInjection\ContainerAwareTrait instead when dropping SF 2.3 and PHP 5.3 support.
     */
    public function setContainer(ContainerInterface $container = null)
    {
        $this->container = $container;
    }

    /**
     * Loads the fixtures files.
     *
     * @param ObjectManager $objectManager
     *
     * @return \object[] Persisted objects
     */
    public function load(ObjectManager $objectManager)
    {
    }
}


1		<?php
2
3		/*
4		* This file is part of the Hautelook\AliceBundle package.
5		*
6		* (c) Baldur Rensch <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Hautelook\AliceBundle\Doctrine\DataFixtures;
13
14		use Doctrine\Common\Persistence\ObjectManager;
15		use Symfony\Component\DependencyInjection\ContainerAwareInterface;
16		use Symfony\Component\DependencyInjection\ContainerInterface;
17
18		/**
19		* Helper for declaring doctrine data loaders.
20		*
21		* @author Baldur Rensch <[email protected]>
22		* @author Théo FIDRY <[email protected]>
23		* @author Sullivan Senechal <[email protected]>
24		*/
25		abstract class AbstractLoader implements ContainerAwareInterface, LoaderInterface
26		{
27		/**
28		* @var ContainerInterface
29		*/
30		protected $container;
31
32		public function __construct()
33		{
34		@trigger_error(
		0 ignored issues – show Security Best Practice introduced 2016-10-23 00:18 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
35		'Doctrine loaders support is deprecated since 1.4.0 and will be removed in 2.0.',
36		E_USER_DEPRECATED
37	108	);
38		}
39	108
40	108
41		/**
42		* {@inheritdoc}
43		*
44		* Use Symfony\Component\DependencyInjection\ContainerAwareTrait instead when dropping SF 2.3 and PHP 5.3 support.
45		*/
46		public function setContainer(ContainerInterface $container = null)
47		{
48		$this->container = $container;
49	6	}
50
51	6	/**
52		* Loads the fixtures files.
53		*
54		* @param ObjectManager $objectManager
55		*
56		* @return \object[] Persisted objects
57		*/
58		public function load(ObjectManager $objectManager)
59		{
60		}
61		}
62

hautelook / AliceBundle

GitHub Access Token became invalid

Pull Request — 1.x (#264)

AbstractLoader A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like