m160706_223500_vote_updates::up() - Code Metrics - Inspection of "a706ce769f23b1e2973910fde38d03c880c8a384" - hauntd/yii2-vote - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (a706ce)

by Alexander

created 2018-06-29 13:22 UTC

m160706_223500_vote_updates::up() A

↳ Parent: m160706_223500_vote_updates

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

use hauntd\vote\migrations\Migration;

/**
 * @author Alexander Kononenko <[email protected]>
 */
class m160706_223500_vote_updates extends Migration
namespace YourVendor;

class YourClass { }
{
    public function up()
    {
        $this->createIndex('vote_target_user_idx', '{{%vote}}', ['entity', 'target_id', 'user_id'], false);
        $this->alterColumn('{{%vote}}', 'value', $this->boolean()->notNull());

        //TODO: check these command and fix migration
        //$this->execute('ALTER TABLE vote ALTER COLUMN value TYPE boolean USING CASE value WHEN 0 THEN false ELSE true END');

    }

    public function down()
    {
        $this->dropIndex('vote_target_user_idx', '{{%vote}}');
        $this->alterColumn('{{%vote}}', 'value', $this->smallInteger(1)->notNull());
    }
}


1			<?php
2
3			use hauntd\vote\migrations\Migration;
4
5			/**
6			* @author Alexander Kononenko <[email protected]>
7			*/
8			class m160706_223500_vote_updates extends Migration
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-08 02:52 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9			{
10			public function up()
11			{
12			$this->createIndex('vote_target_user_idx', '{{%vote}}', ['entity', 'target_id', 'user_id'], false);
13			$this->alterColumn('{{%vote}}', 'value', $this->boolean()->notNull());
14
15			//TODO: check these command and fix migration
16			//$this->execute('ALTER TABLE vote ALTER COLUMN value TYPE boolean USING CASE value WHEN 0 THEN false ELSE true END');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-23 06:36 UTC by Report Bug Copy Issue Report `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
17			}
18
19			public function down()
20			{
21			$this->dropIndex('vote_target_user_idx', '{{%vote}}');
22			$this->alterColumn('{{%vote}}', 'value', $this->smallInteger(1)->notNull());
23			}
24			}
25

hauntd / yii2-vote

Branch — master (a706ce)

m160706_223500_vote_updates::up() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like