Noodlehaus\Parser\Properties

Complexity

Total Complexity

5

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	parseFile()	0	4	1
A	parseString()	0	4	1
A	parse()	0	16	2
A	getSupportedExtensions()	0	4	1

<?php

namespace Noodlehaus\Parser;

use Noodlehaus\Exception\ParseException;

/**
 * Properties parser.
 *
 * @package    Config
 * @author     Jesus A. Domingo <jesus.domingo@gmail.com>
 * @author     Hassan Khan <contact@hassankhan.me>
 * @author     Filip Š <projects@filips.si>
 * @author     Mark de Groot <mail@markdegroot.nl>
 * @link       https://github.com/noodlehaus/config
 * @license    MIT
 */
class Properties implements ParserInterface
{
    /**
     * {@inheritdoc}
     * Parses a Properties file as an array.
     */
    public function parseFile($filename)
    {
        return $this->parse(file_get_contents($filename));
    }

    /**
     * {@inheritdoc}
     * Parses a Properties string as an array.
     */
    public function parseString($config)
    {
        return $this->parse($config);
    }

    private function parse($txtProperties)
    {
        $result = [];

        // first remove all escaped whitespace characters:
        $txtProperties = preg_replace('/(?<!\\\\)\\\\[\r\n\t\f\v][ \r]*/', '', $txtProperties);

        // next split all lines not starting with # or ! on characters = or : (unless escaped):
        preg_match_all('/^([^#!].*)(?<!\\\\)[=:](.*)$/mU', $txtProperties, $matches, PREG_SET_ORDER, 0);

        foreach ($matches as $match) {

The expression $matches of type null|array<integer,array<integer,string>> is not guaranteed to be traversable. How about adding an additional type check?

            $result[trim(stripslashes($match[1]))] = trim(stripslashes($match[2]));
        }

        return $result;
    }

    /**
     * {@inheritdoc}
     */
    public static function getSupportedExtensions()
    {
        return ['properties'];
    }
}