Field::lessThan() - Code Metrics - Inspection of "add is true validation" - harryosmar/plugin-validation - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 289a67...2a2cfd )

unknown

created 2018-02-16 16:38 UTC

Field::lessThan() A

↳ Parent: Field

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	5
ccs	3
cts	3
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php

namespace PluginSimpleValidate;

use const PluginSimpleValidate\helper\Validate\VAR_IS_TRUE;
use const PluginSimpleValidate\helper\Validate\VAR_LIMIT;
use const PluginSimpleValidate\helper\Validate\VAR_LOWER_LIMIT;
use const PluginSimpleValidate\helper\Validate\VAR_MATCH;
use const PluginSimpleValidate\helper\Validate\VAR_MESSAGE;
use const PluginSimpleValidate\helper\Validate\VAR_UPPER_LIMIT;
use PluginSimpleValidate\Libraries\Language;

class Field extends \PluginSimpleValidate\BaseAbstract\Field implements \PluginSimpleValidate\Contracts\Field
{
    /**
     * @var string
     */
    private $name;

    /**
     * @var string
     */
    private $value;

    /**
     * @var array
     */
    private $errors;

    /**
     * @var array
     * array of Rule
     */
    private $rules = [];

    /**
     * @var bool
     */
    private $status;

    /**
     * Field constructor.
     * @param string $name
     * @param mixed $value
     */
    public function __construct(string $name, $value)
    {
        $this->name = $name;
        $this->value = $value;
        $this->errors = [];
    }

    /**
     * @param string $rulesMethod
     * @param array $args
     * @return $this
     */
    protected function addRules(string $rulesMethod, array $args = [])
    {
        $this->rules[$rulesMethod] = RuleMapping::getRule($rulesMethod, $args);
        return $this;
    }

    /**
     * @param Language $language
     * @param bool $break_when_error
     * @return bool
     */
    public function isValid(Language $language, $break_when_error = false) : bool

    {
        /** @var \PluginSimpleValidate\Contracts\Rule $rule */
        foreach ($this->rules as $ruleName => $rule) {
            if (!$rule->isValid($language, $this->value)) {
                $this->status = false;
                $this->errors[] = $rule->getError();

                /**
                 * break when there is any rule error
                 */
                if ($break_when_error === true) {
                    break;
                }
            }
        }

        if (empty($this->errors)) {
            $this->status = true;
        }

        return $this->status;
    }

    /**
     * @return string
     */
    public function getName(): string
    {
        return $this->name;
    }

    /**
     * @return mixed
     */
    public function getValue()
    {
        return $this->value;
    }

    /**
     * @return array
     */
    public function getRules(): array
    {
        return $this->rules;
    }

    /**
     * @return array
     */
    public function getErrors(): array
    {
        return $this->errors;
    }

    /**
     * @return $this
     */
    public function required()
    {
        $this->addRules('required');
        return $this;
    }

    /**
     * @return $this
     */
    public function validEmail()
    {
        $this->addRules('valid_email');
        return $this;
    }

    /**
     * @param int|float|double|string $match
     * @return $this
     */
    public function equal($match)
    {
        $this->addRules('equal', [VAR_MATCH => $match]);
        return $this;
    }

    /**
     * @param int|float|double $limit
     * @return $this
     */
    public function lessThan($limit)
    {
        $this->addRules('less_than', [VAR_LIMIT => $limit]);
        return $this;
    }

    /**
     * @param int|float|double $lower
     * @param int|float|double $upper
     * @return $this
     */
    public function between($lower, $upper)
    {
        $this->addRules('between', [VAR_LOWER_LIMIT => $lower, VAR_UPPER_LIMIT => $upper]);
        return $this;
    }

    /**
     * @param string $message
     * @return $this
     */
    public function isTrue(string $message = '')
    {
        $this->addRules('is_true', [VAR_MESSAGE => $message]);
        return $this;
    }
}

1			<?php
2
3			namespace PluginSimpleValidate;
4
5			use const PluginSimpleValidate\helper\Validate\VAR_IS_TRUE;
6			use const PluginSimpleValidate\helper\Validate\VAR_LIMIT;
7			use const PluginSimpleValidate\helper\Validate\VAR_LOWER_LIMIT;
8			use const PluginSimpleValidate\helper\Validate\VAR_MATCH;
9			use const PluginSimpleValidate\helper\Validate\VAR_MESSAGE;
10			use const PluginSimpleValidate\helper\Validate\VAR_UPPER_LIMIT;
11			use PluginSimpleValidate\Libraries\Language;
12
13			class Field extends \PluginSimpleValidate\BaseAbstract\Field implements \PluginSimpleValidate\Contracts\Field
14			{
15			/**
16			* @var string
17			*/
18			private $name;
19
20			/**
21			* @var string
22			*/
23			private $value;
24
25			/**
26			* @var array
27			*/
28			private $errors;
29
30			/**
31			* @var array
32			* array of Rule
33			*/
34			private $rules = [];
35
36			/**
37			* @var bool
38			*/
39			private $status;
40
41			/**
42			* Field constructor.
43			* @param string $name
44			* @param mixed $value
45			*/
46	8		public function __construct(string $name, $value)
47			{
48	8		$this->name = $name;
49	8		$this->value = $value;
50	8		$this->errors = [];
51	8		}
52
53			/**
54			* @param string $rulesMethod
55			* @param array $args
56			* @return $this
57			*/
58	7		protected function addRules(string $rulesMethod, array $args = [])
59			{
60	7		$this->rules[$rulesMethod] = RuleMapping::getRule($rulesMethod, $args);
61	7		return $this;
62			}
63
64			/**
65			* @param Language $language
66			* @param bool $break_when_error
67			* @return bool
68			*/
69	7	View Code Duplication	public function isValid(Language $language, $break_when_error = false) : bool
			0 ignored issues – show Duplication introduced 2018-02-16 16:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70			{
71			/** @var \PluginSimpleValidate\Contracts\Rule $rule */
72	7		foreach ($this->rules as $ruleName => $rule) {
73	7		if (!$rule->isValid($language, $this->value)) {
74	7		$this->status = false;
75	7		$this->errors[] = $rule->getError();
76
77			/**
78			* break when there is any rule error
79			*/
80	7		if ($break_when_error === true) {
81	7		break;
82			}
83			}
84			}
85
86	7		if (empty($this->errors)) {
87			$this->status = true;
88			}
89
90	7		return $this->status;
91			}
92
93			/**
94			* @return string
95			*/
96	2		public function getName(): string
97			{
98	2		return $this->name;
99			}
100
101			/**
102			* @return mixed
103			*/
104	1		public function getValue()
105			{
106	1		return $this->value;
107			}
108
109			/**
110			* @return array
111			*/
112			public function getRules(): array
113			{
114			return $this->rules;
115			}
116
117			/**
118			* @return array
119			*/
120	7		public function getErrors(): array
121			{
122	7		return $this->errors;
123			}
124
125			/**
126			* @return $this
127			*/
128	3		public function required()
129			{
130	3		$this->addRules('required');
131	3		return $this;
132			}
133
134			/**
135			* @return $this
136			*/
137	2		public function validEmail()
138			{
139	2		$this->addRules('valid_email');
140	2		return $this;
141			}
142
143			/**
144			* @param int\|float\|double\|string $match
145			* @return $this
146			*/
147	1		public function equal($match)
148			{
149	1		$this->addRules('equal', [VAR_MATCH => $match]);
150	1		return $this;
151			}
152
153			/**
154			* @param int\|float\|double $limit
155			* @return $this
156			*/
157	1		public function lessThan($limit)
158			{
159	1		$this->addRules('less_than', [VAR_LIMIT => $limit]);
160	1		return $this;
161			}
162
163			/**
164			* @param int\|float\|double $lower
165			* @param int\|float\|double $upper
166			* @return $this
167			*/
168	1		public function between($lower, $upper)
169			{
170	1		$this->addRules('between', [VAR_LOWER_LIMIT => $lower, VAR_UPPER_LIMIT => $upper]);
171	1		return $this;
172			}
173
174			/**
175			* @param string $message
176			* @return $this
177			*/
178	1		public function isTrue(string $message = '')
179			{
180	1		$this->addRules('is_true', [VAR_MESSAGE => $message]);
181	1		return $this;
182			}
183			}

harryosmar / plugin-validation

Push — master ( 289a67...2a2cfd )

Field::lessThan() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like