RuleMapping - Code Metrics - harryosmar/plugin-validation - Measure and Improve Code Quality continuously with Scrutinizer

RuleMapping A
last analyzed 2018-03-08 10:52 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	36
Duplicated Lines	100 %

Coupling/Cohesion

Components	2
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	36
loc	36
ccs	10
cts	10
cp	1
rs	10
c	0
b	0
f	0
wmc	3
lcom	2
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getInstance()	8	8	2
A	getRule()	10	10	1

How to fix Duplicated Code

<?php
/**
 * Created by PhpStorm.
 * User: harry
 * Date: 2/15/18
 * Time: 4:51 PM
 */

namespace PluginSimpleValidate\Libraries;

use PluginSimpleValidate\Contracts\Rule as ContractsRule;
use PluginSimpleValidate\Exception\RuleNotExist;
use PluginSimpleValidate\Rule;

class RuleMapping extends \PluginSimpleValidate\BaseAbstract\RuleMapping implements \PluginSimpleValidate\Contracts\RuleMapping

{
    /**
     * @var $this
     */
    private static $instance;

    /**
     * @return \PluginSimpleValidate\Contracts\RuleMapping
     */
    public static function getInstance()
    {
        if (is_null(static::$instance)) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            static::$instance = new self();
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }

        return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }

    /**
     * @param string $key
     * @param array $args
     * @return ContractsRule
     * @throws RuleNotExist
     */
    public function getRule(string $key, array $args = []): ContractsRule
    {
        $this->checkRule($key);

        return new Rule(
            $this->list[$key]['validation_method'],
            $this->list[$key]['lang_key'],
            $args
        );
    }
}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: harry
5			* Date: 2/15/18
6			* Time: 4:51 PM
7			*/
8
9			namespace PluginSimpleValidate\Libraries;
10
11			use PluginSimpleValidate\Contracts\Rule as ContractsRule;
12			use PluginSimpleValidate\Exception\RuleNotExist;
13			use PluginSimpleValidate\Rule;
14
15		View Code Duplication	class RuleMapping extends \PluginSimpleValidate\BaseAbstract\RuleMapping implements \PluginSimpleValidate\Contracts\RuleMapping
			0 ignored issues – show Duplication introduced 2018-02-26 11:59 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16			{
17			/**
18			* @var $this
19			*/
20			private static $instance;
21
22			/**
23			* @return \PluginSimpleValidate\Contracts\RuleMapping
24			*/
25	13		public static function getInstance()
26			{
27	13		if (is_null(static::$instance)) {
			0 ignored issues – show Bug introduced 2018-02-26 11:59 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
28	1		static::$instance = new self();
			0 ignored issues – show Bug introduced 2018-02-26 11:59 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
29			}
30
31	13		return static::$instance;
			0 ignored issues – show Bug introduced 2018-02-26 11:59 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
32			}
33
34			/**
35			* @param string $key
36			* @param array $args
37			* @return ContractsRule
38			* @throws RuleNotExist
39			*/
40	13		public function getRule(string $key, array $args = []): ContractsRule
41			{
42	13		$this->checkRule($key);
43
44	13		return new Rule(
45	13		$this->list[$key]['validation_method'],
46	13		$this->list[$key]['lang_key'],
47	13		$args
48			);
49			}
50			}

harryosmar / plugin-validation

RuleMapping A last analyzed 2018-03-08 10:52 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

RuleMapping A
last analyzed 2018-03-08 10:52 UTC