Harentius\BlogBundle\Sidebar\Tags

Complexity

Total Complexity

6

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getList()	0	26	5

<?php

namespace Harentius\BlogBundle\Sidebar;

use Harentius\BlogBundle\Entity\TagRepository;

class Tags
{
    /**
     * @var TagRepository
     */
    private $tagRepository;

    /**
     * @var int
     */
    private $sidebarTagsLimit;

    /**
     * @var array
     */
    private $sidebarTagSizes;

    /**
     * @param TagRepository $tagRepository
     * @param int $sidebarTagsLimit
     * @param array $sidebarTagSizes
     */
    public function __construct(TagRepository $tagRepository, int $sidebarTagsLimit, array $sidebarTagSizes)
    {
        $this->tagRepository = $tagRepository;
        $this->sidebarTagsLimit = $sidebarTagsLimit;
        $this->sidebarTagSizes = $sidebarTagSizes;
    }

    /**
     * @return array
     */
    public function getList()
    {
        $tags = $this->tagRepository->findMostPopularLimited($this->sidebarTagsLimit);

        if (!$tags) {

The expression $tags of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $tags;
        }

        $maxWeight = $tags[0]['weight'];

        foreach ($tags as $key => $tag) {
            $percentage = 100;
            $minDiff = 1;

            foreach ($this->sidebarTagSizes as $tagPercent) {
                if (($diff = abs($tag['weight'] / $maxWeight - $tagPercent / 100)) < $minDiff) {
                    $minDiff = $diff;
                    $percentage = $tagPercent;
                }
            }

            $tags[$key]['percentage'] = $percentage;
        }

        return $tags;
    }
}