hansott / pinterest-php

src/Pinterest/Http/BuzzClient.php

<?php

/*
 * This file is part of the Pinterest PHP library.
 *
 * (c) Hans Ott <hansott@hotmail.be>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.md.
 *
 * Source: https://github.com/hansott/pinterest-php
 */

namespace Pinterest\Http;

use Exception;
use Buzz\Browser;
use Pinterest\Image;
use Buzz\Client\Curl;
use Buzz\Message\Form\FormUpload;
use Buzz\Message\Form\FormRequest;
use Buzz\Exception\RequestException;
use Buzz\Message\Response as BuzzResponse;

/**
 * The implemented http client class (uses Buzz).
 *
 * @link https://github.com/kriswallsmith/Buzz
 *
 * @author Toon Daelman <spinnewebber_toon@hotmail.com>
 */
class BuzzClient implements ClientInterface
{
    /**
     * Buzz browser.
     *
     * @var Browser
     */
    private $client;

    /**
     * Creates a new buzz client.
     *
     * @param \Buzz\Client\ClientInterface|null $client
     */
    public function __construct(\Buzz\Client\ClientInterface $client = null)
    {
        if ($client instanceof ClientInterface) {
            $this->client = $client;
        } else {
            // Backwards compatible
            $curl = new Curl();
            $this->client = new Browser($curl);
        }
    }

    /**
     * Converts a buzz response to a pinterest response.
     *
     * @param Request      $request      The request.
     * @param BuzzResponse $buzzResponse The buzz response.
     *
     * @return Response The response.
     */
    private static function convertResponse(Request $request, BuzzResponse $buzzResponse)
    {
        $statusCode = $buzzResponse->getStatusCode();
        $rawBody = (string) $buzzResponse->getContent();

        $rawHeaders = $buzzResponse->getHeaders();
        $headers = array();
        foreach ($rawHeaders as $header) {
            if (stristr($header, 'HTTP/1.')) {
                continue;
            }

            $parts = explode(': ', $header);

            if (count($parts) !== 2) {
                $headers[$parts[0]] = '';
                continue;
            }

            list ($key, $value) = $parts;
            $headers[$key] = $value;
        }

        return new Response($request, $statusCode, $rawBody, $headers);
    }

    /**
     * Executes a http request.
     *
     * @param Request $request The http request.
     *
     * @return Response The http response.
     */
    public function execute(Request $request)
    {
        $method = $request->getMethod();
        $endpoint = $request->getEndpoint();
        $params = $request->getParams();
        $headers = $request->getHeaders();

        try {
            if ($method === 'GET') {
                $buzzResponse = $this->client->call(
                    $endpoint.'?'.http_build_query($params),
                    $method,
                    $headers,
                    array()

array() is of type array, but the function expects a string.

                );
            } else {
                $buzzRequest = new FormRequest();
                $buzzRequest->fromUrl($endpoint);
                $buzzRequest->setMethod($method);
                $buzzRequest->setHeaders($headers);
                foreach ($params as $key => $value) {
                    if ($value instanceof Image) {
                        $value = new FormUpload($value->getData());
                    }

                    $buzzRequest->setField($key, $value);
                }

                $buzzResponse = new BuzzResponse();
                $this->client->send($buzzRequest, $buzzResponse);
            }
        } catch (RequestException $e) {
            throw new Exception($e->getMessage());
        }

        return static::convertResponse($request, $buzzResponse);

Since convertResponse() is declared private, calling it with static will lead to errors in possible sub-classes. You can either use self, or increase the visibility of convertResponse() to at least protected.

$buzzResponse of type object<Buzz\Message\MessageInterface> is not a sub-type of object<Buzz\Message\Response>. It seems like you assume a concrete implementation of the interface Buzz\Message\MessageInterface to be always present.

    }
}