BuzzClient::convertResponse() - Code Metrics - Inspection of "master" - hansott/pinterest-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cd19bd...72a072 )

by Hans

created 2017-12-20 09:12 UTC

BuzzClient::convertResponse() B

↳ Parent: BuzzClient

Complexity

Conditions	4
Paths	4

Size

Total Lines	25
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	25
ccs	0
cts	16
cp	0
rs	8.5806
cc	4
eloc	15
nc	4
nop	2
crap	20

<?php

/*
 * This file is part of the Pinterest PHP library.
 *
 * (c) Hans Ott <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.md.
 *
 * Source: https://github.com/hansott/pinterest-php
 */

namespace Pinterest\Http;

use Exception;
use Buzz\Browser;
use Pinterest\Image;
use Buzz\Client\Curl;
use Buzz\Message\Form\FormUpload;
use Buzz\Message\Form\FormRequest;
use Buzz\Exception\RequestException;
use Buzz\Message\Response as BuzzResponse;

/**
 * The implemented http client class (uses Buzz).
 *
 * @link https://github.com/kriswallsmith/Buzz
 *
 * @author Toon Daelman <[email protected]>
 */
class BuzzClient implements ClientInterface
{
    /**
     * Buzz browser.
     *
     * @var Buzz\Browser
     */
    private $client;

    /**
     * Creates a new buzz client.
     */
    public function __construct()
    {
        $curl = new Curl();
        $this->client = new Browser($curl);

    }

    /**
     * Converts a buzz response to a pinterest response.
     *
     * @param Request      $request      The request.
     * @param BuzzResponse $buzzResponse The buzz response.
     *
     * @return Response The response.
     */
    private static function convertResponse(Request $request, BuzzResponse $buzzResponse)
    {
        $statusCode = $buzzResponse->getStatusCode();
        $rawBody = (string) $buzzResponse->getContent();

        $rawHeaders = $buzzResponse->getHeaders();
        $headers = array();
        foreach ($rawHeaders as $header) {
            if (stristr($header, 'HTTP/1.')) {
                continue;
            }

            $parts = explode(': ', $header);

            if (count($parts) !== 2) {
                $headers[$parts[0]] = '';
                continue;
            }

            list ($key, $value) = $parts;
            $headers[$key] = $value;
        }

        return new Response($request, $statusCode, $rawBody, $headers);
    }

    /**
     * Executes a http request.
     *
     * @param Request $request The http request.
     *
     * @return Response The http response.
     */
    public function execute(Request $request)
    {
        $method = $request->getMethod();
        $endpoint = $request->getEndpoint();
        $params = $request->getParams();
        $headers = $request->getHeaders();

        try {
            if ($method === 'GET') {
                $buzzResponse = $this->client->call(
                    $endpoint.'?'.http_build_query($params),
                    $method,
                    $headers,
                    array()
                );
            } else {
                $buzzRequest = new FormRequest();
                $buzzRequest->fromUrl($endpoint);
                $buzzRequest->setMethod($method);
                $buzzRequest->setHeaders($headers);
                foreach ($params as $key => $value) {
                    if ($value instanceof Image) {
                        $value = new FormUpload($value->getData());
                    }

                    $buzzRequest->setField($key, $value);
                }

                $buzzResponse = new BuzzResponse();
                $this->client->send($buzzRequest, $buzzResponse);
            }
        } catch (RequestException $e) {
            throw new Exception($e->getMessage());
        }

        return static::convertResponse($request, $buzzResponse);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
    }
}


1		<?php
2
3		/*
4		* This file is part of the Pinterest PHP library.
5		*
6		* (c) Hans Ott <[email protected]>
7		*
8		* This source file is subject to the MIT license that is bundled
9		* with this source code in the file LICENSE.md.
10		*
11		* Source: https://github.com/hansott/pinterest-php
12		*/
13
14		namespace Pinterest\Http;
15
16		use Exception;
17		use Buzz\Browser;
18		use Pinterest\Image;
19		use Buzz\Client\Curl;
20		use Buzz\Message\Form\FormUpload;
21		use Buzz\Message\Form\FormRequest;
22		use Buzz\Exception\RequestException;
23		use Buzz\Message\Response as BuzzResponse;
24
25		/**
26		* The implemented http client class (uses Buzz).
27		*
28		* @link https://github.com/kriswallsmith/Buzz
29		*
30		* @author Toon Daelman <[email protected]>
31		*/
32		class BuzzClient implements ClientInterface
33		{
34		/**
35		* Buzz browser.
36		*
37		* @var Buzz\Browser
38		*/
39		private $client;
40
41		/**
42		* Creates a new buzz client.
43		*/
44	42	public function __construct()
45		{
46	42	$curl = new Curl();
47	42	$this->client = new Browser($curl);
		0 ignored issues – show Documentation Bug introduced 2016-01-16 17:08 UTC by Report Bug Copy Issue Report It seems like `new \Buzz\Browser($curl)` of type `object<Buzz\Browser>` is incompatible with the declared type `object<Pinterest\Http\Buzz\Browser>` of property `$client`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
48	42	}
49
50		/**
51		* Converts a buzz response to a pinterest response.
52		*
53		* @param Request $request The request.
54		* @param BuzzResponse $buzzResponse The buzz response.
55		*
56		* @return Response The response.
57		*/
58		private static function convertResponse(Request $request, BuzzResponse $buzzResponse)
59		{
60		$statusCode = $buzzResponse->getStatusCode();
61		$rawBody = (string) $buzzResponse->getContent();
62
63		$rawHeaders = $buzzResponse->getHeaders();
64		$headers = array();
65		foreach ($rawHeaders as $header) {
66		if (stristr($header, 'HTTP/1.')) {
67		continue;
68		}
69
70		$parts = explode(': ', $header);
71
72		if (count($parts) !== 2) {
73		$headers[$parts[0]] = '';
74		continue;
75		}
76
77		list ($key, $value) = $parts;
78		$headers[$key] = $value;
79		}
80
81		return new Response($request, $statusCode, $rawBody, $headers);
82		}
83
84		/**
85		* Executes a http request.
86		*
87		* @param Request $request The http request.
88		*
89		* @return Response The http response.
90		*/
91		public function execute(Request $request)
92		{
93		$method = $request->getMethod();
94		$endpoint = $request->getEndpoint();
95		$params = $request->getParams();
96		$headers = $request->getHeaders();
97
98		try {
99		if ($method === 'GET') {
100		$buzzResponse = $this->client->call(
101		$endpoint.'?'.http_build_query($params),
102		$method,
103		$headers,
104		array()
105		);
106		} else {
107		$buzzRequest = new FormRequest();
108		$buzzRequest->fromUrl($endpoint);
109		$buzzRequest->setMethod($method);
110		$buzzRequest->setHeaders($headers);
111		foreach ($params as $key => $value) {
112		if ($value instanceof Image) {
113		$value = new FormUpload($value->getData());
114		}
115
116		$buzzRequest->setField($key, $value);
117		}
118
119		$buzzResponse = new BuzzResponse();
120		$this->client->send($buzzRequest, $buzzResponse);
121		}
122		} catch (RequestException $e) {
123		throw new Exception($e->getMessage());
124		}
125
126		return static::convertResponse($request, $buzzResponse);
		0 ignored issues – show Bug introduced 2016-01-16 17:08 UTC by Report Bug Copy Issue Report Since `convertResponse()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `convertResponse()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
127		}
128		}
129

hansott / pinterest-php

Push — master ( cd19bd...72a072 )

BuzzClient::convertResponse() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like