HansOtt\Lastify\Services\LastFm

Complexity

Total Complexity

15

Size/Duplication

Total Lines	93
Duplicated Lines	41.94 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	connect()	0	6	1
A	fetchTopTracks()	15	15	3
A	convertToTrackCollection()	0	10	1
A	convertToTrack()	0	6	1
A	assertValidUsername()	9	9	3
A	getTopTracks()	0	8	1
A	getLovedTracks()	0	7	1
A	fetchLovedTracks()	15	15	3

<?php

namespace HansOtt\Lastify\Services;

use Dandelionmood\LastFm\LastFm as LastFmWrapper;
use HansOtt\Lastify\TrackInfo;
use HansOtt\Lastify\TrackCollection;
use HansOtt\Lastify\TrackInfo\Artist;
use InvalidArgumentException;

final class LastFm
{
    private $api;

    public function __construct(LastFmWrapper $api)
    {
        $this->api = $api;
    }

    public static function connect($apiKey)
    {
        $api = new LastFmWrapper($apiKey);

        return new static($api);
    }

    private function fetchTopTracks($username, $limit)

This method seems to be duplicated in your project.

    {
        $params = [
            'user' => $username,
            'limit' => $limit,
        ];

        $response = $this->api->user_getTopTracks($params);

        $topTracks = isset($response->toptracks) && is_array($response->toptracks->track)
            ? $response->toptracks->track
            : [];

        return $topTracks;
    }

    private static function convertToTrackCollection(array $tracks)
    {
        $convertTrack = function ($track) {
            return static::convertToTrack($track);

Since HansOtt\Lastify\Services\LastFm is declared final, using late-static binding will have no effect. You might want to replace static with self instead.

        };

        $tracks = array_map($convertTrack, $tracks);

        return new TrackCollection($tracks);
    }

    private static function convertToTrack($track)
    {
        $artist = new Artist($track->artist->name);

        return new TrackInfo($track->name, [$artist]);
    }

    private function assertValidUsername($username)

This method seems to be duplicated in your project.

    {
        if (!is_string($username)) {
            throw new InvalidArgumentException('The username should be a string, instead got:' . gettype($username));
        }
        if (empty($username)) {
            throw new InvalidArgumentException('The username cannot be empty');
        }
    }

    public function getTopTracks($username, $limit = 50)
    {
        $this->assertValidUsername($username);
        $topTracks = $this->fetchTopTracks($username, $limit);
        $topTracks = static::convertToTrackCollection($topTracks);

Since HansOtt\Lastify\Services\LastFm is declared final, using late-static binding will have no effect. You might want to replace static with self instead.

        return $topTracks;
    }

    public function getLovedTracks($username, $limit = 50)
    {
        $lovedTracks = $this->fetchLovedTracks($username, $limit);
        $lovedTracks = static::convertToTrackCollection($lovedTracks);

Since HansOtt\Lastify\Services\LastFm is declared final, using late-static binding will have no effect. You might want to replace static with self instead.

        return $lovedTracks;
    }

    private function fetchLovedTracks($username, $limit)

This method seems to be duplicated in your project.

    {
        $params = [
            'user' => $username,
            'limit' => $limit,
        ];

        $response = $this->api->user_getLovedTracks($params);

        $lovedTracks = isset($response->lovedtracks) && is_array($response->lovedtracks->track)
            ? $response->lovedtracks->track
            : [];

        return $lovedTracks;
    }
}