Token::getNames() - Code Metrics - hansott/graphql-language - Measure and Improve Code Quality continuously with Scrutinizer

Token::getNames() A
last analyzed 2017-12-14 14:18 UTC

↳ Parent: Token

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	9
cts	9
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	0
crap	2

<?php

namespace HansOtt\GraphQL\Shared;

use ReflectionClass;

abstract class Token
{
    public $type;
    public $value;
    public $location;

    final public function __construct($type, $value, Location $location)
    {
        $this->type = (int) $type;
        $this->value = (string) $value;
        $this->location = $location;
    }

    final private static function getNames()
    {
        static $typeToName;

        if (is_array($typeToName)) {
            return $typeToName;
        }

        $tokenClassName = get_called_class();
        $reflection = new ReflectionClass($tokenClassName);
        $constants = $reflection->getConstants();
        $typeToName = array_flip($constants);

        return $typeToName;
    }

    final public static function getNameFor($type)
    {
        $typeToName = static::getNames();
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}

        return $typeToName[$type];
    }

    final public function getName()
    {
        return static::getNameFor($this->type);
    }
}


1		<?php
2
3		namespace HansOtt\GraphQL\Shared;
4
5		use ReflectionClass;
6
7		abstract class Token
8		{
9		public $type;
10		public $value;
11		public $location;
12
13	81	final public function __construct($type, $value, Location $location)
14		{
15	81	$this->type = (int) $type;
16	81	$this->value = (string) $value;
17	81	$this->location = $location;
18	81	}
19
20	15	final private static function getNames()
21		{
22	15	static $typeToName;
23
24	15	if (is_array($typeToName)) {
25	15	return $typeToName;
26		}
27
28	6	$tokenClassName = get_called_class();
29	6	$reflection = new ReflectionClass($tokenClassName);
30	6	$constants = $reflection->getConstants();
31	6	$typeToName = array_flip($constants);
32
33	6	return $typeToName;
34		}
35
36	15	final public static function getNameFor($type)
37		{
38	15	$typeToName = static::getNames();
		0 ignored issues – show Bug introduced 2017-09-23 18:42 UTC by Report Bug Copy Issue Report Since `getNames()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `getNames()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
39
40	15	return $typeToName[$type];
41		}
42
43	15	final public function getName()
44		{
45	15	return static::getNameFor($this->type);
46		}
47		}
48

hansott / graphql-language

Token::getNames() A last analyzed 2017-12-14 14:18 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Token::getNames() A
last analyzed 2017-12-14 14:18 UTC