ExceptionMiddleware::__invoke() - Code Metrics - Inspection of "Beefed out the testing suite" - hannesvdvreken/guzzle-debugbar - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (1ed855)

by Hannes

created 2015-11-25 14:45 UTC

ExceptionMiddleware::__invoke() A

↳ Parent: ExceptionMiddleware

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
ccs	8
cts	8
cp	1
rs	9.4286
cc	1
eloc	8
nc	1
nop	1
crap	1

<?php
namespace GuzzleHttp\Profiling\Debugbar;

use DebugBar\DataCollector\ExceptionsCollector;
use GuzzleHttp\Exception\GuzzleException;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

class ExceptionMiddleware
{
    /**
     * @var \DebugBar\DataCollector\ExceptionsCollector
     */
    private $collector;

    /**
     * ExceptionMiddleware constructor.
     *
     * @param \DebugBar\DataCollector\ExceptionsCollector $collector
     */
    public function __construct(ExceptionsCollector $collector)
    {
        $this->collector = $collector;
    }

    /**
     * @param callable $handler
     *
     * @return callable
     */
    public function __invoke(callable $handler)
    {
        return function (RequestInterface $request, array $options) use ($handler) {
            return $handler($request, $options)
                ->then(function (ResponseInterface $response) {
                    return $response;
                }, function (GuzzleException $exception) {
                    $this->collector->addException($exception);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

                    throw $exception;
                });
        };
    }
}


1		<?php
2		namespace GuzzleHttp\Profiling\Debugbar;
3
4		use DebugBar\DataCollector\ExceptionsCollector;
5		use GuzzleHttp\Exception\GuzzleException;
6		use Psr\Http\Message\RequestInterface;
7		use Psr\Http\Message\ResponseInterface;
8
9		class ExceptionMiddleware
10		{
11		/**
12		* @var \DebugBar\DataCollector\ExceptionsCollector
13		*/
14		private $collector;
15
16		/**
17		* ExceptionMiddleware constructor.
18		*
19		* @param \DebugBar\DataCollector\ExceptionsCollector $collector
20		*/
21	3	public function __construct(ExceptionsCollector $collector)
22		{
23	3	$this->collector = $collector;
24	3	}
25
26		/**
27		* @param callable $handler
28		*
29		* @return callable
30		*/
31	3	public function __invoke(callable $handler)
32		{
33		return function (RequestInterface $request, array $options) use ($handler) {
34	2	return $handler($request, $options)
35		->then(function (ResponseInterface $response) {
36	1	return $response;
37	2	}, function (GuzzleException $exception) {
38	1	$this->collector->addException($exception);
		0 ignored issues – show Documentation introduced 2015-11-25 14:12 UTC by Report Bug Copy Issue Report `$exception` is of type `object<GuzzleHttp\Exception\GuzzleException>`, but the function expects a `object<Exception>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39
40	1	throw $exception;
41	2	});
42	3	};
43		}
44		}
45

hannesvdvreken / guzzle-debugbar

Branch — master (1ed855)

ExceptionMiddleware::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like