hanneskod / readme-tester

src/Attribute/AbstractAttribute.php

<?php

declare(strict_types=1);

namespace hanneskod\readmetester\Attribute;

abstract class AbstractAttribute implements AttributeInterface
{
    public function asAttribute(): string
    {
        return self::createAttribute();
    }

    public static function createAttribute(string ...$args): string
    {
        $arglist = '';

        if ($args) {

The expression $args of type array<integer,string> is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $arglist = sprintf(
                '("%s")',
                implode(
                    '", "',
                    array_map(
                        fn(string $arg) => addslashes(trim($arg)),
                        array_filter($args)
                    )
                )
            );
        }

        return '#[\\' . get_called_class() . $arglist . ']';
    }
}