Conditions | 10 |
Paths | 40 |
Total Lines | 50 |
Code Lines | 26 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
30 | public function createExamples(array $defenitions): array |
||
31 | { |
||
32 | $examples = []; |
||
33 | $context = null; |
||
34 | |||
35 | foreach ($defenitions as $index => $def) { |
||
36 | if ($def->isAnnotatedWith('ignore')) { |
||
37 | continue; |
||
38 | } |
||
39 | |||
40 | $name = (string)($index + 1); |
||
41 | |||
42 | if ($def->isAnnotatedWith('example')) { |
||
43 | $name = $def->getAnnotation('example')->getArgument(); |
||
44 | } |
||
45 | |||
46 | if (isset($examples[$name])) { |
||
47 | throw new \RuntimeException("Example '$name' already exists in definition ".($index + 1)); |
||
48 | } |
||
49 | |||
50 | if ($context) { |
||
51 | $def->getCodeBlock()->prepend($context); |
||
52 | } |
||
53 | |||
54 | if ($def->isAnnotatedWith('extends')) { |
||
55 | $extends = $def->getAnnotation('extends')->getArgument(); |
||
56 | if (!isset($examples[$extends])) { |
||
57 | throw new \RuntimeException( |
||
58 | "Example '$extends' does not exist and can not be extended in definition ".($index + 1) |
||
59 | ); |
||
60 | } |
||
61 | |||
62 | $def->getCodeBlock()->prepend($examples[$extends]->getCodeBlock()); |
||
63 | } |
||
64 | |||
65 | $expectations = $this->createExpectations($def); |
||
66 | |||
67 | if (empty($expectations)) { |
||
68 | $expectations[] = $this->expectationFactory->createExpectation(new Annotation('expectNothing')); |
||
69 | } |
||
70 | |||
71 | $examples[$name] = new Example($name, $def->getCodeBlock(), $expectations); |
||
72 | |||
73 | if ($def->isAnnotatedWith('exampleContext')) { |
||
74 | $context = $def->getCodeBlock(); |
||
75 | } |
||
76 | } |
||
77 | |||
78 | return $examples; |
||
79 | } |
||
80 | |||
98 |