ExampleFactory::createExamples() - Code Metrics - Inspection of "Parser now returnes Definition objects" - hanneskod/readme-tester - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b7ad07...7762ce )

by Hannes

created 2017-02-20 23:21 UTC

ExampleFactory::createExamples() D

↳ Parent: ExampleFactory

Complexity

Conditions	10
Paths	40

Size

Total Lines	45
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	45
rs	4.8196
c	0
b	0
f	0
cc	10
eloc	23
nc	40
nop	1

How to fix Complexity

<?php

declare(strict_types = 1);

namespace hanneskod\readmetester;

use hanneskod\readmetester\Expectation\ExpectationFactory;

/**
 * Create examples from definitions created by Parser
 */
class ExampleFactory
{
    /**
     * @var ExpectationFactory
     */
    private $expectationFactory;

    public function __construct(ExpectationFactory $expectationFactory = null)
    {
        $this->expectationFactory = $expectationFactory ?: new ExpectationFactory;
    }

    /**
     * Create examples from definitions
     *
     * @param  Definition[] $defenitions Example definitions as created by Parser
     * @return Example[]
     */
    public function createExamples(array $defenitions): array
    {
        $examples = [];
        $context = null;

        foreach ($defenitions as $index => $def) {
            if ($def->isAnnotatedWith('ignore')) {
                continue;
            }

            $name = $def->readAnnotation('example') ?: (string)($index + 1);

            if (isset($examples[$name])) {
                throw new \RuntimeException("Example '$name' already exists in definition ".($index + 1));
            }

            if ($context) {
                $def->getCodeBlock()->prepend($context);
            }

            if ($extends = $def->readAnnotation('extends')) {
                if (!isset($examples[$extends])) {
                    throw new \RuntimeException(
                        "Example '$extends' does not exist and can not be extended in definition ".($index + 1)
                    );
                }

                $def->getCodeBlock()->prepend($examples[$extends]->getCodeBlock());
            }

            $expectations = $this->createExpectations($def);

            if (empty($expectations)) {
                $expectations[] = $this->expectationFactory->createExpectation('expectnothing', []);
            }

            $examples[$name] = new Example($name, $def->getCodeBlock(), $expectations);

            if ($def->isAnnotatedWith('exampleContext')) {
                $context = $def->getCodeBlock();
            }
        }

        return $examples;
    }

    /**
     * Create expectation from definition data
     *
     * @return Expectation\ExpectationInterface[]
     */
    private function createExpectations(Definition $def): array
    {
        $expectations = [];

        foreach ($def->getAnnotations() as list($name, $args)) {
            $expectations[] = $this->expectationFactory->createExpectation($name, $args);
        }

        return array_filter($expectations);
    }
}


1			<?php
2
3			declare(strict_types = 1);
4
5			namespace hanneskod\readmetester;
6
7			use hanneskod\readmetester\Expectation\ExpectationFactory;
8
9			/**
10			* Create examples from definitions created by Parser
11			*/
12			class ExampleFactory
13			{
14			/**
15			* @var ExpectationFactory
16			*/
17			private $expectationFactory;
18
19			public function __construct(ExpectationFactory $expectationFactory = null)
20			{
21			$this->expectationFactory = $expectationFactory ?: new ExpectationFactory;
22			}
23
24			/**
25			* Create examples from definitions
26			*
27			* @param Definition[] $defenitions Example definitions as created by Parser
28			* @return Example[]
29			*/
30			public function createExamples(array $defenitions): array
31			{
32			$examples = [];
33			$context = null;
34
35			foreach ($defenitions as $index => $def) {
36			if ($def->isAnnotatedWith('ignore')) {
37			continue;
38			}
39
40			$name = $def->readAnnotation('example') ?: (string)($index + 1);
41
42			if (isset($examples[$name])) {
43			throw new \RuntimeException("Example '$name' already exists in definition ".($index + 1));
44			}
45
46			if ($context) {
47			$def->getCodeBlock()->prepend($context);
48			}
49
50			if ($extends = $def->readAnnotation('extends')) {
51			if (!isset($examples[$extends])) {
52			throw new \RuntimeException(
53			"Example '$extends' does not exist and can not be extended in definition ".($index + 1)
54			);
55			}
56
57			$def->getCodeBlock()->prepend($examples[$extends]->getCodeBlock());
58			}
59
60			$expectations = $this->createExpectations($def);
61
62			if (empty($expectations)) {
63			$expectations[] = $this->expectationFactory->createExpectation('expectnothing', []);
64			}
65
66			$examples[$name] = new Example($name, $def->getCodeBlock(), $expectations);
67
68			if ($def->isAnnotatedWith('exampleContext')) {
69			$context = $def->getCodeBlock();
70			}
71			}
72
73			return $examples;
74			}
75
76			/**
77			* Create expectation from definition data
78			*
79			* @return Expectation\ExpectationInterface[]
80			*/
81			private function createExpectations(Definition $def): array
82			{
83			$expectations = [];
84
85			foreach ($def->getAnnotations() as list($name, $args)) {
86			$expectations[] = $this->expectationFactory->createExpectation($name, $args);
87			}
88
89			return array_filter($expectations);
90			}
91			}
92

hanneskod / readme-tester

Push — master ( b7ad07...7762ce )

ExampleFactory::createExamples() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like