Fpdi2Driver - Code Metrics - Inspection of "Merge pull request #31 from hanneskod/4.0" - hanneskod/libmergepdf - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4dc0e8...439184 )

by Hannes

created 2018-11-12 09:26 UTC

Fpdi2Driver A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	58.33 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	28
loc	48
rs	10
c	0
b	0
f	0
wmc	10
lcom	1
cbo	5

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	4
B	merge()	28	28	6

How to fix Duplicated Code

<?php

declare(strict_types = 1);

namespace iio\libmergepdf\Driver;

use iio\libmergepdf\Exception;
use iio\libmergepdf\Source\SourceInterface;
use setasign\Fpdi\Fpdi as FpdiFpdf;
use setasign\Fpdi\Tcpdf\Fpdi as FpdiTcpdf;
use setasign\Fpdi\PdfParser\StreamReader;

final class Fpdi2Driver implements DriverInterface
{
    /**
     * @var FpdiFpdf|FpdiTcpdf
     */
    private $fpdi;

    /**
     * @param FpdiFpdf|FpdiTcpdf $fpdi
     */
    public function __construct($fpdi = null)
    {
        $this->fpdi = $fpdi ?: new FpdiTcpdf;

        if (!($this->fpdi instanceof FpdiFpdf) && !($this->fpdi instanceof FpdiTcpdf)) {
            throw new \InvalidArgumentException('Constructor argument must be an FPDI instance.');
        }
    }

    public function merge(SourceInterface ...$sources): string

    {
        $sourceName = '';

        try {
            $fpdi = clone $this->fpdi;

            foreach ($sources as $source) {
                $sourceName = $source->getName();
                $pageCount = $fpdi->setSourceFile(StreamReader::createByString($source->getContents()));
                $pageNumbers = $source->getPages()->getPageNumbers() ?: range(1, $pageCount);

                foreach ($pageNumbers as $pageNr) {
                    $template = $fpdi->importPage($pageNr);
                    $size = $fpdi->getTemplateSize($template);
                    $fpdi->AddPage(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                        $size['width'] > $size['height'] ? 'L' : 'P',
                        [$size['width'], $size['height']]
                    );
                    $fpdi->useTemplate($template);
                }
            }

            return $fpdi->Output('', 'S');
        } catch (\Exception $e) {
            throw new Exception("'{$e->getMessage()}' in '$sourceName'", 0, $e);
        }
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace iio\libmergepdf\Driver;
6
7		use iio\libmergepdf\Exception;
8		use iio\libmergepdf\Source\SourceInterface;
9		use setasign\Fpdi\Fpdi as FpdiFpdf;
10		use setasign\Fpdi\Tcpdf\Fpdi as FpdiTcpdf;
11		use setasign\Fpdi\PdfParser\StreamReader;
12
13		final class Fpdi2Driver implements DriverInterface
14		{
15		/**
16		* @var FpdiFpdf\|FpdiTcpdf
17		*/
18		private $fpdi;
19
20		/**
21		* @param FpdiFpdf\|FpdiTcpdf $fpdi
22		*/
23		public function __construct($fpdi = null)
24		{
25		$this->fpdi = $fpdi ?: new FpdiTcpdf;
26
27		if (!($this->fpdi instanceof FpdiFpdf) && !($this->fpdi instanceof FpdiTcpdf)) {
28		throw new \InvalidArgumentException('Constructor argument must be an FPDI instance.');
29		}
30		}
31
32	View Code Duplication	public function merge(SourceInterface ...$sources): string
		0 ignored issues – show Duplication introduced 2018-11-11 14:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		$sourceName = '';
35
36		try {
37		$fpdi = clone $this->fpdi;
38
39		foreach ($sources as $source) {
40		$sourceName = $source->getName();
41		$pageCount = $fpdi->setSourceFile(StreamReader::createByString($source->getContents()));
42		$pageNumbers = $source->getPages()->getPageNumbers() ?: range(1, $pageCount);
43
44		foreach ($pageNumbers as $pageNr) {
45		$template = $fpdi->importPage($pageNr);
46		$size = $fpdi->getTemplateSize($template);
47		$fpdi->AddPage(
		0 ignored issues – show Bug introduced 2018-11-11 14:11 UTC by Report Bug Copy Issue Report The method `AddPage` does only exist in `setasign\Fpdi\Fpdi`, but not in `setasign\Fpdi\Tcpdf\Fpdi`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
48		$size['width'] > $size['height'] ? 'L' : 'P',
49		[$size['width'], $size['height']]
50		);
51		$fpdi->useTemplate($template);
52		}
53		}
54
55		return $fpdi->Output('', 'S');
56		} catch (\Exception $e) {
57		throw new Exception("'{$e->getMessage()}' in '$sourceName'", 0, $e);
58		}
59		}
60		}
61

hanneskod / libmergepdf

Push — master ( 4dc0e8...439184 )

Fpdi2Driver A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like