ModelHistory::logChanges() - Code Metrics - hamidrezaniazi/laramist - Measure and Improve Code Quality continuously with Scrutinizer

ModelHistory::logChanges() A
last analyzed 2020-09-10 19:30 UTC

↳ Parent: ModelHistory

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

namespace Hamidrezaniazi\Laramist\Models;

use Hamidrezaniazi\Laramist\Guard;
use Illuminate\Contracts\Auth\Authenticatable as User;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
use Illuminate\Database\Eloquent\Relations\MorphTo;

class ModelHistory extends Model
{
    protected $guarded = ['id'];
    protected $casts = [
        'changed' => 'array',
    ];

    /**
     * @return MorphTo
     */
    public function subject(): MorphTo
    {
        return $this->morphTo();
    }

    /**
     * @return BelongsTo
     */
    public function causer(): BelongsTo
    {
        return $this->belongsTo(Guard::getGuardClassName(), 'causer_id');
    }

    /**
     * @param Model $subject
     * @param User|null $user
     * @return void
     */
    public static function logChanges(Model $subject, ?User $user): void
    {
        if ($subject->wasChanged()) {
            $changed = $subject->getChanges();
            unset($changed['updated_at']);
            $history = new self();
            $history->subject()->associate($subject);
            $history->causer()->associate($user);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $history->changed = $changed;
            $history->save();
        }
    }
}


1			<?php
2
3			namespace Hamidrezaniazi\Laramist\Models;
4
5			use Hamidrezaniazi\Laramist\Guard;
6			use Illuminate\Contracts\Auth\Authenticatable as User;
7			use Illuminate\Database\Eloquent\Model;
8			use Illuminate\Database\Eloquent\Relations\BelongsTo;
9			use Illuminate\Database\Eloquent\Relations\MorphTo;
10
11			class ModelHistory extends Model
12			{
13			protected $guarded = ['id'];
14			protected $casts = [
15			'changed' => 'array',
16			];
17
18			/**
19			* @return MorphTo
20			*/
21			public function subject(): MorphTo
22			{
23			return $this->morphTo();
24			}
25
26			/**
27			* @return BelongsTo
28			*/
29			public function causer(): BelongsTo
30			{
31			return $this->belongsTo(Guard::getGuardClassName(), 'causer_id');
32			}
33
34			/**
35			* @param Model $subject
36			* @param User\|null $user
37			* @return void
38			*/
39			public static function logChanges(Model $subject, ?User $user): void
40			{
41			if ($subject->wasChanged()) {
42			$changed = $subject->getChanges();
43			unset($changed['updated_at']);
44			$history = new self();
45			$history->subject()->associate($subject);
46			$history->causer()->associate($user);
			0 ignored issues – show Documentation introduced 2019-10-20 08:33 UTC by Report Bug Copy Issue Report `$user` is of type `object<Illuminate\Contra...h\Authenticatable>\|null`, but the function expects a `object<Illuminate\Databa...t\Model>\|integer\|string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
47			$history->changed = $changed;
48			$history->save();
49			}
50			}
51			}
52

hamidrezaniazi / laramist

ModelHistory::logChanges() A last analyzed 2020-09-10 19:30 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ModelHistory::logChanges() A
last analyzed 2020-09-10 19:30 UTC