RequestHelper::getStorageKey() - Code Metrics - Inspection of "Fixes #2" - hamburgscleanest/guzzle-advanced-throttle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ed9e54...fafb16 )

by Timo

created 2018-02-16 00:03 UTC

RequestHelper::getStorageKey() A

↳ Parent: RequestHelper

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	11
ccs	6
cts	6
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

namespace hamburgscleanest\GuzzleAdvancedThrottle\Cache\Helpers;

use Psr\Http\Message\RequestInterface;

/**
 * Class RequestHelper
 * @package hamburgscleanest\GuzzleAdvancedThrottle\Cache\Helpers
 */
class RequestHelper
{

    /**
     * @param RequestInterface $request
     * @return array
     */
    public static function getHostAndPath(RequestInterface $request) : array
    {
        $uri = $request->getUri();

        return [
            $uri->getScheme() . '://' . $uri->getHost(),
            $uri->getPath()
        ];
    }

    /**
     * @param RequestInterface $request
     * @return string
     */
    public static function getStorageKey(RequestInterface $request) : string
    {
        $uri = $request->getUri();
        $method = $request->getMethod();

        if ($method !== 'GET')
        {
            return self::_getMethodAndParams($method, $request->getBody()->getContents());
        }

        return self::_getMethodAndParams($method, $uri->getQuery());
    }

    /**
     * @param string $method
     * @param string $params
     * @return string
     */
    private static function _getMethodAndParams(string $method, string $params) : string
    {
        return $method . '_' . $params;
    }
}

1		<?php
2
3		namespace hamburgscleanest\GuzzleAdvancedThrottle\Cache\Helpers;
4
5		use Psr\Http\Message\RequestInterface;
6
7		/**
8		* Class RequestHelper
9		* @package hamburgscleanest\GuzzleAdvancedThrottle\Cache\Helpers
10		*/
11		class RequestHelper
12		{
13
14		/**
15		* @param RequestInterface $request
16		* @return array
17		*/
18	11	public static function getHostAndPath(RequestInterface $request) : array
19		{
20	11	$uri = $request->getUri();
21
22		return [
23	11	$uri->getScheme() . '://' . $uri->getHost(),
24	11	$uri->getPath()
25		];
26		}
27
28		/**
29		* @param RequestInterface $request
30		* @return string
31		*/
32	12	public static function getStorageKey(RequestInterface $request) : string
33		{
34	12	$uri = $request->getUri();
35	12	$method = $request->getMethod();
36
37	12	if ($method !== 'GET')
38		{
39	2	return self::_getMethodAndParams($method, $request->getBody()->getContents());
40		}
41
42	10	return self::_getMethodAndParams($method, $uri->getQuery());
43		}
44
45		/**
46		* @param string $method
47		* @param string $params
48		* @return string
49		*/
50	12	private static function _getMethodAndParams(string $method, string $params) : string
51		{
52	12	return $method . '_' . $params;
53		}
54		}

hamburgscleanest / guzzle-advanced-throttle

Push — master ( ed9e54...fafb16 )

RequestHelper::getStorageKey() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like