Relation::getValue() - Code Metrics - Inspection of "- improved readability" - hamburgscleanest/data-tables - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 98f154...86f929 )

by Timo

created 2017-04-12 23:26 UTC

Relation::getValue() A

↳ Parent: Relation

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	2
crap	2

<?php

namespace hamburgscleanest\DataTables\Models;

use Illuminate\Support\Collection;


/**
 * Class Relation
 * @package hamburgscleanest\hamburgscleanest\DataTables\Models
 */
class Relation {

    /** @var string */
    public $name;

    /** @var string */
    public $aggregate = 'first';

    /**
     * Relation constructor.
     * @param string $columnName
     * @internal param string $name
     */
    public function __construct(string $columnName)
    {
        $this->name = $this->_extractAggregate($columnName);
    }

    /**
     * @param string $name
     * @return string
     */
    private function _extractAggregate(string $name): string
    {
        $replaced = 0;
        $extractedName = preg_replace('/\((.*?)\)/', '#$1', $name, 1, $replaced);
        if ($replaced !== 0)
        {
            $parts = \explode('#', $extractedName);
            $this->aggregate = \mb_strtolower($parts[0]);

            $extractedName = $parts[1];
        }

        return \mb_substr($extractedName, 0, \mb_strpos($extractedName, '.'));
    }

    /**
     * @param string $columnName
     * @param Collection $relation
     * @return string
     */
    public function getValue(string $columnName, Collection $relation): string
    {
        $aggregateFunctionSet = $this->aggregate !== 'first';
        if ($aggregateFunctionSet)
        {
            return $relation->{$this->aggregate}($columnName);
        }

        return (string) $relation->first()->{$columnName};
    }
}

1		<?php
2
3		namespace hamburgscleanest\DataTables\Models;
4
5		use Illuminate\Support\Collection;
6
7
8		/**
9		* Class Relation
10		* @package hamburgscleanest\hamburgscleanest\DataTables\Models
11		*/
12		class Relation {
13
14		/** @var string */
15		public $name;
16
17		/** @var string */
18		public $aggregate = 'first';
19
20		/**
21		* Relation constructor.
22		* @param string $columnName
23		* @internal param string $name
24		*/
25	4	public function __construct(string $columnName)
26		{
27	4	$this->name = $this->_extractAggregate($columnName);
28	4	}
29
30		/**
31		* @param string $name
32		* @return string
33		*/
34	4	private function _extractAggregate(string $name): string
35		{
36	4	$replaced = 0;
37	4	$extractedName = preg_replace('/\((.*?)\)/', '#$1', $name, 1, $replaced);
38	4	if ($replaced !== 0)
39		{
40	2	$parts = \explode('#', $extractedName);
41	2	$this->aggregate = \mb_strtolower($parts[0]);
42
43	2	$extractedName = $parts[1];
44		}
45
46	4	return \mb_substr($extractedName, 0, \mb_strpos($extractedName, '.'));
47		}
48
49		/**
50		* @param string $columnName
51		* @param Collection $relation
52		* @return string
53		*/
54	2	public function getValue(string $columnName, Collection $relation): string
55		{
56	2	$aggregateFunctionSet = $this->aggregate !== 'first';
57	2	if ($aggregateFunctionSet)
58		{
59	1	return $relation->{$this->aggregate}($columnName);
60		}
61
62	1	return (string) $relation->first()->{$columnName};
63		}
64		}

hamburgscleanest / data-tables

Push — master ( 98f154...86f929 )

Relation::getValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like