hamburgscleanest\DataTables\Helpers\UrlHelper::parameterizeQuery()

Complexity

Conditions	4
Paths	4

Size

Total Lines	21
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	UrlHelper::__construct()	0	4	1

<?php

namespace hamburgscleanest\DataTables\Helpers;

use Illuminate\Http\Request;
use RuntimeException;

/**
 * Class UrlHelper
 * @package hamburgscleanest\DataTables\Helpers
 */
class UrlHelper {

    /** @var Request */
    private $_request;

    /**
     * UrlHelper constructor.
     * @param Request $request
     */
    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->_request = $request;
    }

    /**
     * Array of all the query parameters for the current request.
     *
     * @return array
     * @throws \RuntimeException
     */
    public function queryParameters() : array
    {
        $queryString = $this->_request->getQueryString();

        if (empty($queryString))
        {
            return [];
        }

        $parameters = [];
        foreach (\explode('&', $queryString) as $query)
        {
            $queryParts = \explode('=', $query);
            if (\count($queryParts) !== 2)
            {
                throw new RuntimeException('Malformed query parameters.');
            }

            $parameters[$queryParts[0]] = $queryParts[1];
        }

        return $parameters;
    }
}