Incapsula\Command\SetStaticCacheModeCommand

Complexity

Total Complexity

3

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	8	1
A	initialize()	0	5	1
A	execute()	0	7	1

<?php

namespace Incapsula\Command;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class SetStaticCacheModeCommand extends AbstractCommand
{
    /**
     * @var string
     */
    private $siteId;

    /**
     * @var string
     */
    private $certificatePath;

The private property $certificatePath is not used, and could be removed.

    /**
     * @var string
     */
    private $privateKeyPath;

The private property $privateKeyPath is not used, and could be removed.

    protected function configure()
    {
        parent::configure();

        $this
            ->setName('StaticCacheMode:set')
            ->addArgument('site-id', InputArgument::REQUIRED, 'Site ID')
            ->setDescription('Ensure a site is in static caching header mode')
        ;
    }

    /**
     * @param InputInterface  $input
     * @param OutputInterface $output
     */
    protected function initialize(InputInterface $input, OutputInterface $output)
    {
        parent::initialize($input, $output);

        $this->siteId = $input->getArgument('site-id');

It seems like $input->getArgument('site-id') can also be of type string[]. However, the property $siteId is declared as type string. Maybe add an additional type check?

    }

    /**
     * @param InputInterface  $input
     * @param OutputInterface $output
     *
     * @return int
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $return_val = $this->client->sites()->setStaticCacheMode(
            $this->siteId
        );

        return $return_val;

The expression return $return_val returns the type array which is incompatible with the documented return type integer.

    }
}