halfpastfouram / phpchartjs

src/Renderer/Json.php

<?php

namespace Halfpastfour\PHPChartJS\Renderer;

use Laminas\Json\Json as JsonHelper;

/**
 * Class Json
 *
 * @package Halfpastfour\PHPChartJS\Renderer
 */
class Json extends Renderer
{
    /**
     * Render the necessary JSON for the chart to function in the frontend.
     *
     * @param int|false $flags
     *
     * @return string
     */
    public function render($flags = null)
    {
        $config = [
            'type' => constant(get_class($this->chart) . "::TYPE"),
            'data' => [],
        ];

        $labels = $this->chart->labels()->jsonSerialize();
        if ($labels) {

The expression $labels of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $config['data']['labels'] = $labels;
        }

        $dataSets = $this->chart->dataSets()->jsonSerialize();
        if ($dataSets) {

The expression $dataSets of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $config['data']['datasets'] = $dataSets;
        }

        $options = $this->chart->options()->jsonSerialize();
        if (! empty($options)) {
            $config['options'] = $options;
        }

        $output = JsonHelper::encode($config, false, ['enableJsonExprFinder' => true]);
        if ($flags & Renderer::RENDER_PRETTY) {
            $output = JsonHelper::prettyPrint($output);
        }

        return $output;
    }
}