ArraySerializable::getArrayCopy() - Code Metrics - Inspection of "Improving code quality" - halfpastfouram/phpchartjs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#56)

by halfpastfour

created 2018-09-02 16:57 UTC

ArraySerializable::getArrayCopy() C

↳ Parent: Project

Complexity

Conditions	12
Paths	21

Size

Total Lines	39
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
eloc	19
nc	21
nop	0
dl	0
loc	39
rs	6.9666
c	0
b	0
f	0

How to fix Complexity

<?php

namespace Halfpastfour\PHPChartJS\Delegate;

use Zend\Json\Expr;

/**
 * Class ArraySerializable
 *
 * @package Halfpastfour\PHPChartJS\Model
 */
trait ArraySerializable
{
<<<<<<< HEAD

    /**
     * Will loop through class properties and try and assign their values to an array of data that will be returned.
     *
     * @return array
     * @throws \ReflectionException
     */
    public function getArrayCopy()
    {
        $data            = [];
        $properties      = get_object_vars($this);
        $reflectionClass = new \Zend_Reflection_Class($this);
        foreach ($properties as $property => $value) {
            // Skip property if it is not accessible
            if (! $reflectionClass->hasProperty($property)) {
                continue;
            }

            // Only process properties that aren't null
            if (! is_null($value)) {
                $object = (is_object($value) && ! $this->$property instanceof Expr);

                // Prepend 'get' to the getter method.
                $getter = 'get' . ucfirst($property);
                if (! method_exists($this, $getter)) {
                    // If 'getSomething' doesn't exist, try to use 'isSomething'
                    $getter = 'is' . ucfirst($property);
                }

                // Finally simply use the property
                if (! method_exists($this, $getter)) {
                    $getter = $property;
                }

                // Abort if none of the above methods exit
                if (! method_exists($this, $getter)) {
                    continue;
                }

                // Assign the contents of the property to the data array
                $data[$property] = $object ? $this->$getter()->getArrayCopy() : $this->$getter();
            }
        }

        return $data;
    }
<<<<<<< HEAD
}
=======
	/**
	 * Will loop through class properties and try and assign their values to an array of data that will be returned.
	 *
	 * @return array
	 */
	public function getArrayCopy()
	{
		$data            = [];
		$properties      = get_object_vars( $this );
		$reflectionClass = new \Zend_Reflection_Class( $this );
		foreach( $properties as $property => $value ) {
			// Skip property if it is not accessible
			if( !$reflectionClass->hasProperty( $property ) ) continue;

			// Only process properties that aren't null
			if( !is_null( $value ) ) {
				$object = ( is_object( $value ) && !$this->$property instanceof Expr );

				// Prepend 'get' to the getter method.
				$getter = 'get' . ucfirst( $property );
				if ( !method_exists($this, $getter) ) {
					// If 'getSomething' doesn't exist, try to use 'isSomething'
					$getter = 'is' . ucfirst( $property );
				}
				// Finally simply use the property
				if( !method_exists($this, $getter) ) {
					$getter = $property;
				}

				// Abort if none of the above methods exit
				if( !method_exists( $this, $getter ) ) continue;

				// Assign the contents of the property to the data array
				$data[ $property ] = $object ? $this->$getter()->getArrayCopy() : $this->$getter();
			}
		}

		return $data;
	}
}
>>>>>>> 6d743af... Simplified getArrayCopy method
=======
}
>>>>>>> e69d8b3... Add unit test making sure the ArraySerializable trait is working well.


GitHub Access Token became invalid

Pull Request — master (#56)

ArraySerializable::getArrayCopy() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1			<?php
2
3			namespace Halfpastfour\PHPChartJS\Delegate;
4
5			use Zend\Json\Expr;
6
7			/**
8			* Class ArraySerializable
9			*
10			* @package Halfpastfour\PHPChartJS\Model
11			*/
12			trait ArraySerializable
13			{
14			<<<<<<< HEAD
			0 ignored issues – show Bug introduced 2018-09-02 17:00 UTC by Report Bug Copy Issue Report A parse error occurred: Syntax error, unexpected T_SL, expecting T_FUNCTION or T_CONST on line 14 at column 0 Loading history...
15			/**
16			* Will loop through class properties and try and assign their values to an array of data that will be returned.
17			*
18			* @return array
19			* @throws \ReflectionException
20			*/
21			public function getArrayCopy()
22			{
23			$data = [];
24			$properties = get_object_vars($this);
25			$reflectionClass = new \Zend_Reflection_Class($this);
26			foreach ($properties as $property => $value) {
27			// Skip property if it is not accessible
28			if (! $reflectionClass->hasProperty($property)) {
29			continue;
30			}
31
32			// Only process properties that aren't null
33			if (! is_null($value)) {
34			$object = (is_object($value) && ! $this->$property instanceof Expr);
35
36			// Prepend 'get' to the getter method.
37			$getter = 'get' . ucfirst($property);
38			if (! method_exists($this, $getter)) {
39			// If 'getSomething' doesn't exist, try to use 'isSomething'
40			$getter = 'is' . ucfirst($property);
41			}
42
43			// Finally simply use the property
44			if (! method_exists($this, $getter)) {
45			$getter = $property;
46			}
47
48			// Abort if none of the above methods exit
49			if (! method_exists($this, $getter)) {
50			continue;
51			}
52
53			// Assign the contents of the property to the data array
54			$data[$property] = $object ? $this->$getter()->getArrayCopy() : $this->$getter();
55			}
56			}
57
58			return $data;
59			}
60			<<<<<<< HEAD
61			}
62			=======
63			/**
64			* Will loop through class properties and try and assign their values to an array of data that will be returned.
65			*
66			* @return array
67			*/
68			public function getArrayCopy()
69			{
70			$data = [];
71			$properties = get_object_vars( $this );
72			$reflectionClass = new \Zend_Reflection_Class( $this );
73			foreach( $properties as $property => $value ) {
74			// Skip property if it is not accessible
75			if( !$reflectionClass->hasProperty( $property ) ) continue;
76
77			// Only process properties that aren't null
78			if( !is_null( $value ) ) {
79			$object = ( is_object( $value ) && !$this->$property instanceof Expr );
80
81			// Prepend 'get' to the getter method.
82			$getter = 'get' . ucfirst( $property );
83			if ( !method_exists($this, $getter) ) {
84			// If 'getSomething' doesn't exist, try to use 'isSomething'
85			$getter = 'is' . ucfirst( $property );
86			}
87			// Finally simply use the property
88			if( !method_exists($this, $getter) ) {
89			$getter = $property;
90			}
91
92			// Abort if none of the above methods exit
93			if( !method_exists( $this, $getter ) ) continue;
94
95			// Assign the contents of the property to the data array
96			$data[ $property ] = $object ? $this->$getter()->getArrayCopy() : $this->$getter();
97			}
98			}
99
100			return $data;
101			}
102			}
103			>>>>>>> 6d743af... Simplified getArrayCopy method
104			=======
105			}
106			>>>>>>> e69d8b3... Add unit test making sure the ArraySerializable trait is working well.
107

halfpastfouram / phpchartjs

GitHub Access Token became invalid

Pull Request — master (#56)

ArraySerializable::getArrayCopy() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like