Total Complexity | 50 |
Total Lines | 585 |
Duplicated Lines | 0 % |
Changes | 3 | ||
Bugs | 0 | Features | 0 |
Complex classes like Scale often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Scale, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
17 | abstract class Scale implements ArraySerializableInterface, JsonSerializable |
||
18 | { |
||
19 | use ArraySerializable; |
||
20 | |||
21 | /** |
||
22 | * @var string |
||
23 | */ |
||
24 | protected $type; |
||
25 | |||
26 | /** |
||
27 | * @var bool |
||
28 | */ |
||
29 | protected $display; |
||
30 | |||
31 | /** |
||
32 | * @var string |
||
33 | */ |
||
34 | protected $id; |
||
35 | |||
36 | /** |
||
37 | * @var bool |
||
38 | */ |
||
39 | protected $stacked; |
||
40 | |||
41 | /** |
||
42 | * @var int |
||
43 | */ |
||
44 | protected $barThickness; |
||
45 | |||
46 | /** |
||
47 | * @var string |
||
48 | */ |
||
49 | protected $position; |
||
50 | |||
51 | /** |
||
52 | * @var string |
||
53 | */ |
||
54 | protected $beforeUpdate; |
||
55 | |||
56 | /** |
||
57 | * @var string |
||
58 | */ |
||
59 | protected $beforeSetDimensions; |
||
60 | |||
61 | /** |
||
62 | * @var string |
||
63 | */ |
||
64 | protected $afterSetDimensions; |
||
65 | |||
66 | /** |
||
67 | * @var string |
||
68 | */ |
||
69 | protected $beforeDataLimits; |
||
70 | |||
71 | /** |
||
72 | * @var string |
||
73 | */ |
||
74 | protected $afterDataLimits; |
||
75 | |||
76 | /** |
||
77 | * @var string |
||
78 | */ |
||
79 | protected $beforeBuildTicks; |
||
80 | |||
81 | /** |
||
82 | * @var string |
||
83 | */ |
||
84 | protected $afterBuildTicks; |
||
85 | |||
86 | /** |
||
87 | * @var string |
||
88 | */ |
||
89 | protected $beforeTickToLabelConversion; |
||
90 | |||
91 | /** |
||
92 | * @var string |
||
93 | */ |
||
94 | protected $afterTickToLabelConversion; |
||
95 | |||
96 | /** |
||
97 | * @var string |
||
98 | */ |
||
99 | protected $beforeCalculateTickRotation; |
||
100 | |||
101 | /** |
||
102 | * @var string |
||
103 | */ |
||
104 | protected $afterCalculateTickRotation; |
||
105 | |||
106 | /** |
||
107 | * @var string |
||
108 | */ |
||
109 | protected $beforeFit; |
||
110 | |||
111 | /** |
||
112 | * @var string |
||
113 | */ |
||
114 | protected $afterFit; |
||
115 | |||
116 | /** |
||
117 | * @var string |
||
118 | */ |
||
119 | protected $afterUpdate; |
||
120 | |||
121 | /** |
||
122 | * @var GridLines |
||
123 | */ |
||
124 | protected $gridLines; |
||
125 | |||
126 | /** |
||
127 | * @var ScaleLabel |
||
128 | */ |
||
129 | protected $scaleLabel; |
||
130 | |||
131 | /** |
||
132 | * @var Ticks |
||
133 | */ |
||
134 | protected $ticks; |
||
135 | |||
136 | /** |
||
137 | * @return string |
||
138 | */ |
||
139 | public function getType() |
||
140 | { |
||
141 | return $this->type; |
||
142 | } |
||
143 | |||
144 | /** |
||
145 | * @param string $type |
||
146 | * |
||
147 | * @return $this |
||
148 | */ |
||
149 | public function setType($type) |
||
150 | { |
||
151 | $this->type = $type; |
||
152 | |||
153 | return $this; |
||
154 | } |
||
155 | |||
156 | /** |
||
157 | * @return bool |
||
158 | */ |
||
159 | public function isDisplay() |
||
160 | { |
||
161 | return $this->display; |
||
162 | } |
||
163 | |||
164 | /** |
||
165 | * @param bool $display |
||
166 | * |
||
167 | * @return $this |
||
168 | */ |
||
169 | public function setDisplay($display) |
||
170 | { |
||
171 | $this->display = $display; |
||
172 | |||
173 | return $this; |
||
174 | } |
||
175 | |||
176 | /** |
||
177 | * @return string |
||
178 | */ |
||
179 | public function getId() |
||
180 | { |
||
181 | return $this->id; |
||
182 | } |
||
183 | |||
184 | /** |
||
185 | * @param string $id |
||
186 | * |
||
187 | * @return $this |
||
188 | */ |
||
189 | public function setId($id) |
||
190 | { |
||
191 | $this->id = strval($id); |
||
192 | |||
193 | return $this; |
||
194 | } |
||
195 | |||
196 | /** |
||
197 | * @return bool |
||
198 | */ |
||
199 | public function isStacked() |
||
200 | { |
||
201 | return $this->stacked; |
||
202 | } |
||
203 | |||
204 | /** |
||
205 | * @param bool $stacked |
||
206 | * |
||
207 | * @return $this |
||
208 | */ |
||
209 | public function setStacked($stacked) |
||
210 | { |
||
211 | $this->stacked = ! ! $stacked; |
||
212 | |||
213 | return $this; |
||
214 | } |
||
215 | |||
216 | /** |
||
217 | * @return int |
||
218 | */ |
||
219 | public function getBarThickness() |
||
220 | { |
||
221 | return $this->barThickness; |
||
222 | } |
||
223 | |||
224 | /** |
||
225 | * @param int $barThickness |
||
226 | * |
||
227 | * @return $this |
||
228 | */ |
||
229 | public function setBarThickness($barThickness) |
||
230 | { |
||
231 | $this->barThickness = intval($barThickness); |
||
232 | |||
233 | return $this; |
||
234 | } |
||
235 | |||
236 | /** |
||
237 | * @return string |
||
238 | */ |
||
239 | public function getPosition() |
||
240 | { |
||
241 | return $this->position; |
||
242 | } |
||
243 | |||
244 | /** |
||
245 | * @param string $position |
||
246 | * |
||
247 | * @return $this |
||
248 | */ |
||
249 | public function setPosition($position) |
||
250 | { |
||
251 | $this->position = strval($position); |
||
252 | |||
253 | return $this; |
||
254 | } |
||
255 | |||
256 | /** |
||
257 | * @return string |
||
258 | */ |
||
259 | public function getBeforeUpdate() |
||
260 | { |
||
261 | return $this->beforeUpdate; |
||
262 | } |
||
263 | |||
264 | /** |
||
265 | * @param string $beforeUpdate |
||
266 | * |
||
267 | * @return $this |
||
268 | */ |
||
269 | public function setBeforeUpdate($beforeUpdate) |
||
270 | { |
||
271 | $this->beforeUpdate = strval($beforeUpdate); |
||
272 | |||
273 | return $this; |
||
274 | } |
||
275 | |||
276 | /** |
||
277 | * @return string |
||
278 | */ |
||
279 | public function getBeforeSetDimensions() |
||
282 | } |
||
283 | |||
284 | /** |
||
285 | * @param string $beforeSetDimensions |
||
286 | * |
||
287 | * @return $this |
||
288 | */ |
||
289 | public function setBeforeSetDimensions($beforeSetDimensions) |
||
290 | { |
||
291 | $this->beforeSetDimensions = strval($beforeSetDimensions); |
||
292 | |||
293 | return $this; |
||
294 | } |
||
295 | |||
296 | /** |
||
297 | * @return string |
||
298 | */ |
||
299 | public function getAfterSetDimensions() |
||
300 | { |
||
301 | return $this->afterSetDimensions; |
||
302 | } |
||
303 | |||
304 | /** |
||
305 | * @param string $afterSetDimensions |
||
306 | * |
||
307 | * @return $this |
||
308 | */ |
||
309 | public function setAfterSetDimensions($afterSetDimensions) |
||
310 | { |
||
311 | $this->afterSetDimensions = strval($afterSetDimensions); |
||
312 | |||
313 | return $this; |
||
314 | } |
||
315 | |||
316 | /** |
||
317 | * @return string |
||
318 | */ |
||
319 | public function getBeforeDataLimits() |
||
320 | { |
||
321 | return $this->beforeDataLimits; |
||
322 | } |
||
323 | |||
324 | /** |
||
325 | * @param string $beforeDataLimits |
||
326 | * |
||
327 | * @return $this |
||
328 | */ |
||
329 | public function setBeforeDataLimits($beforeDataLimits) |
||
330 | { |
||
331 | $this->beforeDataLimits = strval($beforeDataLimits); |
||
332 | |||
333 | return $this; |
||
334 | } |
||
335 | |||
336 | /** |
||
337 | * @return string |
||
338 | */ |
||
339 | public function getAfterDataLimits() |
||
340 | { |
||
341 | return $this->afterDataLimits; |
||
342 | } |
||
343 | |||
344 | /** |
||
345 | * @param string $afterDataLimits |
||
346 | * |
||
347 | * @return $this |
||
348 | */ |
||
349 | public function setAfterDataLimits($afterDataLimits) |
||
350 | { |
||
351 | $this->afterDataLimits = strval($afterDataLimits); |
||
352 | |||
353 | return $this; |
||
354 | } |
||
355 | |||
356 | /** |
||
357 | * @return string |
||
358 | */ |
||
359 | public function getBeforeBuildTicks() |
||
360 | { |
||
361 | return $this->beforeBuildTicks; |
||
362 | } |
||
363 | |||
364 | /** |
||
365 | * @param string $beforeBuildTicks |
||
366 | * |
||
367 | * @return $this |
||
368 | */ |
||
369 | public function setBeforeBuildTicks($beforeBuildTicks) |
||
370 | { |
||
371 | $this->beforeBuildTicks = strval($beforeBuildTicks); |
||
372 | |||
373 | return $this; |
||
374 | } |
||
375 | |||
376 | /** |
||
377 | * @return string |
||
378 | */ |
||
379 | public function getAfterBuildTicks() |
||
380 | { |
||
381 | return $this->afterBuildTicks; |
||
382 | } |
||
383 | |||
384 | /** |
||
385 | * @param string $afterBuildTicks |
||
386 | * |
||
387 | * @return $this |
||
388 | */ |
||
389 | public function setAfterBuildTicks($afterBuildTicks) |
||
390 | { |
||
391 | $this->afterBuildTicks = strval($afterBuildTicks); |
||
392 | |||
393 | return $this; |
||
394 | } |
||
395 | |||
396 | /** |
||
397 | * @return string |
||
398 | */ |
||
399 | public function getBeforeTickToLabelConversion() |
||
402 | } |
||
403 | |||
404 | /** |
||
405 | * @param string $beforeTickToLabelConversion |
||
406 | * |
||
407 | * @return $this |
||
408 | */ |
||
409 | public function setBeforeTickToLabelConversion($beforeTickToLabelConversion) |
||
410 | { |
||
411 | $this->beforeTickToLabelConversion = strval($beforeTickToLabelConversion); |
||
412 | |||
413 | return $this; |
||
414 | } |
||
415 | |||
416 | /** |
||
417 | * @return string |
||
418 | */ |
||
419 | public function getAfterTickToLabelConversion() |
||
420 | { |
||
421 | return $this->afterTickToLabelConversion; |
||
422 | } |
||
423 | |||
424 | /** |
||
425 | * @param string $afterTickToLabelConversion |
||
426 | * |
||
427 | * @return $this |
||
428 | */ |
||
429 | public function setAfterTickToLabelConversion($afterTickToLabelConversion) |
||
430 | { |
||
431 | $this->afterTickToLabelConversion = strval($afterTickToLabelConversion); |
||
432 | |||
433 | return $this; |
||
434 | } |
||
435 | |||
436 | /** |
||
437 | * @return string |
||
438 | */ |
||
439 | public function getBeforeCalculateTickRotation() |
||
440 | { |
||
441 | return $this->beforeCalculateTickRotation; |
||
442 | } |
||
443 | |||
444 | /** |
||
445 | * @param string $beforeCalculateTickRotation |
||
446 | * |
||
447 | * @return $this |
||
448 | */ |
||
449 | public function setBeforeCalculateTickRotation($beforeCalculateTickRotation) |
||
450 | { |
||
451 | $this->beforeCalculateTickRotation = strval($beforeCalculateTickRotation); |
||
452 | |||
453 | return $this; |
||
454 | } |
||
455 | |||
456 | /** |
||
457 | * @return string |
||
458 | */ |
||
459 | public function getAfterCalculateTickRotation() |
||
460 | { |
||
461 | return $this->afterCalculateTickRotation; |
||
462 | } |
||
463 | |||
464 | /** |
||
465 | * @param string $afterCalculateTickRotation |
||
466 | * |
||
467 | * @return $this |
||
468 | */ |
||
469 | public function setAfterCalculateTickRotation($afterCalculateTickRotation) |
||
470 | { |
||
471 | $this->afterCalculateTickRotation = strval($afterCalculateTickRotation); |
||
472 | |||
473 | return $this; |
||
474 | } |
||
475 | |||
476 | /** |
||
477 | * @return string |
||
478 | */ |
||
479 | public function getBeforeFit() |
||
480 | { |
||
481 | return $this->beforeFit; |
||
482 | } |
||
483 | |||
484 | /** |
||
485 | * @param string $beforeFit |
||
486 | * |
||
487 | * @return $this |
||
488 | */ |
||
489 | public function setBeforeFit($beforeFit) |
||
490 | { |
||
491 | $this->beforeFit = strval($beforeFit); |
||
492 | |||
493 | return $this; |
||
494 | } |
||
495 | |||
496 | /** |
||
497 | * @return string |
||
498 | */ |
||
499 | public function getAfterFit() |
||
502 | } |
||
503 | |||
504 | /** |
||
505 | * @param string $afterFit |
||
506 | * |
||
507 | * @return $this |
||
508 | */ |
||
509 | public function setAfterFit($afterFit) |
||
510 | { |
||
511 | $this->afterFit = strval($afterFit); |
||
512 | |||
513 | return $this; |
||
514 | } |
||
515 | |||
516 | /** |
||
517 | * @return string |
||
518 | */ |
||
519 | public function getAfterUpdate() |
||
520 | { |
||
521 | return $this->afterUpdate; |
||
522 | } |
||
523 | |||
524 | /** |
||
525 | * @param string $afterUpdate |
||
526 | * |
||
527 | * @return $this |
||
528 | */ |
||
529 | public function setAfterUpdate($afterUpdate) |
||
530 | { |
||
531 | $this->afterUpdate = strval($afterUpdate); |
||
532 | |||
533 | return $this; |
||
534 | } |
||
535 | |||
536 | /** |
||
537 | * @return GridLines |
||
538 | */ |
||
539 | public function getGridLines() |
||
540 | { |
||
541 | return $this->gridLines; |
||
542 | } |
||
543 | |||
544 | /** |
||
545 | * @return GridLines |
||
546 | */ |
||
547 | public function gridLines() |
||
548 | { |
||
549 | if (is_null($this->gridLines)) { |
||
550 | $this->gridLines = new GridLines(); |
||
551 | } |
||
552 | |||
553 | return $this->gridLines; |
||
554 | } |
||
555 | |||
556 | /** |
||
557 | * @return ScaleLabel |
||
558 | */ |
||
559 | public function getScaleLabel() |
||
560 | { |
||
561 | return $this->scaleLabel; |
||
562 | } |
||
563 | |||
564 | /** |
||
565 | * @return ScaleLabel |
||
566 | */ |
||
567 | public function scaleLabel() |
||
568 | { |
||
569 | if (is_null($this->scaleLabel)) { |
||
570 | $this->scaleLabel = new ScaleLabel(); |
||
571 | } |
||
572 | |||
573 | return $this->scaleLabel; |
||
574 | } |
||
575 | |||
576 | /** |
||
577 | * @return Ticks |
||
578 | */ |
||
579 | public function getTicks() |
||
580 | { |
||
581 | return $this->ticks; |
||
582 | } |
||
583 | |||
584 | /** |
||
585 | * @return Ticks |
||
586 | */ |
||
587 | public function ticks() |
||
594 | } |
||
595 | |||
596 | /** |
||
597 | * @return array |
||
598 | */ |
||
599 | public function jsonSerialize() |
||
602 | } |
||
603 | } |
||
604 |