Total Complexity | 40 |
Total Lines | 367 |
Duplicated Lines | 0 % |
Changes | 2 | ||
Bugs | 0 | Features | 0 |
Complex classes like DataSet often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DataSet, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
14 | class DataSet implements ChartOwnedInterface, ArraySerializableInterface, JsonSerializableInterface |
||
15 | { |
||
16 | use ChartOwned; |
||
17 | use Delegate\ArraySerializable; |
||
18 | use Delegate\JsonSerializable; |
||
19 | |||
20 | /** |
||
21 | * @var string |
||
22 | */ |
||
23 | protected $type; |
||
24 | |||
25 | /** |
||
26 | * @var Data |
||
27 | */ |
||
28 | protected $data; |
||
29 | |||
30 | /** |
||
31 | * @var string |
||
32 | */ |
||
33 | protected $label; |
||
34 | |||
35 | /** |
||
36 | * @var string |
||
37 | */ |
||
38 | protected $xAxisID; |
||
39 | |||
40 | /** |
||
41 | * @var string |
||
42 | */ |
||
43 | protected $yAxisID; |
||
44 | |||
45 | /** |
||
46 | * @var string|string[] |
||
47 | */ |
||
48 | protected $backgroundColor; |
||
49 | |||
50 | /** |
||
51 | * @var string|string[] |
||
52 | */ |
||
53 | protected $borderColor; |
||
54 | |||
55 | /** |
||
56 | * @var int|int[] |
||
57 | */ |
||
58 | protected $borderWidth; |
||
59 | |||
60 | /** |
||
61 | * @var string |
||
62 | */ |
||
63 | protected $borderSkipped; |
||
64 | |||
65 | /** |
||
66 | * @var string|string[] |
||
67 | */ |
||
68 | protected $hoverBackgroundColor; |
||
69 | |||
70 | /** |
||
71 | * @var string|string[] |
||
72 | */ |
||
73 | protected $hoverBorderColor; |
||
74 | |||
75 | /** |
||
76 | * @var int|int[] |
||
77 | */ |
||
78 | protected $hoverBorderWidth; |
||
79 | |||
80 | /** |
||
81 | * @var bool|null |
||
82 | */ |
||
83 | protected $hidden; |
||
84 | |||
85 | /** |
||
86 | * @return string |
||
87 | */ |
||
88 | public function getType() |
||
89 | { |
||
90 | return $this->type; |
||
91 | } |
||
92 | |||
93 | /** |
||
94 | * @param string $type |
||
95 | * |
||
96 | * @return $this |
||
97 | */ |
||
98 | public function setType($type) |
||
99 | { |
||
100 | $this->type = $type; |
||
101 | |||
102 | return $this; |
||
103 | } |
||
104 | |||
105 | /** |
||
106 | * @return Data |
||
107 | */ |
||
108 | public function data() |
||
109 | { |
||
110 | if (is_null($this->data)) { |
||
111 | $this->data = new Data(); |
||
112 | } |
||
113 | |||
114 | return $this->data; |
||
115 | } |
||
116 | |||
117 | /** |
||
118 | * @return string |
||
119 | */ |
||
120 | public function getLabel() |
||
121 | { |
||
122 | return $this->label; |
||
123 | } |
||
124 | |||
125 | /** |
||
126 | * @param string $label |
||
127 | * |
||
128 | * @return $this |
||
129 | */ |
||
130 | public function setLabel($label) |
||
131 | { |
||
132 | $this->label = strval($label); |
||
133 | |||
134 | return $this; |
||
135 | } |
||
136 | |||
137 | /** |
||
138 | * @return string |
||
139 | */ |
||
140 | public function getXAxisID() |
||
141 | { |
||
142 | return $this->xAxisID; |
||
143 | } |
||
144 | |||
145 | /** |
||
146 | * @param string $xAxisID |
||
147 | * |
||
148 | * @return $this |
||
149 | */ |
||
150 | public function setXAxisID($xAxisID) |
||
151 | { |
||
152 | $this->xAxisID = strval($xAxisID); |
||
153 | |||
154 | return $this; |
||
155 | } |
||
156 | |||
157 | /** |
||
158 | * @return string |
||
159 | */ |
||
160 | public function getYAxisID() |
||
161 | { |
||
162 | return $this->yAxisID; |
||
163 | } |
||
164 | |||
165 | /** |
||
166 | * @param string $yAxisID |
||
167 | * |
||
168 | * @return $this |
||
169 | */ |
||
170 | public function setYAxisID($yAxisID) |
||
171 | { |
||
172 | $this->yAxisID = strval($yAxisID); |
||
173 | |||
174 | return $this; |
||
175 | } |
||
176 | |||
177 | /** |
||
178 | * @return string|string[] |
||
179 | */ |
||
180 | public function getBackgroundColor() |
||
181 | { |
||
182 | return $this->backgroundColor; |
||
183 | } |
||
184 | |||
185 | /** |
||
186 | * @param string|string[] $backgroundColor |
||
187 | * |
||
188 | * @return $this |
||
189 | */ |
||
190 | public function setBackgroundColor($backgroundColor) |
||
191 | { |
||
192 | if (is_array($backgroundColor)) { |
||
193 | $backgroundColor = array_map('strval', $backgroundColor); |
||
194 | } |
||
195 | if (! is_array($backgroundColor)) { |
||
196 | $backgroundColor = strval($backgroundColor); |
||
197 | } |
||
198 | |||
199 | $this->backgroundColor = $backgroundColor; |
||
200 | |||
201 | return $this; |
||
202 | } |
||
203 | |||
204 | /** |
||
205 | * @return string|string[] |
||
206 | */ |
||
207 | public function getBorderColor() |
||
208 | { |
||
209 | return $this->borderColor; |
||
210 | } |
||
211 | |||
212 | /** |
||
213 | * @param string|string[] $borderColor |
||
214 | * |
||
215 | * @return $this |
||
216 | */ |
||
217 | public function setBorderColor($borderColor) |
||
218 | { |
||
219 | if (is_array($borderColor)) { |
||
220 | $borderColor = array_map('strval', $borderColor); |
||
221 | } |
||
222 | if (! is_array($borderColor)) { |
||
223 | $borderColor = strval($borderColor); |
||
224 | } |
||
225 | |||
226 | $this->borderColor = $borderColor; |
||
227 | |||
228 | return $this; |
||
229 | } |
||
230 | |||
231 | /** |
||
232 | * @return int|int[] |
||
233 | */ |
||
234 | public function getBorderWidth() |
||
237 | } |
||
238 | |||
239 | /** |
||
240 | * @param int|int[] $borderWidth |
||
241 | * |
||
242 | * @return $this |
||
243 | */ |
||
244 | public function setBorderWidth($borderWidth) |
||
245 | { |
||
246 | if (is_array($borderWidth)) { |
||
247 | $borderWidth = array_map('intval', $borderWidth); |
||
248 | } |
||
249 | if (! is_array($borderWidth)) { |
||
250 | $borderWidth = intval($borderWidth); |
||
251 | } |
||
252 | |||
253 | $this->borderWidth = $borderWidth; |
||
254 | |||
255 | return $this; |
||
256 | } |
||
257 | |||
258 | /** |
||
259 | * @return string |
||
260 | */ |
||
261 | public function getBorderSkipped() |
||
262 | { |
||
263 | return $this->borderSkipped; |
||
264 | } |
||
265 | |||
266 | /** |
||
267 | * @param string $borderSkipped |
||
268 | * |
||
269 | * @return $this |
||
270 | */ |
||
271 | public function setBorderSkipped($borderSkipped) |
||
272 | { |
||
273 | $this->borderSkipped = strval($borderSkipped); |
||
274 | |||
275 | return $this; |
||
276 | } |
||
277 | |||
278 | /** |
||
279 | * @return string|string[] |
||
280 | */ |
||
281 | public function getHoverBackgroundColor() |
||
282 | { |
||
283 | return $this->hoverBackgroundColor; |
||
284 | } |
||
285 | |||
286 | /** |
||
287 | * @param string|string[] $hoverBackgroundColor |
||
288 | * |
||
289 | * @return $this |
||
290 | */ |
||
291 | public function setHoverBackgroundColor($hoverBackgroundColor) |
||
292 | { |
||
293 | if (is_array($hoverBackgroundColor)) { |
||
294 | $hoverBackgroundColor = array_map('strval', $hoverBackgroundColor); |
||
295 | } |
||
296 | if (! is_array($hoverBackgroundColor)) { |
||
297 | $hoverBackgroundColor = strval($hoverBackgroundColor); |
||
298 | } |
||
299 | |||
300 | $this->hoverBackgroundColor = $hoverBackgroundColor; |
||
301 | |||
302 | return $this; |
||
303 | } |
||
304 | |||
305 | /** |
||
306 | * @return string|string[] |
||
307 | */ |
||
308 | public function getHoverBorderColor() |
||
311 | } |
||
312 | |||
313 | /** |
||
314 | * @param string|string[] $hoverBorderColor |
||
315 | * |
||
316 | * @return $this |
||
317 | */ |
||
318 | public function setHoverBorderColor($hoverBorderColor) |
||
319 | { |
||
320 | if (is_array($hoverBorderColor)) { |
||
321 | $hoverBorderColor = array_map('strval', $hoverBorderColor); |
||
322 | } |
||
323 | if (! is_array($hoverBorderColor)) { |
||
324 | $hoverBorderColor = strval($hoverBorderColor); |
||
325 | } |
||
326 | |||
327 | $this->hoverBorderColor = $hoverBorderColor; |
||
328 | |||
329 | return $this; |
||
330 | } |
||
331 | |||
332 | /** |
||
333 | * @return int|int[] |
||
334 | */ |
||
335 | public function getHoverBorderWidth() |
||
338 | } |
||
339 | |||
340 | /** |
||
341 | * @param int|int[] $hoverBorderWidth |
||
342 | * |
||
343 | * @return $this |
||
344 | */ |
||
345 | public function setHoverBorderWidth($hoverBorderWidth) |
||
357 | } |
||
358 | |||
359 | /** |
||
360 | * @return bool|null |
||
361 | */ |
||
362 | public function isHidden() |
||
363 | { |
||
364 | if (is_null($this->hidden)) { |
||
365 | $this->hidden = false; |
||
366 | } |
||
367 | |||
368 | return $this->hidden; |
||
369 | } |
||
370 | |||
371 | /** |
||
372 | * @param bool|null $hidden |
||
373 | * |
||
374 | * @return $this |
||
375 | */ |
||
376 | public function setHidden($hidden) |
||
381 | } |
||
382 | } |
||
383 |