Request::getPostData() - Code Metrics - Inspection of "Update scrutinizer.yml" - half2me/curlx - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 700166...f06841 )

by Benjamin

created 2016-02-09 21:50 UTC

Request::getPostData() A

↳ Parent: Request

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php
/**
 * Created by PhpStorm.
 * User: lejla
 * Date: 2016.02.09.
 * Time: 17:34
 */

namespace CurlX;

/**
 * Class Request
 * @package CurlX
 *
 * @property string $url
 * @property array $post
 * @property float $time
 * @property int $timeout
 * @property array $options
 * @property array $headers
 * @property resource $handle
 * @property mixed $response
 * @property callable[] $listeners
 */
class Request implements RequestInterface
{
    protected $url;
    protected $post = [];
    protected $startTime;
    protected $endTime;
    protected $result;
    protected $listeners = [];
    protected $timeout;
    protected $curlHandle;
    protected $headers = [];
    protected $options = [];
    protected $success;
    protected $response;

    private function camelize($str)
    {
        return str_replace('_', '', ucwords($str, '_'));
    }

    public function __set($name, $value)

    {
        $c = $this->camelize($name);
        $m = "set$c";
        if(method_exists($this, $m)) {
            return $this->$m($value);
        }
        else user_error("undefined property $name");
    }

    public function __get($name) {

        $c = $this->camelize($name);
        $m = "get$c";
        if(method_exists($this, $m)) {
            return $this->$m();
        }
        else user_error("undefined property $name");
    }

    /**
     * Request constructor.
     * @param string $url optional url
     */
    public function __construct($url = null)
    {
        $this->setUrl($url);

        // Defaults
        $this->options[CURLOPT_RETURNTRANSFER] = true;
        $this->options[CURLOPT_NOSIGNAL] = 1;
    }

    public function setUrl($url)
    {
        if (!filter_var($url, FILTER_VALIDATE_URL) === false) {
            $this->url = $url;
        }
    }

    public function getUrl()
    {
        return $this->url;
    }

    public function setPostData(array $postValues)
    {
        $this->post += $postValues;
        $this->options[CURLOPT_POST] = 1;
        if(!empty($this->post)) {
            $this->options[CURLOPT_POSTFIELDS] = http_build_query($this->post);
        }
    }

    public function getPostData()
    {
        return $this->post;
    }

    public function getTime()
    {
        return $this->endTime - $this->startTime;
    }

    public function startTimer()
    {
        $this->startTime = microtime(true);
    }

    public function stopTimer()
    {
        $this->endTime = microtime(true);
    }

    public function getResult()
    {
        return $this->result;
    }

    public function callBack($result)
    {
        $this->stopTimer();
        $this->result = $result;

        $requestInfo = curl_getinfo($this->curlHandle);

        if(curl_errno($this->curlHandle) !== 0 || intval($requestInfo['http_code']) !== 200) {
            $this->success = false;
        } else {
            $this->success = true;
            $this->response = curl_multi_getcontent($this->ch);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        $this->notify();
    }

    public function addListener(callable $function)
    {
        if(is_callable($function)) {
            $this->listeners += $function;
        }
    }

    protected function notify()
    {
        foreach($this->listeners as $listener)
        {
           call_user_func($listener, $this);
        }
    }

    public function setTimeout($timeout)
    {
        if ($timeout > 0) {
            $this->timeout = $timeout;
            $this->options[CURLOPT_TIMEOUT_MS] = $this->timeout;
        }
    }

    public function getHandle()
    {
        if(!isset($this->curlHandle)) {
            $this->curlHandle = curl_init($this->url);
            curl_setopt_array($this->curlHandle, $this->options);
        }

        return $this->curlHandle;
    }

    function setHeaders(array $headers)

    {
        $this->headers += $headers;
        $this->options[CURLOPT_HTTPHEADER] = $headers;
    }

    function getHeaders()

    {
        return $this->headers;
    }

    function setOptions(array $options)

    {
        $this->options += $options;
    }

    function getOptions()

    {
        return $this->options;
    }

    function getResponse()

    {
        return $this->response;
    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: lejla
5		* Date: 2016.02.09.
6		* Time: 17:34
7		*/
8
9		namespace CurlX;
10
11		/**
12		* Class Request
13		* @package CurlX
14		*
15		* @property string $url
16		* @property array $post
17		* @property float $time
18		* @property int $timeout
19		* @property array $options
20		* @property array $headers
21		* @property resource $handle
22		* @property mixed $response
23		* @property callable[] $listeners
24		*/
25		class Request implements RequestInterface
26		{
27		protected $url;
28		protected $post = [];
29		protected $startTime;
30		protected $endTime;
31		protected $result;
32		protected $listeners = [];
33		protected $timeout;
34		protected $curlHandle;
35		protected $headers = [];
36		protected $options = [];
37		protected $success;
38		protected $response;
39
40		private function camelize($str)
41		{
42		return str_replace('_', '', ucwords($str, '_'));
43		}
44
45	View Code Duplication	public function __set($name, $value)
		0 ignored issues – show Duplication introduced 2016-02-09 21:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		{
47		$c = $this->camelize($name);
48		$m = "set$c";
49		if(method_exists($this, $m)) {
50		return $this->$m($value);
51		}
52		else user_error("undefined property $name");
53		}
54
55	View Code Duplication	public function __get($name) {
		0 ignored issues – show Duplication introduced 2016-02-09 21:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		$c = $this->camelize($name);
57		$m = "get$c";
58		if(method_exists($this, $m)) {
59		return $this->$m();
60		}
61		else user_error("undefined property $name");
62		}
63
64		/**
65		* Request constructor.
66		* @param string $url optional url
67		*/
68		public function __construct($url = null)
69		{
70		$this->setUrl($url);
71
72		// Defaults
73		$this->options[CURLOPT_RETURNTRANSFER] = true;
74		$this->options[CURLOPT_NOSIGNAL] = 1;
75		}
76
77		public function setUrl($url)
78		{
79		if (!filter_var($url, FILTER_VALIDATE_URL) === false) {
80		$this->url = $url;
81		}
82		}
83
84		public function getUrl()
85		{
86		return $this->url;
87		}
88
89		public function setPostData(array $postValues)
90		{
91		$this->post += $postValues;
92		$this->options[CURLOPT_POST] = 1;
93		if(!empty($this->post)) {
94		$this->options[CURLOPT_POSTFIELDS] = http_build_query($this->post);
95		}
96		}
97
98		public function getPostData()
99		{
100		return $this->post;
101		}
102
103		public function getTime()
104		{
105		return $this->endTime - $this->startTime;
106		}
107
108		public function startTimer()
109		{
110		$this->startTime = microtime(true);
111		}
112
113		public function stopTimer()
114		{
115		$this->endTime = microtime(true);
116		}
117
118		public function getResult()
119		{
120		return $this->result;
121		}
122
123		public function callBack($result)
124		{
125		$this->stopTimer();
126		$this->result = $result;
127
128		$requestInfo = curl_getinfo($this->curlHandle);
129
130		if(curl_errno($this->curlHandle) !== 0 \|\| intval($requestInfo['http_code']) !== 200) {
131		$this->success = false;
132		} else {
133		$this->success = true;
134		$this->response = curl_multi_getcontent($this->ch);
		0 ignored issues – show Documentation introduced 2016-02-09 21:53 UTC by Report Bug Copy Issue Report The property `ch` does not exist on `object<CurlX\Request>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
135		}
136
137		$this->notify();
138		}
139
140		public function addListener(callable $function)
141		{
142		if(is_callable($function)) {
143		$this->listeners += $function;
144		}
145		}
146
147		protected function notify()
148		{
149		foreach($this->listeners as $listener)
150		{
151		call_user_func($listener, $this);
152		}
153		}
154
155		public function setTimeout($timeout)
156		{
157		if ($timeout > 0) {
158		$this->timeout = $timeout;
159		$this->options[CURLOPT_TIMEOUT_MS] = $this->timeout;
160		}
161		}
162
163		public function getHandle()
164		{
165		if(!isset($this->curlHandle)) {
166		$this->curlHandle = curl_init($this->url);
167		curl_setopt_array($this->curlHandle, $this->options);
168		}
169
170		return $this->curlHandle;
171		}
172
173		function setHeaders(array $headers)
		0 ignored issues – show Best Practice introduced 2016-02-09 21:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
174		{
175		$this->headers += $headers;
176		$this->options[CURLOPT_HTTPHEADER] = $headers;
177		}
178
179		function getHeaders()
		0 ignored issues – show Best Practice introduced 2016-02-09 21:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
180		{
181		return $this->headers;
182		}
183
184		function setOptions(array $options)
		0 ignored issues – show Best Practice introduced 2016-02-09 21:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
185		{
186		$this->options += $options;
187		}
188
189		function getOptions()
		0 ignored issues – show Best Practice introduced 2016-02-09 21:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
190		{
191		return $this->options;
192		}
193
194		function getResponse()
		0 ignored issues – show Best Practice introduced 2016-02-09 21:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
195		{
196		return $this->response;
197		}
198		}

half2me / curlx

Push — master ( 700166...f06841 )

Request::getPostData() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like