hal2dy / html-scan

src/helper/output.js

const fs = require('fs')
const { join } = require('path')
const { Writable } = require('stream')

module.exports = (output, data) => {
  if (!data) {
    return null
  }

  if (typeof output === 'string') {
    // Output as file
    const path = join(output)
    fs.open(path, fs.W_OK, err => {
      if (err) {
        console.error(`Cannot write file to ${path}`)
        return
      }
      fs.appendFileSync(path, data + '\r\n')
    })

There is no return statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding return undefined; explicitly.

  } else if (output instanceof Writable) {
    // Output as stream
    output.write(data + '\r\n')
    output.on('error', err => {
      console.error(err)
    })

There is no return statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding return undefined; explicitly.

  } else {
    // Output as console
    console.log(data)
    return

This return has no effect and can be removed.

  }
}