hafijul233 / ci-recharge

src/Commands/MakeSeeder.php

<?php namespace Hafiz\Commands;

use CodeIgniter\CLI\BaseCommand;
use CodeIgniter\CLI\CLI;
use Hafiz\Libraries\DBHandler;
use Hafiz\Libraries\FileHandler;

/**
 * Make Commadn for Seeder File Generation Class
 * Seeder can be skeleton aor loaded from a database table
 *
 * @package CodeIgniter\Commands
 * @extend BaseCommand
 */
class MakeSeeder extends BaseCommand
{

    /**
     * The group command is heading under all
     * commands will be listed
     * @var string
     */
    protected $group = 'CI4-Recharge';

    /**
     * The Command's name
     * @var string
     */
    protected $name = 'make:seed';

    /**
     * The Command's short description
     * @var string
     */
    protected $description = 'Creates a Seeder file.';

    /**
     * The Command's usage
     * @var string
     */
    protected $usage = 'make:seed [seed_name] [Options]';

    /**
     * The Command's Arguments
     * @var array
     */
    protected $arguments = [
        'seed_name' => 'The Seeder file name',
    ];

    /**
     * The Command's Options
     * @var array
     */
    protected $options = [
        '-n' => 'Set seed namespace',
        '-t' => 'Set seed Database table',

    ];

    /**
     * Creates a new entity file with the current timestamp.
     * @param array $params
     * @return void
     */
    public function run(array $params = [])
    {
        helper(['inflector', 'filesystem']);
        $file = new FileHandler();

        $name = array_shift($params);
        $ns = $params['-n'] ?? CLI::getOption('n');
        $table = $params['-t'] ?? CLI::getOption('t');

        if (empty($name)) {
            $name = CLI::prompt(lang('Recharge.nameSeed'));
        }

        if (empty($name)) {
            CLI::error(lang('Recharge.badName'));
            return;
        }

        //namespace locator
        $nsinfo = $file->getNamespaceInfo($ns, 'App');

        //class & file name
        $name = singular(pascalize($name)) . ((stripos($name, 'seeder') == false) ? 'Seeder' : '');

It seems like you are loosely comparing stripos($name, 'seeder') of type integer to the boolean false. If you are specifically checking for 0, consider using something more explicit like === 0 instead.

        $ns = $nsinfo['ns'];
        $targetDir = $nsinfo['path'] . '/Database/Seeds/';
        $filepath = $targetDir . $name . '.php';

        if ($file->verifyDirectory($filepath)) {
            //do we have to add table info
            if (!empty($table)) {
                $db = new DBHandler();
                if ($db->checkTableExist($table))

It seems like $table can also be of type boolean; however, parameter $table of Hafiz\Libraries\DBHandler::checkTableExist() does only seem to accept string, maybe add an additional type check?

                    $properties = $db->generateRowArray($table);
            }

            $data = ['{namespace}' => $ns, '{name}' => $name, '{created_at}' => date("d F, Y h:i:s A"),
                '{seeder}' => $properties ?? NULL, '{table}' => $table ?? NULL];

            //check a directory exist
            if ($file->checkFileExist($filepath) == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

                $template = $file->renderTemplate('seed', $data);


                if (!write_file($filepath, $template)) {
                    CLI::error(lang('Recharge.writeError', [$filepath]));
                    return;
                }

                CLI::write('Created file: ' . CLI::color($filepath, 'green'));
            }
        }
    }
}