Ftp::save() - Code Metrics - Inspection of "Filename: create unique filename move to own class" - h4kuna/upload - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 054527...66f8cc )

by Milan

created 2017-09-22 06:22 UTC

Ftp::save() A

↳ Parent: Ftp

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	10
rs	9.4285
c	1
b	0
f	0
cc	2
eloc	7
nc	2
nop	2

<?php

namespace h4kuna\Upload\Driver;

use h4kuna\Upload,
	Nette\Http;

class Ftp implements Upload\IDriver
{
	/** @var string */
	private $hostUrl;

	/** @var \Ftp */
	private $ftp;

	public function __construct($hostUrl, \Ftp $ftp)
	{
		$this->hostUrl = $hostUrl;
		$this->ftp = $ftp;
	}

	public function createURI($relativePath)
	{
		return $this->hostUrl . '/' . Upload\Utils::makeRelativePath($relativePath);
	}

	public function isFileExists($relativePath)
	{
		return $this->ftp->fileExists(Upload\Utils::makeRelativePath($relativePath));
	}

	public function save(Http\FileUpload $fileUpload, $relativePath)
	{
		$path = Upload\Utils::makeRelativePath($relativePath);
		$dir = dirname($relativePath);
		if ($dir !== '.') {
			$this->ftp->mkDirRecursive($dir);
		}
		$this->ftp->put($path, $fileUpload->getTemporaryFile(), FTP_BINARY);
		@unlink($fileUpload->getTemporaryFile());
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
	}

	public function remove($relativePath)
	{
		$path = Upload\Utils::makeRelativePath($relativePath);
		$this->ftp->delete($path);

		return !$this->isFileExists($path);
	}
}

1			<?php
2
3			namespace h4kuna\Upload\Driver;
4
5			use h4kuna\Upload,
6			Nette\Http;
7
8			class Ftp implements Upload\IDriver
9			{
10			/** @var string */
11			private $hostUrl;
12
13			/** @var \Ftp */
14			private $ftp;
15
16			public function __construct($hostUrl, \Ftp $ftp)
17			{
18			$this->hostUrl = $hostUrl;
19			$this->ftp = $ftp;
20			}
21
22			public function createURI($relativePath)
23			{
24			return $this->hostUrl . '/' . Upload\Utils::makeRelativePath($relativePath);
25			}
26
27			public function isFileExists($relativePath)
28			{
29			return $this->ftp->fileExists(Upload\Utils::makeRelativePath($relativePath));
30			}
31
32			public function save(Http\FileUpload $fileUpload, $relativePath)
33			{
34			$path = Upload\Utils::makeRelativePath($relativePath);
35			$dir = dirname($relativePath);
36			if ($dir !== '.') {
37			$this->ftp->mkDirRecursive($dir);
38			}
39			$this->ftp->put($path, $fileUpload->getTemporaryFile(), FTP_BINARY);
40			@unlink($fileUpload->getTemporaryFile());
			0 ignored issues – show Security Best Practice introduced 2017-07-31 17:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
41			}
42
43			public function remove($relativePath)
44			{
45			$path = Upload\Utils::makeRelativePath($relativePath);
46			$this->ftp->delete($path);
47
48			return !$this->isFileExists($path);
49			}
50			}

h4kuna / upload

Push — master ( 054527...66f8cc )

Ftp::save() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like