h4kuna\Fio\Utils\FioFactory

Complexity

Total Complexity

15

Size/Duplication

Total Lines	114
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	setTemp()	0	4	2
A	createFioRead()	0	4	1
A	createFioPay()	0	6	1
A	createQueue()	0	4	1
A	createAccountCollection()	0	4	1
A	getAccountCollection()	0	4	1
A	getAccount()	0	8	2
A	getQueue()	0	4	1
A	getTransactionClass()	0	4	1
A	createTransactionListFactory()	0	4	1
A	createReader()	0	4	1
A	createXmlFile()	0	4	1

<?php

namespace h4kuna\Fio\Utils;

use h4kuna\Fio;

class FioFactory
{

	/** @var Fio\Account\AccountCollection */
	private $accountCollection;

	/** @var Fio\Request\IQueue */
	private $queue;

	/** @var string */
	private $transactionClass;

	/** @var string */
	protected $temp;

	public function __construct(array $accounts, $transactionClass = NULL, $temp = NULL)
	{
		$this->setTemp($temp);
		$this->accountCollection = $this->createAccountCollection($accounts);
		$this->queue = $this->createQueue();
		$this->transactionClass = $transactionClass;
	}

	private function setTemp($temp)
	{
		$this->temp = $temp ? : sys_get_temp_dir();
	}

	/**
	 * @param string $name Configured account name from AccountCollection
	 * @return Fio\FioRead
	 */
	public function createFioRead($name = NULL)
	{
		return new Fio\FioRead($this->getQueue(), $this->getAccount($name), $this->createReader());
	}

	/**
	 * @param string $name Configured account name from AccountCollection
	 * @return Fio\FioPay
	 */
	public function createFioPay($name = NULL)
	{
		return new Fio\FioPay(
			$this->getQueue(), $this->getAccount($name), $this->createXmlFile()
		);
	}

	/**
	 * COMMON ******************************************************************
	 * *************************************************************************
	 */
	protected function createQueue()
	{
		return new Fio\Request\Queue($this->temp);
	}

	protected function createAccountCollection(array $accounts)
	{
		return Fio\Account\AccountCollectionFactory::create($accounts);
	}

	final protected function getAccountCollection()
	{
		return $this->accountCollection;
	}

	/**
	 * @param string $name Configured account name from AccountCollection
	 * @return Fio\Account\FioAccount
	 */
	final protected function getAccount($name)
	{
		if ($name) {
			return $this->getAccountCollection()->get($name);
		}

		return $this->getAccountCollection()->getDefault();

The expression $this->getAccountCollection()->getDefault(); of type h4kuna\Fio\Account\FioAccount|false adds false to the return on line 84 which is incompatible with the return type documented by h4kuna\Fio\Utils\FioFactory::getAccount of type h4kuna\Fio\Account\FioAccount. It seems like you forgot to handle an error condition.

	}

	final protected function getQueue()
	{
		return $this->queue;
	}

	final protected function getTransactionClass()
	{
		return $this->transactionClass;
	}

	/**
	 * READ ********************************************************************
	 * *************************************************************************
	 */
	protected function createTransactionListFactory()
	{
		return new Fio\Response\Read\JsonTransactionFactory($this->getTransactionClass());
	}

	protected function createReader()
	{
		return new Fio\Request\Read\Files\Json($this->createTransactionListFactory());
	}

	/**
	 * PAY *********************************************************************
	 * *************************************************************************
	 */
	protected function createXmlFile()
	{
		return new Fio\Request\Pay\XMLFile($this->temp);
	}

}