h4kuna / fio

src/Response/Read/JsonTransactionFactory.php

<?php

namespace h4kuna\Fio\Response\Read;

use h4kuna\Fio,
	h4kuna\Fio\Utils;

/**
 * @author Milan Matějček
 */
class JsonTransactionFactory implements ITransactionListFactory
{

	/** @var string[] */
	private static $property;

	/** @var string */
	private $transactionClass;

	/** @var bool */
	protected $transactionClassCheck = false;

	/**
	 * @param string $transactionClass
	 */
	public function __construct($transactionClass = null)
	{
		if ($transactionClass === null) {
			$transactionClass = __NAMESPACE__ . '\Transaction';
		}
		$this->transactionClass = $transactionClass;
	}

	public function createInfo($data, $dateFormat)
	{
		$data->dateStart = Utils\Strings::createFromFormat($data->dateStart, $dateFormat);
		$data->dateEnd = Utils\Strings::createFromFormat($data->dateEnd, $dateFormat);
		return $data;
	}

	public function createTransaction($data, $dateFormat)
	{
		$transaction = $this->createTransactionObject($dateFormat);

The expression $this->createTransactionObject($dateFormat); of type h4kuna\Fio\Response\Read\TransactionAbstract|string adds the type string to the return on line 48 which is incompatible with the return type declared by the interface h4kuna\Fio\Response\Read\ITransactionListFactory::createTransaction of type h4kuna\Fio\Response\Read\TransactionAbstract.

		foreach (self::metaProperty($transaction) as $id => $meta) {
			$value = isset($data->{'column' . $id}) ? $data->{'column' . $id}->value : null;
			$transaction->bindProperty($meta['name'], $meta['type'], $value);
		}
		return $transaction;
	}

	/** @return TransactionList */
	public function createTransactionList($info)
	{
		return new TransactionList($info);
	}

	protected function createTransactionObject($dateFormat)
	{
		if ($this->transactionClassCheck === false) {
			if (is_string($this->transactionClass)) {
				$class = $this->transactionClass;
				$this->transactionClass = new $class($dateFormat);

It seems like new $class($dateFormat) of type object is incompatible with the declared type string of property $transactionClass.

			} else {
				throw new Fio\InvalidArgumentException('Add you class as string.');
			}

			if (!$this->transactionClass instanceof TransactionAbstract) {
				throw new Fio\TransactionExtendException('Transaction class must extends TransationAbstract.');
			}
			$this->transactionClassCheck = true;
		}

		return clone $this->transactionClass;
	}

	private static function metaProperty($class)
	{
		if (self::$property !== null) {
			return self::$property;
		}
		$reflection = new \ReflectionClass($class);
		if (!preg_match_all('/@property-read (?P<type>[\w|]+) \$(?P<name>\w+).*\[(?P<id>\d+)\]/', $reflection->getDocComment(), $find)) {
			throw new Fio\TransactionPropertyException('Property not found you have bad syntax.');
		}

		self::$property = [];
		foreach ($find['name'] as $key => $property) {
			self::$property[$find['id'][$key]] = ['type' => strtolower($find['type'][$key]), 'name' => $property];
		}
		return self::$property;
	}

}